Author: pete.muir(a)jboss.org Date: 2009-07-23 09:28:41 -0400 (Thu, 23 Jul 2009) New Revision: 3153 Modified: tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/definition/stereotype/StereotypeDefinitionTest.java tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/event/EventTest.java tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/event/transactionalObservers/EventTest.java tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/interceptors/definition/InterceptorDefinitionTest.java tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/lookup/el/ResolutionByNameTest.java Log: Remove a few stubs Modified: tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/definition/stereotype/StereotypeDefinitionTest.java =================================================================== --- tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/definition/stereotype/StereotypeDefinitionTest.java 2009-07-23 13:14:00 UTC (rev 3152) +++ tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/definition/stereotype/StereotypeDefinitionTest.java 2009-07-23 13:28:41 UTC (rev 3153) @@ -7,7 +7,6 @@ import javax.enterprise.context.RequestScoped; import javax.enterprise.context.SessionScoped; import javax.enterprise.inject.AnnotationLiteral; -import javax.enterprise.inject.deployment.Production; import javax.enterprise.inject.spi.Bean; import org.hibernate.tck.annotations.SpecAssertion; @@ -26,15 +25,6 @@ { private static final Annotation TAME_LITERAL = new AnnotationLiteral<Tame>() {}; - @Test(groups = { "annotationDefinition", "stub" }) - @SpecAssertion(section = "2.7.1", id = "b") - public void testHasStereotypeAnnotation() - { - assert false; - //Bean<Goat> bean = getBeans(Goat.class).iterator().next(); - //assert !bean.getDeploymentType().equals(HornedAnimalDeploymentType.class); - } - @Test @SpecAssertions( { @SpecAssertion(section = "2.7.1.1", id = "aa"), @SpecAssertion(section = "2.4.3", id = "c") }) Modified: tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/event/EventTest.java =================================================================== --- tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/event/EventTest.java 2009-07-23 13:14:00 UTC (rev 3152) +++ tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/event/EventTest.java 2009-07-23 13:28:41 UTC (rev 3153) @@ -325,7 +325,7 @@ assert spider.getWeb().getRings() == 1; } - @Test(groups = { "events", "stub" }) + @Test(groups = { "events", "broken" }) @SpecAssertion(section = "10.5", id = "ca") public void testAsynchronousObserverThrowsExceptionIsLogged() throws InterruptedException { @@ -334,13 +334,6 @@ //TODO How can we assert that the exception was logged? } - @Test(groups = { "events", "stub" }) - @SpecAssertion(section = "10.5.1", id = "review") // I think this has been removed from the spec - public void testAsynchronousObserverMethodContexts() - { - assert false; - } - @Test(groups = { "events" }, expectedExceptions = { IllegalArgumentException.class }) @SpecAssertion(section = "11.3.10", id = "d") public void testDuplicateBindingsToFireFails() @@ -412,62 +405,6 @@ assert BullTerrier.isSingleBindingEventObserved(); } - @Test(groups = { "events", "stub" }) - @SpecAssertions( { @SpecAssertion(section = "10.7", id = "review") }) // removed from spec? - public void testEventTypeMappedToJmsTopic() - { - assert false; - } - - @Test(groups = { "events", "stub" }) - @SpecAssertions( { @SpecAssertion(section = "10.7", id = "review") }) // removed from spec? - public void testEventMappingIsObserverMethodDeclaredByInterface() - { - assert false; - } - - @Test(groups = { "events", "stub" }) - @SpecAssertions( { @SpecAssertion(section = "10.7", id = "review") }) // removed from spec? - public void testEventParameterSpecifiesMappedEventTypeAndBindings() - { - assert false; - } - - @Test(groups = { "events", "stub" }) - @SpecAssertions( { @SpecAssertion(section = "10.7", id = "review") }) // removed from spec? - public void testMessageDestinationInjectedIsMappedTopic() - { - assert false; - } - - @Test(groups = { "events", "stub" }) - @SpecAssertions( { @SpecAssertion(section = "10.7", id = "review") }) // removed from spec? - public void testEventMappingMemberOfAnyInterface() - { - assert false; - } - - @Test(groups = { "events", "stub" }) - @SpecAssertions( { @SpecAssertion(section = "10.7", id = "review") }) // removed from spec? - public void testObserversOfJmsTopicMustBeAsynchronous() - { - assert false; - } - - @Test(groups = { "events", "stub" }) - @SpecAssertions( { @SpecAssertion(section = "10.7", id = "review") }) // removed from spec? - public void testObserversNotifiedOfEventFromJmsTopic() - { - assert false; - } - - @Test(groups = { "events", "stub" }) - @SpecAssertions( { @SpecAssertion(section = "10.7", id = "review") }) // removed from spec? - public void testEventsDistributedToProcessesWithSameTypeAndJmsTopic() - { - assert false; - } - /** * By default, Java implementation reuse is assumed. In this case, the * producer, disposal and observer methods of the first bean are not Modified: tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/event/transactionalObservers/EventTest.java =================================================================== --- tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/event/transactionalObservers/EventTest.java 2009-07-23 13:14:00 UTC (rev 3152) +++ tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/event/transactionalObservers/EventTest.java 2009-07-23 13:28:41 UTC (rev 3153) @@ -149,57 +149,6 @@ assert dog.isCorrectTransactionState(); } - /** - * If the observer method is an asynchronous transactional observer method - * and there is currently a JTA transaction in progress, the observer object - * calls the observer method asynchronously during the after transaction - * completion phase. - */ - @Test(groups = { "stub", "events" }) - @SpecAssertion(section = "review", id = "review") - public void testAsynchronousTransactionalObserverCalledAfterCompletion() - { - assert false; - } - - /** - * Otherwise, the observer method is called in the same transaction context, - * client security context and lifecycle contexts as the invocation of - * Event.fire(). - */ - @Test(groups = { "stub", "events", "integration" }) - @SpecAssertion(section = "10.5.1", id = "da") - public void testObserverMethodCalledInSameContexts() - { - assert false; - } - - /** - * Otherwise, if the observer method is a @BeforeTransactionCompletion - * transactional observer method, it is called within the context of the - * transaction that is about to complete and with the same client security - * context and lifecycle contexts. - */ - @Test(groups = { "stub", "events", "integration" }) - @SpecAssertion(section = "10.5.1", id = "ba") - public void testBeforeTransactionCompletionObserverMethodContexts() - { - assert false; - } - - /** - * Otherwise, if the observer method is any other kind of transactional - * observer method, it is called in an unspecified transaction context, but - * with the same client security context and lifecycle contexts as the - * transaction that just completed. - */ - @Test(groups = { "stub", "events", "integration" }) - @SpecAssertion(section = "10.5.1", id = "c") - public void testOtherTransactionalObserverMethodContexts() - { - assert false; - } - @Test(groups = { "events", "integration" }) @SpecAssertion(section = "10.5", id = "bd") public void testObserverCanSetRollbackOnlyOnTransaction() Modified: tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/interceptors/definition/InterceptorDefinitionTest.java =================================================================== --- tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/interceptors/definition/InterceptorDefinitionTest.java 2009-07-23 13:14:00 UTC (rev 3152) +++ tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/interceptors/definition/InterceptorDefinitionTest.java 2009-07-23 13:28:41 UTC (rev 3153) @@ -56,49 +56,4 @@ } assert interfaceFound; } - - @Test(groups = "stub") - @SpecAssertions({ - @SpecAssertion(section = "11.1.2", id = "b") - }) - public void testGetInterceptorBindingTypes() - { - assert false; - } - - @Test(groups = "stub") - @SpecAssertions({ - @SpecAssertion(section = "11.1.2", id = "c") - }) - public void testInterceptsOnInterceptorBean() - { - assert false; - } - - @Test(groups = "stub") - @SpecAssertions({ - @SpecAssertion(section = "11.1.2", id = "d") - }) - public void testInterceptInvokesInstance() - { - assert false; - } - - @Test(groups = "stub") - @SpecAssertions({ - @SpecAssertion(section = "11.1.2", id = "e") - }) - public void testInterceptionTypeIdentifiesCallbackOrMethod() - { - assert false; - } - - @Test(groups = "stub") - @SpecAssertions({ - @SpecAssertion(section = "11.1.2", id = "f") - }) - public void testInstanceOfInterceptorForEveryEnabledInterceptor() - { - assert false; - } } Modified: tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/lookup/el/ResolutionByNameTest.java =================================================================== --- tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/lookup/el/ResolutionByNameTest.java 2009-07-23 13:14:00 UTC (rev 3152) +++ tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/lookup/el/ResolutionByNameTest.java 2009-07-23 13:28:41 UTC (rev 3153) @@ -20,18 +20,6 @@ public class ResolutionByNameTest extends AbstractJSR299Test { - @Test(groups={"stub", "el"}) @SpecAssertion(section="5.8", id = "aba") - public void testELResolverRegisteredWithJsf() - { - assert false; - } - - @Test(groups={"stub", "el"}) @SpecAssertion(section="5.8", id = "aaa") - public void testELResolverRegisteredWithServlet() - { - assert false; - } - @Test(groups = "ri-broken") @SpecAssertion(section="5.8", id="c") public void testQualifiedNameLookup()