[JBoss JIRA] (ARQ-1992) ServletTestRunner is leaking memmory
by Aslak Knutsen (JIRA)
[ https://issues.jboss.org/browse/ARQ-1992?page=com.atlassian.jira.plugin.s... ]
Aslak Knutsen commented on ARQ-1992:
------------------------------------
Aa, nice catch. I guess a local reference would do just as well.
> ServletTestRunner is leaking memmory
> ------------------------------------
>
> Key: ARQ-1992
> URL: https://issues.jboss.org/browse/ARQ-1992
> Project: Arquillian
> Issue Type: Bug
> Components: Base Implementation
> Affects Versions: 1.1.9.Final
> Environment: Using arquillian with servlet protocol
> Reporter: Tomaz Cerar
> Priority: Critical
>
> ServletTestRunner saves ThreadLocal reference to ServletContex in its init() method,
> and clears it in destroy().
> Problem is that thread that calls init and thread that call destroy() are not guaranteed to be the same thread.
> In wildfly/undertow undeploy/server shotdown is executed in different thread than he one that was used to call servlet init first.
> reproducer and some evaluation on the bug can be found at https://github.com/wildfly/wildfly/issues/8263
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 11 months
[JBoss JIRA] (ARQGRA-326) Support for full initialization of outer class instance of a page fragment declared as inner class
by Lukáš Fryč (JIRA)
[ https://issues.jboss.org/browse/ARQGRA-326?page=com.atlassian.jira.plugin... ]
Lukáš Fryč updated ARQGRA-326:
------------------------------
Fix Version/s: 2.1-Tracking
(was: 2.0-Tracking)
> Support for full initialization of outer class instance of a page fragment declared as inner class
> --------------------------------------------------------------------------------------------------
>
> Key: ARQGRA-326
> URL: https://issues.jboss.org/browse/ARQGRA-326
> Project: Arquillian Graphene
> Issue Type: Feature Request
> Components: core
> Affects Versions: 2.0.0.Alpha4
> Reporter: Juraj Húska
> Priority: Minor
> Fix For: 2.1-Tracking
>
>
> If a Page Fragment is declared as inner class, then it can not access the fields of its outer class, as their are not inicialized by Graphene Enrichers, thus are {{null}}.
> The possible ugly workaround for such initialization can be:
> {code}
> if (pageFragment.getClass().getEnclosingClass() != null) {
> Field field = pageFragment.getClass().getDeclaredField("this$0");
> field.setAccessible(true);
> Object outer = field.get(pageFragment);
> enrichRecursively(root, outer);
> }
> {code}
> It should be placed in some utility class, so it can be easily unit tested.
> There is one drawback of this method and that is, the outer class can not contain injection point for the inner class, otherwise it will cycle. The inner class can be obtained only dynamically via {{Graphene.createPageFragment}}.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 11 months
[JBoss JIRA] (ARQGRA-472) TestCases are copy-pasted
by Lukáš Fryč (JIRA)
[ https://issues.jboss.org/browse/ARQGRA-472?page=com.atlassian.jira.plugin... ]
Lukáš Fryč updated ARQGRA-472:
------------------------------
Fix Version/s: 2.1-Tracking
> TestCases are copy-pasted
> -------------------------
>
> Key: ARQGRA-472
> URL: https://issues.jboss.org/browse/ARQGRA-472
> Project: Arquillian Graphene
> Issue Type: Bug
> Components: unit-test
> Affects Versions: 2.1-Tracking
> Reporter: Vitalii Grygoryuk
> Fix For: 2.1-Tracking
>
>
> TestHandlingOfStaleElements.testDeletion() and TestHandlingOfStaleElements.testReplacement() are both testing deletion, so there is no test case for node replacement logic:
> {code}
> @Test
> public void testDeletion() {
> rootElement.isDisplayed();
> executor.executeScript("return arguments[0].parentNode.removeChild(arguments[0])", rootElement);
> try {
> rootElement.isDisplayed();
> fail("rootElement should not be found");
> } catch (NoSuchElementException e) {
> }
> }
> @Test
> public void testReplacement() {
> rootElement.isDisplayed();
> executor.executeScript("return arguments[0].parentNode.removeChild(arguments[0])", rootElement);
> try {
> rootElement.isDisplayed();
> fail("rootElement should not be found");
> } catch (NoSuchElementException e) {
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 11 months
[JBoss JIRA] (ARQGRA-476) Extend root element from GrapheneElement
by Lukáš Fryč (JIRA)
[ https://issues.jboss.org/browse/ARQGRA-476?page=com.atlassian.jira.plugin... ]
Lukáš Fryč updated ARQGRA-476:
------------------------------
Status: Resolved (was: Pull Request Sent)
Resolution: Done
> Extend root element from GrapheneElement
> -----------------------------------------
>
> Key: ARQGRA-476
> URL: https://issues.jboss.org/browse/ARQGRA-476
> Project: Arquillian Graphene
> Issue Type: Enhancement
> Components: core
> Affects Versions: 2.0.3.Final, 2.1.0.Alpha2
> Reporter: Michael Kotten
> Assignee: Michael Kotten
> Priority: Minor
> Fix For: 2.1-Tracking
>
>
> Currently the root element in page fragments must extend WebElement. I would like to extend this, so it can also extend GrapheneElement. I'm preparing a pull request for this currently. Would be nice if this enhancement would make it to the next release.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 11 months