March 2018 - arquillian-issues - Jboss List Archives

[JBoss JIRA] (ARQ-2180) Copy across undeploy's deleteIfExists+deleteOnExit to !isDeployTypeXml (Dropins deployment)

by Gordon Hutchison (JIRA)

Gordon Hutchison created ARQ-2180: ------------------------------------- Summary: Copy across undeploy's deleteIfExists+deleteOnExit to !isDeployTypeXml (Dropins deployment) Key: ARQ-2180 URL: https://issues.jboss.org/browse/ARQ-2180 Project: Arquillian Issue Type: Bug Components: WebSphere Containers Affects Versions: 1.4.0.Final Environment: Websphere Liberty FAT test buckets such as https://github.com/OpenLiberty/open-liberty/tree/integration/dev/com.ibm.... Reporter: Gordon Hutchison Assignee: Gerhard Poul Priority: Minor We sometimes see a timing issue with undeploy which looks like it has already been addressed if isDeployTypeXml==true but most of our tests use the dropin deploy method. I mirrored the code over with: public void undeploy(final Archive<?> archive) throws DeploymentException { if (log.isLoggable(Level.FINER)) { log.entering(className, "undeploy"); } String archiveName = archive.getName(); String deployName = createDeploymentName(archiveName); String deployDir = null; // IBM expedient patch for FAT test problems this was just done to prevent it // having to be added to each arquillian.xml it would not be part of the PR containerConfiguration.setFailSafeUndeployment(true); try { // If deploy type is xml, then remove the application from the xml file, which // causes undeploy if (containerConfiguration.isDeployTypeXML()) { // Read the server.xml file into Memory Document document = readServerXML(); // Remove the archive from the server.xml file removeApplication(document, deployName); removeActivationSpecJmsQueueJmsTopic(document); // Update server.xml on file system writeServerXML(document); // Wait until the application is undeployed waitForApplicationTargetState(deployName, false, this.containerConfiguration.getAppUndeployTimeout()); } // Now we can proceed and delete the archive for either deploy type if (containerConfiguration.isDeployTypeXML()) { deployDir = getAppDirectory(); } else { deployDir = getDropInDirectory(); } // Remove the deployed archive File exportedArchiveLocation = new File(deployDir, archiveName); if (!containerConfiguration.isFailSafeUndeployment()) { try { if (!Files.deleteIfExists(exportedArchiveLocation.toPath())) { throw new DeploymentException("Archive already deleted from deployment directory"); } } catch (IOException e) { throw new DeploymentException("Unable to delete archive from deployment directory", e); } } else { try { Files.deleteIfExists(exportedArchiveLocation.toPath()); } catch (IOException e) { log.log(Level.WARNING, "Unable to delete archive from deployment directory -> failsafe -> file marked for delete on exit", e); exportedArchiveLocation.deleteOnExit(); } } // If it was the archive deletion that caused the undeploy we wait for the // correct state if (!containerConfiguration.isDeployTypeXML()) { // Wait until the application is undeployed waitForApplicationTargetState(deployName, false, this.containerConfiguration.getAppUndeployTimeout()); } } catch (Exception e) { throw new DeploymentException("Exception while undeploying application.", e); } if (log.isLoggable(Level.FINER)) { log.exiting(className, "undeploy"); } } I will now do a PR with the above (minus the containerConfiguration.setFailSafeUndeployment(true); line.) -- This message was sent by Atlassian JIRA (v7.5.0#75005)

6 years, 6 months

1
0
0 / 0

[JBoss JIRA] (ARQ-2153) Enable @Deployment @ShouldThrowException(DefinitionException.class) in WebSphere Liberty Managed Container

by Gordon Hutchison (JIRA)

[ https://issues.jboss.org/browse/ARQ-2153?page=com.atlassian.jira.plugin.s... ] Gordon Hutchison commented on ARQ-2153: --------------------------------------- The problem was only surfacing for the Deployment tests. I think the expected approach is that the outer exception is a standard Arquillian one (org.jboss.arquillian.container.spi.client.container.DeploymentException) but that this can wrap a 'cause' exception that is the domain specific one (i.e. in my case the javax.enterprise.inject.spi.DefinitionException or javax.enterprise.inject.spi.DeploymentException). I coded up and tested this approach in https://github.com/arquillian/arquillian-container-was/pull/33. The extension of the PR woudl be to take PR33 and a table of all known Liberty causes for Deployment Exceptions and fully populate the set of 'cause' exceptions that could then be used in ShouldThrows. > Enable @Deployment @ShouldThrowException(DefinitionException.class) in WebSphere Liberty Managed Container > ---------------------------------------------------------------------------------------------------------- > > Key: ARQ-2153 > URL: https://issues.jboss.org/browse/ARQ-2153 > Project: Arquillian > Issue Type: Feature Request > Components: WebSphere Containers > Affects Versions: 1.0.0.Final > Environment: MicroProfile FaultTolerance TCK testing with arquillian-wlp-managed-8.5 container. > For example testing > https://github.com/eclipse/microprofile-fault-tolerance/blob/master/tck/s... > with open Liberty or any other Arquillian test testing for DefinitionExceptions that cause > Deployment Exceptions. > Reporter: Gordon Hutchison > Assignee: Gerhard Poul > Priority: Minor > > When running the MicroProfile Fault Tolerance TCK there are numerous tests' > deploy methods that have: > {code:java} > @Deployment > @ShouldThrowException(DefinitionException.class) > public static WebArchive deploy() {... > {code} > The current wlp-managed-8.5 container return these as Deployment > Exceptions to the test client which makes the TCK tests fail even if the server > has raised a definition exception. > I have a code patch from an IBM colleague Nathan Mittlestat (whose permission I have to > make this 'issue' and a pull request from on his behalf ) along the lines of: > {code:java} > private void checkForDefinitionExceptions(String applicationName) > { > String messagesFile = containerConfiguration.getWlpHome() + "/usr/servers/" + containerConfiguration.getServerName() + "/logs/messages.log"; > BufferedReader br = null; > try { > br = new BufferedReader(new InputStreamReader(new FileInputStream(messagesFile))); > String line; > while ((line = br.readLine()) != null) { > if (line.contains("CWWKZ0002E: An exception occurred while starting the application " + applicationName + ".") > && (line.contains("org.jboss.weld.exceptions.DefinitionException") || line.contains("javax.enterprise.inject.spi.DefinitionException"))) { > System.out.println("############DEBUG found CWWKZ0002E for application: " + applicationName); > System.out.println(line); > throw new DefinitionException(line); > } > } > } catch (IOException e) { > System.err.println("Exception while reading messages.log" + e.toString()); > e.printStackTrace(); > // } catch (FileNotFoundException e) { > // System.err.println("Exception while reading messages.log" + e.toString()); > // e.printStackTrace(); > } finally { > try { > if (br != null) > br.close(); > } catch (Exception e) { > System.err.println("Exception while closing bufferedreader " + e.toString()); > e.printStackTrace(); > } > } > } > {code} > This method is called in waitForApplicationTargetState if a wrapping Deployment exception > is observed: > > {code:java} > } catch (Exception e) { > checkForDefinitionExceptions(applicationName); > throw new DeploymentException("Exception while checking application state.", e); > } > {code} > I will do a PR shortly. > -- This message was sent by Atlassian JIRA (v7.5.0#75005)

6 years, 6 months

1
0
0 / 0

[JBoss JIRA] (ARQ-2179) Upgrade to Selenium 3.11.0

by Matous Jobanek (JIRA)

[ https://issues.jboss.org/browse/ARQ-2179?page=com.atlassian.jira.plugin.s... ] Matous Jobanek closed ARQ-2179. ------------------------------- Resolution: Done > Upgrade to Selenium 3.11.0 > -------------------------- > > Key: ARQ-2179 > URL: https://issues.jboss.org/browse/ARQ-2179 > Project: Arquillian > Issue Type: Bug > Components: Extension - Drone > Affects Versions: drone_2.5.0 > Reporter: Matous Jobanek > Assignee: Matous Jobanek > Fix For: drone_2.5.1 > > -- This message was sent by Atlassian JIRA (v7.5.0#75005)

6 years, 6 months

1
0
0 / 0

[JBoss JIRA] (ARQ-2179) Upgrade to Selenium 3.11.0

by Matous Jobanek (JIRA)

[ https://issues.jboss.org/browse/ARQ-2179?page=com.atlassian.jira.plugin.s... ] Matous Jobanek reassigned ARQ-2179: ----------------------------------- Assignee: Matous Jobanek > Upgrade to Selenium 3.11.0 > -------------------------- > > Key: ARQ-2179 > URL: https://issues.jboss.org/browse/ARQ-2179 > Project: Arquillian > Issue Type: Bug > Components: Extension - Drone > Affects Versions: drone_2.5.0 > Reporter: Matous Jobanek > Assignee: Matous Jobanek > Fix For: drone_2.5.1 > > -- This message was sent by Atlassian JIRA (v7.5.0#75005)

6 years, 6 months

1
0
0 / 0

[JBoss JIRA] (ARQ-2179) Upgrade to Selenium 3.11.0

by Matous Jobanek (JIRA)

[ https://issues.jboss.org/browse/ARQ-2179?page=com.atlassian.jira.plugin.s... ] Matous Jobanek updated ARQ-2179: -------------------------------- Fix Version/s: drone_2.5.1 > Upgrade to Selenium 3.11.0 > -------------------------- > > Key: ARQ-2179 > URL: https://issues.jboss.org/browse/ARQ-2179 > Project: Arquillian > Issue Type: Bug > Components: Extension - Drone > Affects Versions: drone_2.5.0 > Reporter: Matous Jobanek > Fix For: drone_2.5.1 > > -- This message was sent by Atlassian JIRA (v7.5.0#75005)

6 years, 6 months

1
0
0 / 0

[JBoss JIRA] (ARQ-2179) Upgrade to Selenium 3.11.0

by Matous Jobanek (JIRA)

[ https://issues.jboss.org/browse/ARQ-2179?page=com.atlassian.jira.plugin.s... ] Matous Jobanek updated ARQ-2179: -------------------------------- Affects Version/s: drone_2.5.0 (was: drone_2.5.1) > Upgrade to Selenium 3.11.0 > -------------------------- > > Key: ARQ-2179 > URL: https://issues.jboss.org/browse/ARQ-2179 > Project: Arquillian > Issue Type: Bug > Components: Extension - Drone > Affects Versions: drone_2.5.0 > Reporter: Matous Jobanek > Fix For: drone_2.5.1 > > -- This message was sent by Atlassian JIRA (v7.5.0#75005)

6 years, 6 months

1
0
0 / 0

[JBoss JIRA] (ARQ-2179) Upgrade to Selenium 3.11.0

by Matous Jobanek (JIRA)

Matous Jobanek created ARQ-2179: ----------------------------------- Summary: Upgrade to Selenium 3.11.0 Key: ARQ-2179 URL: https://issues.jboss.org/browse/ARQ-2179 Project: Arquillian Issue Type: Bug Components: Extension - Drone Affects Versions: drone_2.5.1 Reporter: Matous Jobanek -- This message was sent by Atlassian JIRA (v7.5.0#75005)

6 years, 6 months

1
0
0 / 0

[JBoss JIRA] (ARQ-1321) Support for HTTPS in URLs injected with @ArquillianResource

by Corey Puffalt (JIRA)

[ https://issues.jboss.org/browse/ARQ-1321?page=com.atlassian.jira.plugin.s... ] Corey Puffalt commented on ARQ-1321: ------------------------------------ Is this likely to ever be integrated into Arquillian? > Support for HTTPS in URLs injected with @ArquillianResource > ----------------------------------------------------------- > > Key: ARQ-1321 > URL: https://issues.jboss.org/browse/ARQ-1321 > Project: Arquillian > Issue Type: Feature Request > Reporter: Samuel Santos > Assignee: Samuel Santos > > When injecting an URL like the following: > {code:java} > @ArquillianResource URL url; > {code} > HTTP protocol will always be used. This happens because "http" is hard-coded in {{URLResourceProvider}}. > Vineet Reynolds suggested that we can create the type {{SecureUrl}} and a {{SecureUrlResourceProvider}} to allow us to use HTTPS: > {code:java} > @ArquillianResource SecureUrl url; > {code} > Any comment? -- This message was sent by Atlassian JIRA (v7.5.0#75005)

6 years, 6 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

arquillian-issues March 2018