[arquillian-issues] [JBoss JIRA] (ARQ-322) Implement a GlassFish 3.1 managed container adapter

[ https://issues.jboss.org/browse/ARQ-322?page=com.atlassian.jira.plugin.sy... ] Vineet Reynolds edited comment on ARQ-322 at 2/28/12 3:09 PM: -------------------------------------------------------------- There's a cleaned up version of Dan Allen's prototype here: https://github.com/VineetReynolds/arquillian-container-glassfish/tree/ARQ... I'll comment on the points noted above, with regard to the original prototype, that are still not addressed and might not addressed right away. * add support for JVM flags (use property javaJvmArguments) - GlassFish does not allow for new JVM flags and arguments to be specified for the GlassFish process via an asadmin command. For now, this requires changes to be made to the domain configuration via the asadmin create-jvm-options command (and a rollback via the asadmin delete-jvm-options command), and a possible domain restart; in short, we do not have an elegant solution at the moment. We could raise a feature request in the GlassFish JIRA. * add support for custom debug port (use property debugPort) - Again, GlassFish does not allow for the debug port to be changed at startup through an asadmin commmand. The domain configuration file must be modified for a custom debug port to be used. We could raise this feature request in the GlassFish JIRA. * add support for deploying glassfish-resources.xml - This could be done via the `asadmin add-resources` command. But it would incur a cost at the moment, for the creation of resources cannot be rolled back easily. Aslak has already filed a feature request against GlassFish JIRA (http://java.net/jira/browse/GLASSFISH-16240) for this purpose. I'm of the opinion that we should wait for this feature to appear in GlassFish instead of building in the logic to parse the sun-resources/glassfish-resources.xml files to manage each individual resource. was (Author: vineet.reynolds): There's a cleaned up version of Dan Allen's prototype here: https://github.com/VineetReynolds/arquillian-container-glassfish/tree/ARQ... I'll comment on the points noted above, with regard to the original prototype, that are still not addressed and might not addressed right away. * add support for JVM flags (use property javaJvmArguments) - GlassFish does not allow for new JVM flags and arguments to be specified for the GlassFish process via an asadmin command. This requires changes to be made to the domain configuration via the asadmin create-jvm-options command (and a rollback via the asadmin delete-jvm-options command), and a possible domain restart. We could raise this feature request in the GlassFish JIRA. * add support for custom debug port (use property debugPort) - Again, GlassFish does not allow for the debug port to be changed at startup through an asadmin commmand. The domain configuration file must be modified for a custom debug port to be used. We could raise this feature request in the GlassFish JIRA. * add support for deploying glassfish-resources.xml - This could be done via the `asadmin add-resources` command. But it would incur a cost at the moment, for the creation of resources cannot be rolled back easily. Aslak has already filed a feature request against GlassFish JIRA (http://java.net/jira/browse/GLASSFISH-16240) for this purpose. I'm of the opinion that we should wait for this feature to appear in GlassFish instead of building in the logic to parse the sun-resources/glassfish-resources.xml files to manage each individual resource. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira