[arquillian-issues] [JBoss JIRA] (ARQ-918) Pick a better name for testable attribute on @Deployment annotation

[ https://issues.jboss.org/browse/ARQ-918?page=com.atlassian.jira.plugin.sy... ] Dan Allen edited comment on ARQ-918 at 5/10/12 2:47 AM: -------------------------------------------------------- Several suggestions have come up that indicate to me I need to clarify what behavior we're attempting to control. * testMode = TestMode.CLIENT etc... * runMode = ArquillianRunMode.IN_CONTAINER|CLIENT|CLIENT_ENRICHED * Do the 'supports' and 'testing' bookends reinforce the meaning of 'inContainer' that much? A deployment is "in container" by definition. We aren't trying to control whether or not its deployed to the container. Otherwise, we wouldn't be defining a deployment in the first place. What we are trying to control is whether Arquillian adds its own infrastructure to the deployment (effectively repackaging it). That infrastructure adds extra services to the deployment that become available once the deployment is deployed. Those services are (as of now): * a service to run tests in-container * a service to monitor, analyze or execute callbacks on the server-side code We are not trying to control how the tests are run. That behavior is controlled on the test class or test method using the @RunAsClient annotation. When absent, the default is to run the test "in-container" if the deployment supports in-container testing or "as client" if the deployment does not. (If there are multiple deployments, @OperateOnDeployment tells Arquillian which deployment to use for that test). I'll summarize the three ways a deployment is packaged and the behavior it provides: * Add the test infrastructure to the deployment - capable of running tests in-container (white box testing) * Add instrumentation to the deployment - supports client testing w/ knowledge of internal state (gray box testing) * Use the deployment exactly as it's defined - supports purely client testing (black box testing) With that in mind, I have another proposal for how to control the packaging of these services: {code} @Deployment(testingServices = ALL | INSTRUMENTATION_ONLY | NONE) {code} or as a separate annotation {code} @Deployment @TestingServices(NONE) {code} ALL could be IN_CONTAINER instead. was (Author: dan.j.allen): Several suggestions came up that indicate to me I need to clarify what behavior we're attempting to control. * testMode = TestMode.CLIENT etc... * runMode = ArquillianRunMode.IN_CONTAINER|CLIENT|CLIENT_ENRICHED * Do the 'supports' and 'testing' bookends reinforce the meaning of 'inContainer' that much? A deployment is "in container" by definition. We aren't trying to control whether or not its deployed to the container. Otherwise, we wouldn't be defining a deployment in the first place. What we are trying to control is whether Arquillian adds its own infrastructure to the deployment (effectively repackaging it). That infrastructure adds extra services to the deployment that become available once the deployment is deployed. Those services are (as of now): * a service to run tests in-container * a service to monitor, analyze or execute callbacks on the server-side code We are not trying to control how the tests are run. That behavior is controlled on the test class or test method using the @RunAsClient annotation. When absent, the default is to run the test "in-container" if the deployment supports in-container testing or "as client" if the deployment does not. (If there are multiple deployments, @OperateOnDeployment tells Arquillian which deployment to use for that test). I'll summarize the three ways a deployment is packaged and the behavior it provides: * Add the test infrastructure to the deployment - capable of running tests in-container (white box testing) * Add instrumentation to the deployment - supports client testing w/ knowledge of internal state (gray box testing) * Use the deployment exactly as it's defined - supports purely client testing (black box testing) With that in mind, I have another proposal for how to control the packaging of these services: {code} @Deployment(testingServices = ALL | INSTRUMENTATION_ONLY | NONE) {code} or as a separate annotation {code} @Deployment @TestingServices(NONE) {code} ALL could be IN_CONTAINER instead. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira