[arquillian-issues] [JBoss JIRA] Commented: (ARQ-433) Add a Tomcat 7 embedded container

Add a Tomcat 7 embedded container --------------------------------- Key: ARQ-433 URL: https://issues.jboss.org/browse/ARQ-433 Project: Arquillian Issue Type: Feature Request Security Level: Public(Everyone can see) Components: Tomcat Containers Affects Versions: 1.0.0.Alpha5 Reporter: Ian Brandt Tomcat 7 has deprecated the {{[org.apache.catalina.startup.Embedded|http://tomcat.apache.org/tomcat-7.0-doc/api/org/apache/catalina/startup/Embedded.html]}} API as used by the {{arquillian-tomcat-embedded-6}} container implementation. The new API is {{[org.apache.catalina.startup.Tomcat|http://tomcat.apache.org/tomcat-7.0-doc/api/org/apache/catalina/startup/Tomcat.html]}}. That said I have no idea if the [new {{Tomcat}} API is mature or suitable|http://www.coderanch.com/t/513623/Tomcat/Tomcat-embedded-web-app...] for Arquillian at this time. Either way with Tomcat 7 implementing [Servlet 3.0's web fragments|http://java.sun.com/developer/technicalArticles/JavaEE/JavaEE6O...], which coincide nicely with Arquillian/ShrinkWrap by allowing one to package isolated parts of their production webapp configuration for select integration tests, I think it would be great if Arquillian declared Tomcat 7 as a supported container. This could be done by implementing the new API in an {{arquillian-tomcat-embedded-7}} container, forking the deprecated API from {{arquillian-tomcat-embedded-6}} to create the same, or just adding documentation that states the {{arquillian-tomcat-embedded-6}} container can and should be used for Tomcat 7 at this time. Thoughts? I'm going to plow ahead with {{arquillian-tomcat-embedded-6}} for now. If I run into a reason to fork it or create a container around the new API I'll try my hand at a pull request.