9:03 a.m.
Rename @Target, @Expected, @Run and @DeploymentTarget annotations
-----------------------------------------------------------------
Key: ARQ-389
URL: https://issues.jboss.org/browse/ARQ-389
Project: Arquillian
Issue Type: Feature Request
Components: Base Implementation
Affects Versions: 1.0.0.Alpha4
Reporter: Aslak Knutsen
Assignee: Aslak Knutsen
Fix For: 1.0.0.Alpha5
For better consistent naming, we should rename the API annotations:
* @Run(RunModeType) = @RunAsClient
** InContainer is extracted from @Deployment(testable) and only possible to override with
AS_CLIENT
* @Expected = @ShouldThrowException
* @Target = @TargetsContainer("x")
** Clearify meaning
* @DeploymentTarget = @OperateOnDeployment
** Clearify that this test will operate within the context of the @Deployment
{code}
public class TestClass
{
@Deployment(name = "dep", testable=false)
@ShouldThrowException(Exception.class) @TargetsContainer("x")
public JavaArchive create() {}
container x{
deployment dep{
@Test @RunAsClient @OperateOnDeployment("dep")
public void shouldBe() {}
container x{
@Test @OperateOnContainer("x")
public void shouldBe() {}
}
{code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:27 a.m.
New subject: [JBoss JIRA] Commented: (ARQ-389) Rename @Target, @Expected, @Run and @DeploymentTarget annotations
[
https://issues.jboss.org/browse/ARQ-389?page=com.atlassian.jira.plugin.sy...
]
Andrew Rubinger commented on ARQ-389:
-------------------------------------
Reviewed, discussed in IRC w/ Aslak, and +1 from me.
Rename @Target, @Expected, @Run and @DeploymentTarget annotations
-----------------------------------------------------------------
Key: ARQ-389
URL: https://issues.jboss.org/browse/ARQ-389
Project: Arquillian
Issue Type: Feature Request
Components: Base Implementation
Affects Versions: 1.0.0.Alpha4
Reporter: Aslak Knutsen
Assignee: Aslak Knutsen
Fix For: 1.0.0.Alpha5
For better consistent naming, we should rename the API annotations:
* @Run(RunModeType) = @RunAsClient
** InContainer is extracted from @Deployment(testable) and only possible to override with
AS_CLIENT
* @Expected = @ShouldThrowException
* @Target = @TargetsContainer("x")
** Clearify meaning
* @DeploymentTarget = @OperateOnDeployment
** Clearify that this test will operate within the context of the @Deployment
{code}
public class TestClass
{
@Deployment(name = "dep", testable=false)
@ShouldThrowException(Exception.class) @TargetsContainer("x")
public JavaArchive create() {}
container x{
deployment dep{
@Test @RunAsClient @OperateOnDeployment("dep")
public void shouldBe() {}
container x{
@Test @OperateOnContainer("x")
public void shouldBe() {}
}
{code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:49 a.m.
New subject: [JBoss JIRA] Commented: (ARQ-389) Rename @Target, @Expected, @Run and @DeploymentTarget annotations
[
https://issues.jboss.org/browse/ARQ-389?page=com.atlassian.jira.plugin.sy...
]
Aslak Knutsen commented on ARQ-389:
-----------------------------------
Other points:
* @Deployment.startup = @Deployment.managed | @Deployment.manual
** If Arquillian should handle deploy and undeploy
@Deployment.testable = ?
** If the deployment should be enriched for in-container testing
Rename @Target, @Expected, @Run and @DeploymentTarget annotations
-----------------------------------------------------------------
Key: ARQ-389
URL: https://issues.jboss.org/browse/ARQ-389
Project: Arquillian
Issue Type: Feature Request
Components: Base Implementation
Affects Versions: 1.0.0.Alpha4
Reporter: Aslak Knutsen
Assignee: Aslak Knutsen
Fix For: 1.0.0.Alpha5
For better consistent naming, we should rename the API annotations:
* @Run(RunModeType) = @RunAsClient
** InContainer is extracted from @Deployment(testable) and only possible to override with
AS_CLIENT
* @Expected = @ShouldThrowException
* @Target = @TargetsContainer("x")
** Clearify meaning
* @DeploymentTarget = @OperateOnDeployment
** Clearify that this test will operate within the context of the @Deployment
{code}
public class TestClass
{
@Deployment(name = "dep", testable=false)
@ShouldThrowException(Exception.class) @TargetsContainer("x")
public JavaArchive create() {}
container x{
deployment dep{
@Test @RunAsClient @OperateOnDeployment("dep")
public void shouldBe() {}
container x{
@Test @OperateOnContainer("x")
public void shouldBe() {}
}
{code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:49 a.m.
New subject: [JBoss JIRA] Issue Comment Edited: (ARQ-389) Rename @Target, @Expected, @Run and @DeploymentTarget annotations
[
https://issues.jboss.org/browse/ARQ-389?page=com.atlassian.jira.plugin.sy...
]
Aslak Knutsen edited comment on ARQ-389 at 3/14/11 12:49 PM:
-------------------------------------------------------------
Other points:
* @Deployment.startup = @Deployment.managed | @Deployment.manual
** If Arquillian should handle deploy and undeploy
* @Deployment.testable = ?
** If the deployment should be enriched for in-container testing
was (Author: aslak):
Other points:
* @Deployment.startup = @Deployment.managed | @Deployment.manual
** If Arquillian should handle deploy and undeploy
@Deployment.testable = ?
** If the deployment should be enriched for in-container testing
Rename @Target, @Expected, @Run and @DeploymentTarget annotations
-----------------------------------------------------------------
Key: ARQ-389
URL: https://issues.jboss.org/browse/ARQ-389
Project: Arquillian
Issue Type: Feature Request
Components: Base Implementation
Affects Versions: 1.0.0.Alpha4
Reporter: Aslak Knutsen
Assignee: Aslak Knutsen
Fix For: 1.0.0.Alpha5
For better consistent naming, we should rename the API annotations:
* @Run(RunModeType) = @RunAsClient
** InContainer is extracted from @Deployment(testable) and only possible to override with
AS_CLIENT
* @Expected = @ShouldThrowException
* @Target = @TargetsContainer("x")
** Clearify meaning
* @DeploymentTarget = @OperateOnDeployment
** Clearify that this test will operate within the context of the @Deployment
{code}
public class TestClass
{
@Deployment(name = "dep", testable=false)
@ShouldThrowException(Exception.class) @TargetsContainer("x")
public JavaArchive create() {}
container x{
deployment dep{
@Test @RunAsClient @OperateOnDeployment("dep")
public void shouldBe() {}
container x{
@Test @OperateOnContainer("x")
public void shouldBe() {}
}
{code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:26 a.m.
New subject: [JBoss JIRA] Commented: (ARQ-389) Rename @Target, @Expected, @Run and @DeploymentTarget annotations
[
https://issues.jboss.org/browse/ARQ-389?page=com.atlassian.jira.plugin.sy...
]
Aslak Knutsen commented on ARQ-389:
-----------------------------------
@Deployment.startup renamed managed, to avoid changing boolean logic.
@Protocol renamed @OverProtocol
{code}
@Deployment @TargetsContainer("active-1") @OverProtocol("Servlet
3.0")
public void WebArchive myComponent()
{
return ShrinkWrap.create(WebArchive.class);
}
{code}
Rename @Target, @Expected, @Run and @DeploymentTarget annotations
-----------------------------------------------------------------
Key: ARQ-389
URL: https://issues.jboss.org/browse/ARQ-389
Project: Arquillian
Issue Type: Feature Request
Components: Base Implementation
Affects Versions: 1.0.0.Alpha4
Reporter: Aslak Knutsen
Assignee: Aslak Knutsen
Fix For: 1.0.0.Alpha5
For better consistent naming, we should rename the API annotations:
* @Run(RunModeType) = @RunAsClient
** InContainer is extracted from @Deployment(testable) and only possible to override with
AS_CLIENT
* @Expected = @ShouldThrowException
* @Target = @TargetsContainer("x")
** Clearify meaning
* @DeploymentTarget = @OperateOnDeployment
** Clearify that this test will operate within the context of the @Deployment
{code}
public class TestClass
{
@Deployment(name = "dep", testable=false)
@ShouldThrowException(Exception.class) @TargetsContainer("x")
public JavaArchive create() {}
container x{
deployment dep{
@Test @RunAsClient @OperateOnDeployment("dep")
public void shouldBe() {}
container x{
@Test @OperateOnContainer("x")
public void shouldBe() {}
}
{code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:32 a.m.
New subject: [JBoss JIRA] Issue Comment Edited: (ARQ-389) Rename @Target, @Expected, @Run and @DeploymentTarget annotations
[
https://issues.jboss.org/browse/ARQ-389?page=com.atlassian.jira.plugin.sy...
]
Aslak Knutsen edited comment on ARQ-389 at 3/17/11 8:31 AM:
------------------------------------------------------------
@Deployment.startup renamed managed, to avoid changing boolean logic.
@Protocol renamed @OverProtocol
{code}
@Deployment @TargetsContainer("active-1")
@ShouldThrowException(Exception.class)
public void WebArchive myFailingComponent()
{
return ShrinkWrap.create(WebArchive.class);
}
@Deployment(name = "app1") @TargetsContainer("active-1")
@OverProtocol("Servlet 3.0")
public void WebArchive myComponent()
{
return ShrinkWrap.create(WebArchive.class);
}
@Test @OperateOnDeployment("app1")
public void shouldDoX(MyComponent x)
{
// assert x
}
@Test @OperateOnDeployment("app1") @RunAsClient
public void shouldDoX(MyComponent x)
{
// assert x
}
{code}
was (Author: aslak):
@Deployment.startup renamed managed, to avoid changing boolean logic.
@Protocol renamed @OverProtocol
{code}
@Deployment @TargetsContainer("active-1") @OverProtocol("Servlet
3.0")
public void WebArchive myComponent()
{
return ShrinkWrap.create(WebArchive.class);
}
{code}
Rename @Target, @Expected, @Run and @DeploymentTarget annotations
-----------------------------------------------------------------
Key: ARQ-389
URL: https://issues.jboss.org/browse/ARQ-389
Project: Arquillian
Issue Type: Feature Request
Components: Base Implementation
Affects Versions: 1.0.0.Alpha4
Reporter: Aslak Knutsen
Assignee: Aslak Knutsen
Fix For: 1.0.0.Alpha5
For better consistent naming, we should rename the API annotations:
* @Run(RunModeType) = @RunAsClient
** InContainer is extracted from @Deployment(testable) and only possible to override with
AS_CLIENT
* @Expected = @ShouldThrowException
* @Target = @TargetsContainer("x")
** Clearify meaning
* @DeploymentTarget = @OperateOnDeployment
** Clearify that this test will operate within the context of the @Deployment
{code}
public class TestClass
{
@Deployment(name = "dep", testable=false)
@ShouldThrowException(Exception.class) @TargetsContainer("x")
public JavaArchive create() {}
container x{
deployment dep{
@Test @RunAsClient @OperateOnDeployment("dep")
public void shouldBe() {}
container x{
@Test @OperateOnContainer("x")
public void shouldBe() {}
}
{code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:48 a.m.
New subject: [JBoss JIRA] Resolved: (ARQ-389) Rename @Target, @Expected, @Run and @DeploymentTarget annotations
[
https://issues.jboss.org/browse/ARQ-389?page=com.atlassian.jira.plugin.sy...
]
Aslak Knutsen resolved ARQ-389.
-------------------------------
Resolution: Done
pushed upstream master
Rename @Target, @Expected, @Run and @DeploymentTarget annotations
-----------------------------------------------------------------
Key: ARQ-389
URL: https://issues.jboss.org/browse/ARQ-389
Project: Arquillian
Issue Type: Feature Request
Components: Base Implementation
Affects Versions: 1.0.0.Alpha4
Reporter: Aslak Knutsen
Assignee: Aslak Knutsen
Fix For: 1.0.0.Alpha5
For better consistent naming, we should rename the API annotations:
* @Run(RunModeType) = @RunAsClient
** InContainer is extracted from @Deployment(testable) and only possible to override with
AS_CLIENT
* @Expected = @ShouldThrowException
* @Target = @TargetsContainer("x")
** Clearify meaning
* @DeploymentTarget = @OperateOnDeployment
** Clearify that this test will operate within the context of the @Deployment
{code}
public class TestClass
{
@Deployment(name = "dep", testable=false)
@ShouldThrowException(Exception.class) @TargetsContainer("x")
public JavaArchive create() {}
container x{
deployment dep{
@Test @RunAsClient @OperateOnDeployment("dep")
public void shouldBe() {}
container x{
@Test @OperateOnContainer("x")
public void shouldBe() {}
}
{code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:46 a.m.
New subject: [JBoss JIRA] Closed: (ARQ-389) Rename @Target, @Expected, @Run and @DeploymentTarget annotations
[
https://issues.jboss.org/browse/ARQ-389?page=com.atlassian.jira.plugin.sy...
]
Aslak Knutsen closed ARQ-389.
-----------------------------
Rename @Target, @Expected, @Run and @DeploymentTarget annotations
-----------------------------------------------------------------
Key: ARQ-389
URL: https://issues.jboss.org/browse/ARQ-389
Project: Arquillian
Issue Type: Feature Request
Components: Base Implementation
Affects Versions: 1.0.0.Alpha4
Reporter: Aslak Knutsen
Assignee: Aslak Knutsen
Fix For: 1.0.0.Alpha5
For better consistent naming, we should rename the API annotations:
* @Run(RunModeType) = @RunAsClient
** InContainer is extracted from @Deployment(testable) and only possible to override with
AS_CLIENT
* @Expected = @ShouldThrowException
* @Target = @TargetsContainer("x")
** Clearify meaning
* @DeploymentTarget = @OperateOnDeployment
** Clearify that this test will operate within the context of the @Deployment
{code}
public class TestClass
{
@Deployment(name = "dep", testable=false)
@ShouldThrowException(Exception.class) @TargetsContainer("x")
public JavaArchive create() {}
container x{
deployment dep{
@Test @RunAsClient @OperateOnDeployment("dep")
public void shouldBe() {}
container x{
@Test @OperateOnContainer("x")
public void shouldBe() {}
}
{code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
5507
days inactive
5511
days old
arquillian-issues@lists.jboss.org
7 comments
2 participants
participants (2)
-
Andrew Rubinger (JIRA) -
Aslak Knutsen (JIRA)