[ https://issues.jboss.org/browse/ARQ-433?page=com.atlassian.jira.plugin.sy... ] Ian Brandt commented on ARQ-433: -------------------------------- The new {{org.apache.catalina.startup.Tomcat}} API is not available in Tomcat 6.x, so no making it work for both. It was a short ride with Tomcat 7.0.12 and Arquillian 1.0.0-Alpha5: {noformat} java.lang.NoSuchMethodError: org.apache.catalina.connector.Connector.setContainer(Lorg/apache/catalina/Container;)V at org.jboss.arquillian.container.tomcat.embedded_6.TomcatContainer.startTomcatEmbedded(TomcatContainer.java:323) {noformat} As far as I can tell the [{{connector.setContainer(engine)}} call at line 323|https://github.com/arquillian/arquillian-container-tomcat/blob/master...] is unnecessary for both Tomcat 6 & 7, and was in fact removed in 7, as the ["...added Connector will use the most recently added Engine to process its received requests|http://tomcat.apache.org/tomcat-6.0-doc/api/org/apache/catalina/...]. Thanks for the repo tip, as the [build instructions|http://www.jboss.org/arquillian/build.html] seem a little out of date in that regard. I've got {{arquillian-core}} and {{arquillian-container-tomcat}} locally, but am getting a test error on the latter that I need to debug: {noformat} ------------------------------------------------------------------------------- Test set: org.jboss.arquillian.container.tomcat.embedded_6.TomcatEmbeddedInContainerTestCase ------------------------------------------------------------------------------- Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 15.926 sec <<< FAILURE! shouldBeAbleToInjectMembersIntoTestClass(org.jboss.arquillian.container.tomcat.embedded_6.TomcatEmbeddedInContainerTestC ase) Time elapsed: 0.026 sec <<< FAILURE! java.lang.AssertionError: expected:<Tomcat> but was:<null> at org.junit.Assert.fail(Assert.java:91) at org.junit.Assert.failNotEquals(Assert.java:645) at org.junit.Assert.assertEquals(Assert.java:126) at org.junit.Assert.assertEquals(Assert.java:145) at org.jboss.arquillian.container.tomcat.embedded_6.TomcatEmbeddedInContainerTestCase.shouldBeAbleToInjectMember sIntoTestClass(TomcatEmbeddedInContainerTestCase.java:94) {noformat} -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/ARQ-433?page=com.atlassian.jira.plugin.sy... ] Ian Brandt commented on ARQ-433: -------------------------------- The tests pass from the old https://github.com/arquillian/arquillian.git repo. A notable difference is in the old repo the Servlet 2.5 protocol is being used, whereas in the new repo it's the Local protocol. The {{org.jboss.arquillian.protocol.servlet.v_2_5.ServletProtocolDeploymentPackager}} adds auxiliary archives such as {{arquillian-tomcat-testenrichers.jar}} [to the web application archive|http://community.jboss.org/message/551100]: {noformat} . ./META-INF ./META-INF/context.xml ./WEB-INF ./WEB-INF/beans.xml ./WEB-INF/classes ./WEB-INF/classes/org ./WEB-INF/classes/org/jboss ./WEB-INF/classes/org/jboss/arquillian ./WEB-INF/classes/org/jboss/arquillian/container ./WEB-INF/classes/org/jboss/arquillian/container/tomcat ./WEB-INF/classes/org/jboss/arquillian/container/tomcat/embedded_6 ./WEB-INF/classes/org/jboss/arquillian/container/tomcat/embedded_6/TestBean.class ./WEB-INF/classes/org/jboss/arquillian/container/tomcat/embedded_6/TestServlet.class ./WEB-INF/classes/org/jboss/arquillian/container/tomcat/embedded_6/TomcatEmbeddedInContainerTestCase.class ./WEB-INF/classes/org/jboss/arquillian/protocol ./WEB-INF/classes/org/jboss/arquillian/protocol/servlet ./WEB-INF/classes/org/jboss/arquillian/protocol/servlet/runner ./WEB-INF/classes/org/jboss/arquillian/protocol/servlet/runner/SecurityActions$1.class ./WEB-INF/classes/org/jboss/arquillian/protocol/servlet/runner/SecurityActions$GetTcclAction.class ./WEB-INF/classes/org/jboss/arquillian/protocol/servlet/runner/SecurityActions.class ./WEB-INF/classes/org/jboss/arquillian/protocol/servlet/runner/ServletTestRunner.class ./WEB-INF/lib ./WEB-INF/lib/arquillian-core.jar ./WEB-INF/lib/arquillian-junit.jar ./WEB-INF/lib/arquillian-tomcat-testenrichers.jar ./WEB-INF/lib/weld-servlet-1.0.1-Final.jar ./WEB-INF/web.xml {noformat} The {{org.jboss.arquillian.container.test.impl.client.protocol.local.LocalDeploymentPackager}} does not: {noformat} ./META-INF ./META-INF/context.xml ./WEB-INF ./WEB-INF/beans.xml ./WEB-INF/classes ./WEB-INF/classes/org ./WEB-INF/classes/org/jboss ./WEB-INF/classes/org/jboss/arquillian ./WEB-INF/classes/org/jboss/arquillian/container ./WEB-INF/classes/org/jboss/arquillian/container/tomcat ./WEB-INF/classes/org/jboss/arquillian/container/tomcat/embedded_6 ./WEB-INF/classes/org/jboss/arquillian/container/tomcat/embedded_6/TestBean.class ./WEB-INF/classes/org/jboss/arquillian/container/tomcat/embedded_6/TestServlet.class ./WEB-INF/classes/org/jboss/arquillian/container/tomcat/embedded_6/TomcatEmbeddedInContainerTestCase.class ./WEB-INF/lib ./WEB-INF/lib/weld-servlet-1.0.1-Final.jar ./WEB-INF/web.xml {noformat} Was the change to the Local protocol intentional, and if so any tips on how test enrichment should work with it? Also are there any immediate plans to switch Hudson to the new repo? -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/ARQ-433?page=com.atlassian.jira.plugin.sy... ] SBS JIRA Integration updated ARQ-433: ------------------------------------- JBoss Forum Reference: http://community.jboss.org/message/605028#605028 -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/ARQ-433?page=com.atlassian.jira.plugin.sy... ] Aslak Knutsen updated ARQ-433: ------------------------------ Fix Version/s: tomcat_1.0.0.Final Forum Reference: http://community.jboss.org/message/605028#605028 (was: http://community.jboss.org/message/605028#605028) Can we make this for 1.0.0.Final? this/next week? :) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/ARQ-433?page=com.atlassian.jira.plugin.sy... ] Aslak Knutsen resolved ARQ-433. ------------------------------- Resolution: Done pushed upstream -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/ARQ-433?page=com.atlassian.jira.plugin.sy... ] Aslak Knutsen closed ARQ-433. ----------------------------- -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira