[ https://issues.jboss.org/browse/ARQAJO-105?page=com.atlassian.jira.plugin... ] Lukáš Fryč updated ARQAJO-105: ------------------------------ Priority: Critical (was: Major) Fix Version/s: 2.0.0.Alpha1 (was: 2.0-Tracking) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/ARQGRA-67?page=com.atlassian.jira.plugin.... ] Lukáš Fryč commented on ARQGRA-67: ---------------------------------- I have commited some stubs (JavaScript calling interface) already. https://github.com/arquillian/arquillian-graphene/blob/master/graphene-we... -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/ARQGRA-67?page=com.atlassian.jira.plugin.... ] Lukáš Fryč commented on ARQGRA-67: ---------------------------------- This depends on several separated steps currently: * Page Extensions (ARQGRA-71) * guardXhr.js implementation (which would depend on already implemented xhrInterception.js (ARQGRA-41) * guardXhr utility methods -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/ARQGRA-67?page=com.atlassian.jira.plugin.... ] Lukáš Fryč updated ARQGRA-67: ----------------------------- Sprint: Sprint 1 - Critical Issues -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/ARQGRA-67?page=com.atlassian.jira.plugin.... ] Jan Papousek commented on ARQGRA-67: ------------------------------------ So, I've tried to implement the request guards and there are updates needed: # proposed xhrInterception.js has to be updated to save Graphene object and its state to global variable (I've chosen Document.Graphene) [[1|https://github.com/papousek/arquillian-graphene/blob/ARQGRA-71/graphene-webdriver/graphene-webdriver-impl/src/main/javascript/Graphene.xhrInterception.js]] # DefaultExecutionResolver should be replaced by resolver using page extensions (resolver only delegates installation to page extension process) [[2|https://github.com/papousek/arquillian-graphene/blob/ARQGRA-71/graphene-webdriver/graphene-webdriver-impl/src/main/java/org/jboss/arquillian/graphene/page/extension/PageExtensionJavaScriptExecutionResolver.java]] # GrapheneProxy should be refactored to provide public interface (not only package friendly) and support interceptors [[3|https://github.com/papousek/arquillian-graphene/blob/ARQGRA-71/graphene-webdriver/graphene-webdriver-impl/src/main/java/org/jboss/arquillian/graphene/context/GrapheneProxyHandler.java]][[4|https://github.com/papousek/arquillian-graphene/blob/ARQGRA-71/graphene-webdriver/graphene-webdriver-impl/src/main/java/org/jboss/arquillian/graphene/context/GrapheneProxyInstance.java]][[5|https://github.com/papousek/arquillian-graphene/blob/ARQGRA-71/graphene-webdriver/graphene-webdriver-impl/src/main/java/org/jboss/arquillian/graphene/context/Interceptor.java]][[6|https://github.com/papousek/arquillian-graphene/blob/ARQGRA-71/graphene-webdriver/graphene-webdriver-impl/src/main/java/org/jboss/arquillian/graphene/context/InvocationContext.java]], it should be also considered to put classes managing proxies to separate package -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/ARQGRA-67?page=com.atlassian.jira.plugin.... ] Lukáš Fryč edited comment on ARQGRA-67 at 8/22/12 9:15 AM: ----------------------------------------------------------- (1) As commented on pull request - could you change that to {{window.Graphene}}? (2) could we just extend DefaultExecutionResolver instead of replacing? (3) why it should be exposed publicly? I don't have strong objections, just GrapheneProxy was intented to be used by internal implementation. How does interception matches with ARQGRA-79? was (Author: lfryc): (2) could we just extend DefaultExecutionResolver instead of replacing? (3) why it should be exposed publicly? I don't have strong objections, just GrapheneProxy was intented to be used by internal implementation. How does interception matches with ARQGRA-79? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/ARQGRA-67?page=com.atlassian.jira.plugin.... ] Lukáš Fryč updated ARQGRA-67: ----------------------------- Sprint: Sprint 1 - Critical Issues, Sprint 1, Sprint 2 (was: Sprint 1 - Critical Issues, Sprint 1) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/ARQGRA-67?page=com.atlassian.jira.plugin.... ] Jan Papousek updated ARQGRA-67: ------------------------------- Status: Resolved (was: Pull Request Sent) Resolution: Done -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira