5:19 p.m.
Karel Piwko created ARQ-1096:
--------------------------------
Summary: Make default container selection IDE friendly
Key: ARQ-1096
URL: https://issues.jboss.org/browse/ARQ-1096
Project: Arquillian
Issue Type: Enhancement
Security Level: Public (Everyone can see)
Components: Configuration
Affects Versions: 1.0.2.Final
Reporter: Karel Piwko
It is almost impossible to select container via Maven Profile in an IDE. IDE does not
honor Surefire execution properties.
Instead of marking a container as default, e.g.
{code:xml}
<container qualifier="foo" default="true>
</container>
{code}
Allow something like following in arquillian.xml
{code:xml}
<default-container>foo</default-container>
{code}
With this approach foo value can be replaced with a place holder ${foo.value} and
foo.value can be filtered for actual value via Maven profiles.
Note, this behavior is already implemented as extension at:
https://github.com/kpiwko/arquillian-extension-container-selector
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:53 a.m.
[
https://issues.jboss.org/browse/ARQ-1096?page=com.atlassian.jira.plugin.s...
]
Michal Matloka commented on ARQ-1096:
-------------------------------------
Do you suggest supporting both these variants or full migration to
<default-container>foo</default-container>?
Make default container selection IDE friendly
---------------------------------------------
Key: ARQ-1096
URL: https://issues.jboss.org/browse/ARQ-1096
Project: Arquillian
Issue Type: Enhancement
Security Level: Public(Everyone can see)
Components: Configuration
Affects Versions: 1.0.2.Final
Reporter: Karel Piwko
It is almost impossible to select container via Maven Profile in an IDE. IDE does not
honor Surefire execution properties.
Instead of marking a container as default, e.g.
{code:xml}
<container qualifier="foo" default="true>
</container>
{code}
Allow something like following in arquillian.xml
{code:xml}
<default-container>foo</default-container>
{code}
With this approach foo value can be replaced with a place holder ${foo.value} and
foo.value can be filtered for actual value via Maven profiles.
Note, this behavior is already implemented as extension at:
https://github.com/kpiwko/arquillian-extension-container-selector
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:50 p.m.
[
https://issues.jboss.org/browse/ARQ-1096?page=com.atlassian.jira.plugin.s...
]
Aslak Knutsen commented on ARQ-1096:
------------------------------------
There are currently two use cases for "default":
/container@default
* Which configuration to use if non is specified via arquillian.launch
/group/container@default
* which configuration to use if no @TargetsContainer is used with @Deployment in a multi
container setup
I don't think the second case would benefit from this change as it would most likely
require a TestClass change to work.
arquillian.launch refer to either a container@qualifier or a group@qualifier.
Arquillian Core supports reading a File called arquillian.launch containing the qualifier
as well. The intent for this was that it's easier to change the value of a file then
to change the IDE system properties launch configuration (and would not require a
recalculation of the Maven classpath if you jumped between same containers, e.g. local,
test, staging).
Not saying it's a good solution, but should be workable today, is to filter the
arquillian.launch file based on Profiles instead of arquillian.xml
Make default container selection IDE friendly
---------------------------------------------
Key: ARQ-1096
URL: https://issues.jboss.org/browse/ARQ-1096
Project: Arquillian
Issue Type: Enhancement
Security Level: Public(Everyone can see)
Components: Configuration
Affects Versions: 1.0.2.Final
Reporter: Karel Piwko
It is almost impossible to select container via Maven Profile in an IDE. IDE does not
honor Surefire execution properties.
Instead of marking a container as default, e.g.
{code:xml}
<container qualifier="foo" default="true>
</container>
{code}
Allow something like following in arquillian.xml
{code:xml}
<default-container>foo</default-container>
{code}
With this approach foo value can be replaced with a place holder ${foo.value} and
foo.value can be filtered for actual value via Maven profiles.
Note, this behavior is already implemented as extension at:
https://github.com/kpiwko/arquillian-extension-container-selector
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:38 a.m.
[
https://issues.jboss.org/browse/ARQ-1096?page=com.atlassian.jira.plugin.s...
]
Karel Piwko commented on ARQ-1096:
----------------------------------
Using default=true + arquillian.launch with Maven Resource Filtering works. Does not seem
nice but still works with current infrastructure.
Do we want to change the behavior somehow in future?
Make default container selection IDE friendly
---------------------------------------------
Key: ARQ-1096
URL: https://issues.jboss.org/browse/ARQ-1096
Project: Arquillian
Issue Type: Enhancement
Security Level: Public(Everyone can see)
Components: Configuration
Affects Versions: 1.0.2.Final
Reporter: Karel Piwko
It is almost impossible to select container via Maven Profile in an IDE. IDE does not
honor Surefire execution properties.
Instead of marking a container as default, e.g.
{code:xml}
<container qualifier="foo" default="true>
</container>
{code}
Allow something like following in arquillian.xml
{code:xml}
<default-container>foo</default-container>
{code}
With this approach foo value can be replaced with a place holder ${foo.value} and
foo.value can be filtered for actual value via Maven profiles.
Note, this behavior is already implemented as extension at:
https://github.com/kpiwko/arquillian-extension-container-selector
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
4469
days inactive
4491
days old
arquillian-issues@lists.jboss.org
3 comments
3 participants
participants (3)
-
Aslak Knutsen (JIRA) -
Karel Piwko (JIRA)
-
Michal Matloka (JIRA)