[JBoss JIRA] Created: (ARQ-563) @ArquillianResource in TestNG based tests causes test body not to be evaluated
5:22 a.m.
@ArquillianResource in TestNG based tests causes test body not to be evaluated
------------------------------------------------------------------------------
Key: ARQ-563
URL: https://issues.jboss.org/browse/ARQ-563
Project: Arquillian
Issue Type: Bug
Security Level: Public (Everyone can see)
Components: Test Protocol SPIs and Implementation
Affects Versions: 1.0.0.CR4
Environment: Surefire 2.7.2, 2.9
TestNG 5.14.6, 5.14.9
AS 7.0.1 web
Reporter: Karel Piwko
Priority: Blocker
Suppose following test case:
{code}
public class LowercaseConverterTest extends Arquillian {
@Inject
private LowercaseConverter lowercaseConverter;
@Deployment
public static JavaArchive createTestArchive() {
return ShrinkWrap
.create(JavaArchive.class, "test.jar")
.addClasses(LowercaseConverter.class)
.addAsManifestResource(EmptyAsset.INSTANCE,
ArchivePaths.create("beans.xml"));
}
@Test
public void testConvertToLowercase() {
Assert.assertEquals("martin",
lowercaseConverter.convertToLowercase("Martin"));
}
}
{code}
However, if @ArquillianResource is used for a field injection, such as:
{code}
@ArquillianResource URL field;
{code}
than test body is no longer executed and *all tests are reported as passed* even an
obvious failure like:
{code}
@Test
public void testConvertToLowercase() {
Assert.fail();
Assert.assertEquals("karel",
lowercaseConverter.convertToLowercase("Martin"));
}
{code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:49 a.m.
New subject: [JBoss JIRA] Assigned: (ARQ-563) @ArquillianResource in TestNG based tests causes test body not to be evaluated
[
https://issues.jboss.org/browse/ARQ-563?page=com.atlassian.jira.plugin.sy...
]
Andrew Rubinger reassigned ARQ-563:
-----------------------------------
Assignee: Andrew Rubinger
@ArquillianResource in TestNG based tests causes test body not to be
evaluated
------------------------------------------------------------------------------
Key: ARQ-563
URL: https://issues.jboss.org/browse/ARQ-563
Project: Arquillian
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Test Protocol SPIs and Implementation
Affects Versions: 1.0.0.CR4
Environment: Surefire 2.7.2, 2.9
TestNG 5.14.6, 5.14.9
AS 7.0.1 web
Reporter: Karel Piwko
Assignee: Andrew Rubinger
Priority: Blocker
Suppose following test case:
{code}
public class LowercaseConverterTest extends Arquillian {
@Inject
private LowercaseConverter lowercaseConverter;
@Deployment
public static JavaArchive createTestArchive() {
return ShrinkWrap
.create(JavaArchive.class, "test.jar")
.addClasses(LowercaseConverter.class)
.addAsManifestResource(EmptyAsset.INSTANCE,
ArchivePaths.create("beans.xml"));
}
@Test
public void testConvertToLowercase() {
Assert.assertEquals("martin",
lowercaseConverter.convertToLowercase("Martin"));
}
}
{code}
However, if @ArquillianResource is used for a field injection, such as:
{code}
@ArquillianResource URL field;
{code}
than test body is no longer executed and *all tests are reported as passed* even an
obvious failure like:
{code}
@Test
public void testConvertToLowercase() {
Assert.fail();
Assert.assertEquals("karel",
lowercaseConverter.convertToLowercase("Martin"));
}
{code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:38 a.m.
New subject: [JBoss JIRA] Commented: (ARQ-563) @ArquillianResource in TestNG based tests causes test body not to be evaluated
[
https://issues.jboss.org/browse/ARQ-563?page=com.atlassian.jira.plugin.sy...
]
Aslak Knutsen commented on ARQ-563:
-----------------------------------
@ArquillianResource's URL provider is only valid on the client side. (@RunAsClient or
@Deployment.testable=false)
It's obviously having some issues reporting the Injection failure to fail the test as
a whole. I'll check that.
@ArquillianResource in TestNG based tests causes test body not to be
evaluated
------------------------------------------------------------------------------
Key: ARQ-563
URL: https://issues.jboss.org/browse/ARQ-563
Project: Arquillian
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Test Protocol SPIs and Implementation
Affects Versions: 1.0.0.CR4
Environment: Surefire 2.7.2, 2.9
TestNG 5.14.6, 5.14.9
AS 7.0.1 web
Reporter: Karel Piwko
Assignee: Andrew Rubinger
Priority: Blocker
Suppose following test case:
{code}
public class LowercaseConverterTest extends Arquillian {
@Inject
private LowercaseConverter lowercaseConverter;
@Deployment
public static JavaArchive createTestArchive() {
return ShrinkWrap
.create(JavaArchive.class, "test.jar")
.addClasses(LowercaseConverter.class)
.addAsManifestResource(EmptyAsset.INSTANCE,
ArchivePaths.create("beans.xml"));
}
@Test
public void testConvertToLowercase() {
Assert.assertEquals("martin",
lowercaseConverter.convertToLowercase("Martin"));
}
}
{code}
However, if @ArquillianResource is used for a field injection, such as:
{code}
@ArquillianResource URL field;
{code}
than test body is no longer executed and *all tests are reported as passed* even an
obvious failure like:
{code}
@Test
public void testConvertToLowercase() {
Assert.fail();
Assert.assertEquals("karel",
lowercaseConverter.convertToLowercase("Martin"));
}
{code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:51 a.m.
New subject: [JBoss JIRA] Commented: (ARQ-563) @ArquillianResource in TestNG based tests causes test body not to be evaluated
[
https://issues.jboss.org/browse/ARQ-563?page=com.atlassian.jira.plugin.sy...
]
Martin Kouba commented on ARQ-563:
----------------------------------
Is it valid for mixed mode too? If not is there other way to get deployment URL in mixed
mode?
@ArquillianResource in TestNG based tests causes test body not to be
evaluated
------------------------------------------------------------------------------
Key: ARQ-563
URL: https://issues.jboss.org/browse/ARQ-563
Project: Arquillian
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Test Protocol SPIs and Implementation
Affects Versions: 1.0.0.CR4
Environment: Surefire 2.7.2, 2.9
TestNG 5.14.6, 5.14.9
AS 7.0.1 web
Reporter: Karel Piwko
Assignee: Andrew Rubinger
Priority: Blocker
Suppose following test case:
{code}
public class LowercaseConverterTest extends Arquillian {
@Inject
private LowercaseConverter lowercaseConverter;
@Deployment
public static JavaArchive createTestArchive() {
return ShrinkWrap
.create(JavaArchive.class, "test.jar")
.addClasses(LowercaseConverter.class)
.addAsManifestResource(EmptyAsset.INSTANCE,
ArchivePaths.create("beans.xml"));
}
@Test
public void testConvertToLowercase() {
Assert.assertEquals("martin",
lowercaseConverter.convertToLowercase("Martin"));
}
}
{code}
However, if @ArquillianResource is used for a field injection, such as:
{code}
@ArquillianResource URL field;
{code}
than test body is no longer executed and *all tests are reported as passed* even an
obvious failure like:
{code}
@Test
public void testConvertToLowercase() {
Assert.fail();
Assert.assertEquals("karel",
lowercaseConverter.convertToLowercase("Martin"));
}
{code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:43 a.m.
New subject: [JBoss JIRA] Commented: (ARQ-563) @ArquillianResource in TestNG based tests causes test body not to be evaluated
[
https://issues.jboss.org/browse/ARQ-563?page=com.atlassian.jira.plugin.sy...
]
Aslak Knutsen commented on ARQ-563:
-----------------------------------
It's valid as long as @Test is executed on client side.
If you have it as a Field injection, it will be attempted executed on both sides if you
have mixed mode @Test methods.
If you only want to use it in a single @Test that is executed on Client you can use a
Method injection instead.
@Test(dataProvider = Arquillian.ARQUILLIAN_DATA_PROVIDER)
public void should(@ArquillianResource URL url) {}
@ArquillianResource in TestNG based tests causes test body not to be
evaluated
------------------------------------------------------------------------------
Key: ARQ-563
URL: https://issues.jboss.org/browse/ARQ-563
Project: Arquillian
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Test Protocol SPIs and Implementation
Affects Versions: 1.0.0.CR4
Environment: Surefire 2.7.2, 2.9
TestNG 5.14.6, 5.14.9
AS 7.0.1 web
Reporter: Karel Piwko
Assignee: Andrew Rubinger
Priority: Blocker
Suppose following test case:
{code}
public class LowercaseConverterTest extends Arquillian {
@Inject
private LowercaseConverter lowercaseConverter;
@Deployment
public static JavaArchive createTestArchive() {
return ShrinkWrap
.create(JavaArchive.class, "test.jar")
.addClasses(LowercaseConverter.class)
.addAsManifestResource(EmptyAsset.INSTANCE,
ArchivePaths.create("beans.xml"));
}
@Test
public void testConvertToLowercase() {
Assert.assertEquals("martin",
lowercaseConverter.convertToLowercase("Martin"));
}
}
{code}
However, if @ArquillianResource is used for a field injection, such as:
{code}
@ArquillianResource URL field;
{code}
than test body is no longer executed and *all tests are reported as passed* even an
obvious failure like:
{code}
@Test
public void testConvertToLowercase() {
Assert.fail();
Assert.assertEquals("karel",
lowercaseConverter.convertToLowercase("Martin"));
}
{code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:12 a.m.
New subject: [JBoss JIRA] Commented: (ARQ-563) @ArquillianResource in TestNG based tests causes test body not to be evaluated
[
https://issues.jboss.org/browse/ARQ-563?page=com.atlassian.jira.plugin.sy...
]
Karel Piwko commented on ARQ-563:
---------------------------------
Andrew, Aslak,
any progress on this? I've got reported that these false negatives might be reported
even in case that @Inject based annotation fails, so - *It's obviously having some
issues reporting the Injection failure to fail the test as a whole. I'll check that.*
- must definitely be fixed.
@ArquillianResource in TestNG based tests causes test body not to be
evaluated
------------------------------------------------------------------------------
Key: ARQ-563
URL: https://issues.jboss.org/browse/ARQ-563
Project: Arquillian
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Test Protocol SPIs and Implementation
Affects Versions: 1.0.0.CR4
Environment: Surefire 2.7.2, 2.9
TestNG 5.14.6, 5.14.9
AS 7.0.1 web
Reporter: Karel Piwko
Assignee: Andrew Rubinger
Priority: Blocker
Suppose following test case:
{code}
public class LowercaseConverterTest extends Arquillian {
@Inject
private LowercaseConverter lowercaseConverter;
@Deployment
public static JavaArchive createTestArchive() {
return ShrinkWrap
.create(JavaArchive.class, "test.jar")
.addClasses(LowercaseConverter.class)
.addAsManifestResource(EmptyAsset.INSTANCE,
ArchivePaths.create("beans.xml"));
}
@Test
public void testConvertToLowercase() {
Assert.assertEquals("martin",
lowercaseConverter.convertToLowercase("Martin"));
}
}
{code}
However, if @ArquillianResource is used for a field injection, such as:
{code}
@ArquillianResource URL field;
{code}
than test body is no longer executed and *all tests are reported as passed* even an
obvious failure like:
{code}
@Test
public void testConvertToLowercase() {
Assert.fail();
Assert.assertEquals("karel",
lowercaseConverter.convertToLowercase("Martin"));
}
{code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:51 a.m.
New subject: [JBoss JIRA] Updated: (ARQ-563) @ArquillianResource in TestNG based tests causes test body not to be evaluated
[
https://issues.jboss.org/browse/ARQ-563?page=com.atlassian.jira.plugin.sy...
]
Aslak Knutsen updated ARQ-563:
------------------------------
Fix Version/s: 1.0.0.Final
@ArquillianResource in TestNG based tests causes test body not to be
evaluated
------------------------------------------------------------------------------
Key: ARQ-563
URL: https://issues.jboss.org/browse/ARQ-563
Project: Arquillian
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Test Protocol SPIs and Implementation
Affects Versions: 1.0.0.CR4
Environment: Surefire 2.7.2, 2.9
TestNG 5.14.6, 5.14.9
AS 7.0.1 web
Reporter: Karel Piwko
Assignee: Andrew Rubinger
Priority: Blocker
Fix For: 1.0.0.Final
Suppose following test case:
{code}
public class LowercaseConverterTest extends Arquillian {
@Inject
private LowercaseConverter lowercaseConverter;
@Deployment
public static JavaArchive createTestArchive() {
return ShrinkWrap
.create(JavaArchive.class, "test.jar")
.addClasses(LowercaseConverter.class)
.addAsManifestResource(EmptyAsset.INSTANCE,
ArchivePaths.create("beans.xml"));
}
@Test
public void testConvertToLowercase() {
Assert.assertEquals("martin",
lowercaseConverter.convertToLowercase("Martin"));
}
}
{code}
However, if @ArquillianResource is used for a field injection, such as:
{code}
@ArquillianResource URL field;
{code}
than test body is no longer executed and *all tests are reported as passed* even an
obvious failure like:
{code}
@Test
public void testConvertToLowercase() {
Assert.fail();
Assert.assertEquals("karel",
lowercaseConverter.convertToLowercase("Martin"));
}
{code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:42 a.m.
New subject: [JBoss JIRA] (ARQ-563) @ArquillianResource in TestNG based tests causes test body not to be evaluated
[
https://issues.jboss.org/browse/ARQ-563?page=com.atlassian.jira.plugin.sy...
]
Daniel Miklancic commented on ARQ-563:
--------------------------------------
Similar behavior is experienced when adding @Resource for a datasource--TestNG test method
bodies are not executed and all test report "passed".
@ArquillianResource in TestNG based tests causes test body not to be
evaluated
------------------------------------------------------------------------------
Key: ARQ-563
URL: https://issues.jboss.org/browse/ARQ-563
Project: Arquillian
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Test Protocol SPIs and Implementation
Affects Versions: 1.0.0.CR4
Environment: Surefire 2.7.2, 2.9
TestNG 5.14.6, 5.14.9
AS 7.0.1 web
Reporter: Karel Piwko
Assignee: Andrew Rubinger
Priority: Blocker
Fix For: 1.0.0.Final
Suppose following test case:
{code}
public class LowercaseConverterTest extends Arquillian {
@Inject
private LowercaseConverter lowercaseConverter;
@Deployment
public static JavaArchive createTestArchive() {
return ShrinkWrap
.create(JavaArchive.class, "test.jar")
.addClasses(LowercaseConverter.class)
.addAsManifestResource(EmptyAsset.INSTANCE,
ArchivePaths.create("beans.xml"));
}
@Test
public void testConvertToLowercase() {
Assert.assertEquals("martin",
lowercaseConverter.convertToLowercase("Martin"));
}
}
{code}
However, if @ArquillianResource is used for a field injection, such as:
{code}
@ArquillianResource URL field;
{code}
than test body is no longer executed and *all tests are reported as passed* even an
obvious failure like:
{code}
@Test
public void testConvertToLowercase() {
Assert.fail();
Assert.assertEquals("karel",
lowercaseConverter.convertToLowercase("Martin"));
}
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:08 a.m.
New subject: [JBoss JIRA] (ARQ-563) @ArquillianResource in TestNG based tests causes test body not to be evaluated
[
https://issues.jboss.org/browse/ARQ-563?page=com.atlassian.jira.plugin.sy...
]
SBS JIRA Integration updated ARQ-563:
-------------------------------------
Forum Reference: http://community.jboss.org/message/636885#636885
@ArquillianResource in TestNG based tests causes test body not to be
evaluated
------------------------------------------------------------------------------
Key: ARQ-563
URL: https://issues.jboss.org/browse/ARQ-563
Project: Arquillian
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Test Protocol SPIs and Implementation
Affects Versions: 1.0.0.CR4
Environment: Surefire 2.7.2, 2.9
TestNG 5.14.6, 5.14.9
AS 7.0.1 web
Reporter: Karel Piwko
Assignee: Andrew Rubinger
Priority: Blocker
Fix For: 1.0.0.Final
Suppose following test case:
{code}
public class LowercaseConverterTest extends Arquillian {
@Inject
private LowercaseConverter lowercaseConverter;
@Deployment
public static JavaArchive createTestArchive() {
return ShrinkWrap
.create(JavaArchive.class, "test.jar")
.addClasses(LowercaseConverter.class)
.addAsManifestResource(EmptyAsset.INSTANCE,
ArchivePaths.create("beans.xml"));
}
@Test
public void testConvertToLowercase() {
Assert.assertEquals("martin",
lowercaseConverter.convertToLowercase("Martin"));
}
}
{code}
However, if @ArquillianResource is used for a field injection, such as:
{code}
@ArquillianResource URL field;
{code}
than test body is no longer executed and *all tests are reported as passed* even an
obvious failure like:
{code}
@Test
public void testConvertToLowercase() {
Assert.fail();
Assert.assertEquals("karel",
lowercaseConverter.convertToLowercase("Martin"));
}
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:43 a.m.
New subject: [JBoss JIRA] (ARQ-563) @ArquillianResource in TestNG based tests causes test body not to be evaluated
[
https://issues.jboss.org/browse/ARQ-563?page=com.atlassian.jira.plugin.sy...
]
Hanspeter Gisler commented on ARQ-563:
--------------------------------------
TestNG also reports *tests all passed*, if a normal CDI field @inject fails
(e.g. because the to be injected class has been forgotten to be added via shrinkwrap).
As Aslak Knutsen guesses (http://community.jboss.org/thread/174948?tstart=0), this
probably has to do with testng's behaviour to skip the tests (and mark them as passed)
if an error occures in @BeforeClass (where arquillian hookes in).
@ArquillianResource in TestNG based tests causes test body not to be
evaluated
------------------------------------------------------------------------------
Key: ARQ-563
URL: https://issues.jboss.org/browse/ARQ-563
Project: Arquillian
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Test Protocol SPIs and Implementation
Affects Versions: 1.0.0.CR4
Environment: Surefire 2.7.2, 2.9
TestNG 5.14.6, 5.14.9
AS 7.0.1 web
Reporter: Karel Piwko
Assignee: Andrew Rubinger
Priority: Blocker
Fix For: 1.0.0.Final
Suppose following test case:
{code}
public class LowercaseConverterTest extends Arquillian {
@Inject
private LowercaseConverter lowercaseConverter;
@Deployment
public static JavaArchive createTestArchive() {
return ShrinkWrap
.create(JavaArchive.class, "test.jar")
.addClasses(LowercaseConverter.class)
.addAsManifestResource(EmptyAsset.INSTANCE,
ArchivePaths.create("beans.xml"));
}
@Test
public void testConvertToLowercase() {
Assert.assertEquals("martin",
lowercaseConverter.convertToLowercase("Martin"));
}
}
{code}
However, if @ArquillianResource is used for a field injection, such as:
{code}
@ArquillianResource URL field;
{code}
than test body is no longer executed and *all tests are reported as passed* even an
obvious failure like:
{code}
@Test
public void testConvertToLowercase() {
Assert.fail();
Assert.assertEquals("karel",
lowercaseConverter.convertToLowercase("Martin"));
}
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:45 a.m.
New subject: [JBoss JIRA] (ARQ-563) @ArquillianResource in TestNG based tests causes test body not to be evaluated
[
https://issues.jboss.org/browse/ARQ-563?page=com.atlassian.jira.plugin.sy...
]
Hanspeter Gisler edited comment on ARQ-563 at 11/19/11 7:44 AM:
----------------------------------------------------------------
TestNG also reports *tests all passed*, if a normal CDI field @inject fails
(e.g. because the to be injected class has been forgotten to be added via shrinkwrap).
As Aslak Knutsen guesses (http://community.jboss.org/thread/174948?tstart=0), this
probably has to do with testng's behaviour to skip the tests (and mark them as passed)
if an error occures in @BeforeClass (where arquillian hookes in).
We certainly need a helpful *error message*, when this happens.
was (Author: hpgisler):
TestNG also reports *tests all passed*, if a normal CDI field @inject fails
(e.g. because the to be injected class has been forgotten to be added via shrinkwrap).
As Aslak Knutsen guesses (http://community.jboss.org/thread/174948?tstart=0), this
probably has to do with testng's behaviour to skip the tests (and mark them as passed)
if an error occures in @BeforeClass (where arquillian hookes in).
@ArquillianResource in TestNG based tests causes test body not to be
evaluated
------------------------------------------------------------------------------
Key: ARQ-563
URL: https://issues.jboss.org/browse/ARQ-563
Project: Arquillian
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Test Protocol SPIs and Implementation
Affects Versions: 1.0.0.CR4
Environment: Surefire 2.7.2, 2.9
TestNG 5.14.6, 5.14.9
AS 7.0.1 web
Reporter: Karel Piwko
Assignee: Andrew Rubinger
Priority: Blocker
Fix For: 1.0.0.Final
Suppose following test case:
{code}
public class LowercaseConverterTest extends Arquillian {
@Inject
private LowercaseConverter lowercaseConverter;
@Deployment
public static JavaArchive createTestArchive() {
return ShrinkWrap
.create(JavaArchive.class, "test.jar")
.addClasses(LowercaseConverter.class)
.addAsManifestResource(EmptyAsset.INSTANCE,
ArchivePaths.create("beans.xml"));
}
@Test
public void testConvertToLowercase() {
Assert.assertEquals("martin",
lowercaseConverter.convertToLowercase("Martin"));
}
}
{code}
However, if @ArquillianResource is used for a field injection, such as:
{code}
@ArquillianResource URL field;
{code}
than test body is no longer executed and *all tests are reported as passed* even an
obvious failure like:
{code}
@Test
public void testConvertToLowercase() {
Assert.fail();
Assert.assertEquals("karel",
lowercaseConverter.convertToLowercase("Martin"));
}
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:42 p.m.
New subject: [JBoss JIRA] (ARQ-563) @ArquillianResource in TestNG based tests causes test body not to be evaluated
[
https://issues.jboss.org/browse/ARQ-563?page=com.atlassian.jira.plugin.sy...
]
Aslak Knutsen updated ARQ-563:
------------------------------
Fix Version/s: 1.1.0.Beta1
(was: 1.0.0.Final)
Forum Reference: http://community.jboss.org/message/636885#636885 (was:
http://community.jboss.org/message/636885#636885)
@ArquillianResource in TestNG based tests causes test body not to be
evaluated
------------------------------------------------------------------------------
Key: ARQ-563
URL: https://issues.jboss.org/browse/ARQ-563
Project: Arquillian
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Test Protocol SPIs and Implementation
Affects Versions: 1.0.0.CR4
Environment: Surefire 2.7.2, 2.9
TestNG 5.14.6, 5.14.9
AS 7.0.1 web
Reporter: Karel Piwko
Assignee: Andrew Rubinger
Priority: Blocker
Fix For: 1.1.0.Beta1
Suppose following test case:
{code}
public class LowercaseConverterTest extends Arquillian {
@Inject
private LowercaseConverter lowercaseConverter;
@Deployment
public static JavaArchive createTestArchive() {
return ShrinkWrap
.create(JavaArchive.class, "test.jar")
.addClasses(LowercaseConverter.class)
.addAsManifestResource(EmptyAsset.INSTANCE,
ArchivePaths.create("beans.xml"));
}
@Test
public void testConvertToLowercase() {
Assert.assertEquals("martin",
lowercaseConverter.convertToLowercase("Martin"));
}
}
{code}
However, if @ArquillianResource is used for a field injection, such as:
{code}
@ArquillianResource URL field;
{code}
than test body is no longer executed and *all tests are reported as passed* even an
obvious failure like:
{code}
@Test
public void testConvertToLowercase() {
Assert.fail();
Assert.assertEquals("karel",
lowercaseConverter.convertToLowercase("Martin"));
}
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:25 p.m.
New subject: [JBoss JIRA] (ARQ-563) @ArquillianResource in TestNG based tests causes test body not to be evaluated
[
https://issues.jboss.org/browse/ARQ-563?page=com.atlassian.jira.plugin.sy...
]
Brian Reilly commented on ARQ-563:
----------------------------------
I had a similar problem with exceptions being lost when using TestNG. In my case, a
constructor of an object that was being injected into the test class threw an exception.
This was a very difficult problem to debug, but I think the biggest problem is that the
test is ultimately reported as having passed even though the test method itself is never
executed.
@ArquillianResource in TestNG based tests causes test body not to be
evaluated
------------------------------------------------------------------------------
Key: ARQ-563
URL: https://issues.jboss.org/browse/ARQ-563
Project: Arquillian
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Test Protocol SPIs and Implementation
Affects Versions: 1.0.0.CR4
Environment: Surefire 2.7.2, 2.9
TestNG 5.14.6, 5.14.9
AS 7.0.1 web
Reporter: Karel Piwko
Assignee: Andrew Rubinger
Priority: Blocker
Fix For: 1.1.0.Beta1
Suppose following test case:
{code}
public class LowercaseConverterTest extends Arquillian {
@Inject
private LowercaseConverter lowercaseConverter;
@Deployment
public static JavaArchive createTestArchive() {
return ShrinkWrap
.create(JavaArchive.class, "test.jar")
.addClasses(LowercaseConverter.class)
.addAsManifestResource(EmptyAsset.INSTANCE,
ArchivePaths.create("beans.xml"));
}
@Test
public void testConvertToLowercase() {
Assert.assertEquals("martin",
lowercaseConverter.convertToLowercase("Martin"));
}
}
{code}
However, if @ArquillianResource is used for a field injection, such as:
{code}
@ArquillianResource URL field;
{code}
than test body is no longer executed and *all tests are reported as passed* even an
obvious failure like:
{code}
@Test
public void testConvertToLowercase() {
Assert.fail();
Assert.assertEquals("karel",
lowercaseConverter.convertToLowercase("Martin"));
}
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:19 a.m.
New subject: [JBoss JIRA] (ARQ-563) @ArquillianResource in TestNG based tests causes test body not to be evaluated
[
https://issues.jboss.org/browse/ARQ-563?page=com.atlassian.jira.plugin.sy...
]
Kristoffer Richardsson commented on ARQ-563:
--------------------------------------------
I have seen this problem as well, similar to the Hanspeter Gisler scenario. A test class
like this will pass without any errors.
{code}
public class TestNotEvaluatedExample extends Arquillian {
private ClassThatIsNotIncludedInJar instance;
@Deployment
public static JavaArchive createTestArchive() {
return ShrinkWrap.create(JavaArchive.class, "test.jar");
}
@Test
public void testThatIsNotEvaluated() {
Assert.fail("Expecting this assert to fail but it is not executed");
}
}
{code}
It seems as testNG actually catches the error but that arquillian ignores it. In
{{TestListener.getTestResult()}}, {{context}} is examined for failedTests, skippedTests
and passedTests, but testNG reports this problem as a failed configuration, not a failed
test.
{code}
public TestResult getTestResult()
{
if(context.getFailedTests().size() > 0)
{
return new TestResult(
Status.FAILED,
context.getFailedTests().getAllResults().iterator().next().getThrowable());
}
else if(context.getSkippedTests().size() > 0)
{
return new TestResult(Status.SKIPPED);
}
if(context.getPassedTests().size() > 0)
{
return new TestResult(
Status.PASSED,
context.getPassedTests().getAllResults().iterator().next().getThrowable());
}
return new TestResult(
Status.FAILED,
new RuntimeException("Unknown test result: " +
context).fillInStackTrace());
}
{code}
The problem can be solved by checking {{context.getFailedConfigurations()}} as well.
{code}
public TestResult getTestResult()
{
if(context.getFailedConfigurations().size() > 0)
{
return new TestResult(
Status.FAILED,
context.getFailedConfigurations().getAllResults().iterator().next().getThrowable());
}
else if(context.getFailedTests().size() > 0)
{
return new TestResult(
Status.FAILED,
context.getFailedTests().getAllResults().iterator().next().getThrowable());
}...
{code}
I'll add a pull request for this.
@ArquillianResource in TestNG based tests causes test body not to be
evaluated
------------------------------------------------------------------------------
Key: ARQ-563
URL: https://issues.jboss.org/browse/ARQ-563
Project: Arquillian
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Test Protocol SPIs and Implementation
Affects Versions: 1.0.0.CR4
Environment: Surefire 2.7.2, 2.9
TestNG 5.14.6, 5.14.9
AS 7.0.1 web
Reporter: Karel Piwko
Assignee: Andrew Rubinger
Priority: Blocker
Fix For: 1.1.0.Beta1
Suppose following test case:
{code}
public class LowercaseConverterTest extends Arquillian {
@Inject
private LowercaseConverter lowercaseConverter;
@Deployment
public static JavaArchive createTestArchive() {
return ShrinkWrap
.create(JavaArchive.class, "test.jar")
.addClasses(LowercaseConverter.class)
.addAsManifestResource(EmptyAsset.INSTANCE,
ArchivePaths.create("beans.xml"));
}
@Test
public void testConvertToLowercase() {
Assert.assertEquals("martin",
lowercaseConverter.convertToLowercase("Martin"));
}
}
{code}
However, if @ArquillianResource is used for a field injection, such as:
{code}
@ArquillianResource URL field;
{code}
than test body is no longer executed and *all tests are reported as passed* even an
obvious failure like:
{code}
@Test
public void testConvertToLowercase() {
Assert.fail();
Assert.assertEquals("karel",
lowercaseConverter.convertToLowercase("Martin"));
}
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:42 a.m.
New subject: [JBoss JIRA] (ARQ-563) @ArquillianResource in TestNG based tests causes test body not to be evaluated
[
https://issues.jboss.org/browse/ARQ-563?page=com.atlassian.jira.plugin.sy...
]
Karel Piwko updated ARQ-563:
----------------------------
Status: Pull Request Sent (was: Open)
Git Pull Request: https://github.com/arquillian/arquillian-core/pull/37
@ArquillianResource in TestNG based tests causes test body not to be
evaluated
------------------------------------------------------------------------------
Key: ARQ-563
URL: https://issues.jboss.org/browse/ARQ-563
Project: Arquillian
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Test Protocol SPIs and Implementation
Affects Versions: 1.0.0.CR4
Environment: Surefire 2.7.2, 2.9
TestNG 5.14.6, 5.14.9
AS 7.0.1 web
Reporter: Karel Piwko
Assignee: Andrew Rubinger
Priority: Blocker
Fix For: 1.1.0.Beta1
Suppose following test case:
{code}
public class LowercaseConverterTest extends Arquillian {
@Inject
private LowercaseConverter lowercaseConverter;
@Deployment
public static JavaArchive createTestArchive() {
return ShrinkWrap
.create(JavaArchive.class, "test.jar")
.addClasses(LowercaseConverter.class)
.addAsManifestResource(EmptyAsset.INSTANCE,
ArchivePaths.create("beans.xml"));
}
@Test
public void testConvertToLowercase() {
Assert.assertEquals("martin",
lowercaseConverter.convertToLowercase("Martin"));
}
}
{code}
However, if @ArquillianResource is used for a field injection, such as:
{code}
@ArquillianResource URL field;
{code}
than test body is no longer executed and *all tests are reported as passed* even an
obvious failure like:
{code}
@Test
public void testConvertToLowercase() {
Assert.fail();
Assert.assertEquals("karel",
lowercaseConverter.convertToLowercase("Martin"));
}
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:26 a.m.
New subject: [JBoss JIRA] (ARQ-563) @ArquillianResource in TestNG based tests causes test body not to be evaluated
[
https://issues.jboss.org/browse/ARQ-563?page=com.atlassian.jira.plugin.sy...
]
Aslak Knutsen updated ARQ-563:
------------------------------
Status: Resolved (was: Pull Request Sent)
Fix Version/s: 1.0.3.Final
(was: 1.1.0.Beta1)
Resolution: Done
@ArquillianResource in TestNG based tests causes test body not to be
evaluated
------------------------------------------------------------------------------
Key: ARQ-563
URL: https://issues.jboss.org/browse/ARQ-563
Project: Arquillian
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Test Protocol SPIs and Implementation
Affects Versions: 1.0.0.CR4
Environment: Surefire 2.7.2, 2.9
TestNG 5.14.6, 5.14.9
AS 7.0.1 web
Reporter: Karel Piwko
Assignee: Andrew Rubinger
Priority: Blocker
Fix For: 1.0.3.Final
Suppose following test case:
{code}
public class LowercaseConverterTest extends Arquillian {
@Inject
private LowercaseConverter lowercaseConverter;
@Deployment
public static JavaArchive createTestArchive() {
return ShrinkWrap
.create(JavaArchive.class, "test.jar")
.addClasses(LowercaseConverter.class)
.addAsManifestResource(EmptyAsset.INSTANCE,
ArchivePaths.create("beans.xml"));
}
@Test
public void testConvertToLowercase() {
Assert.assertEquals("martin",
lowercaseConverter.convertToLowercase("Martin"));
}
}
{code}
However, if @ArquillianResource is used for a field injection, such as:
{code}
@ArquillianResource URL field;
{code}
than test body is no longer executed and *all tests are reported as passed* even an
obvious failure like:
{code}
@Test
public void testConvertToLowercase() {
Assert.fail();
Assert.assertEquals("karel",
lowercaseConverter.convertToLowercase("Martin"));
}
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:55 a.m.
New subject: [JBoss JIRA] (ARQ-563) @ArquillianResource in TestNG based tests causes test body not to be evaluated
[
https://issues.jboss.org/browse/ARQ-563?page=com.atlassian.jira.plugin.sy...
]
Aslak Knutsen updated ARQ-563:
------------------------------
Assignee: (was: Andrew Rubinger)
@ArquillianResource in TestNG based tests causes test body not to be
evaluated
------------------------------------------------------------------------------
Key: ARQ-563
URL: https://issues.jboss.org/browse/ARQ-563
Project: Arquillian
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Test Protocol SPIs and Implementation
Affects Versions: 1.0.0.CR4
Environment: Surefire 2.7.2, 2.9
TestNG 5.14.6, 5.14.9
AS 7.0.1 web
Reporter: Karel Piwko
Priority: Blocker
Fix For: 1.0.3.Final
Suppose following test case:
{code}
public class LowercaseConverterTest extends Arquillian {
@Inject
private LowercaseConverter lowercaseConverter;
@Deployment
public static JavaArchive createTestArchive() {
return ShrinkWrap
.create(JavaArchive.class, "test.jar")
.addClasses(LowercaseConverter.class)
.addAsManifestResource(EmptyAsset.INSTANCE,
ArchivePaths.create("beans.xml"));
}
@Test
public void testConvertToLowercase() {
Assert.assertEquals("martin",
lowercaseConverter.convertToLowercase("Martin"));
}
}
{code}
However, if @ArquillianResource is used for a field injection, such as:
{code}
@ArquillianResource URL field;
{code}
than test body is no longer executed and *all tests are reported as passed* even an
obvious failure like:
{code}
@Test
public void testConvertToLowercase() {
Assert.fail();
Assert.assertEquals("karel",
lowercaseConverter.convertToLowercase("Martin"));
}
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:17 a.m.
New subject: [JBoss JIRA] (ARQ-563) @ArquillianResource in TestNG based tests causes test body not to be evaluated
[
https://issues.jboss.org/browse/ARQ-563?page=com.atlassian.jira.plugin.sy...
]
Aslak Knutsen closed ARQ-563.
-----------------------------
@ArquillianResource in TestNG based tests causes test body not to be
evaluated
------------------------------------------------------------------------------
Key: ARQ-563
URL: https://issues.jboss.org/browse/ARQ-563
Project: Arquillian
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Test Protocol SPIs and Implementation
Affects Versions: 1.0.0.CR4
Environment: Surefire 2.7.2, 2.9
TestNG 5.14.6, 5.14.9
AS 7.0.1 web
Reporter: Karel Piwko
Priority: Blocker
Fix For: 1.0.3.Final
Suppose following test case:
{code}
public class LowercaseConverterTest extends Arquillian {
@Inject
private LowercaseConverter lowercaseConverter;
@Deployment
public static JavaArchive createTestArchive() {
return ShrinkWrap
.create(JavaArchive.class, "test.jar")
.addClasses(LowercaseConverter.class)
.addAsManifestResource(EmptyAsset.INSTANCE,
ArchivePaths.create("beans.xml"));
}
@Test
public void testConvertToLowercase() {
Assert.assertEquals("martin",
lowercaseConverter.convertToLowercase("Martin"));
}
}
{code}
However, if @ArquillianResource is used for a field injection, such as:
{code}
@ArquillianResource URL field;
{code}
than test body is no longer executed and *all tests are reported as passed* even an
obvious failure like:
{code}
@Test
public void testConvertToLowercase() {
Assert.fail();
Assert.assertEquals("karel",
lowercaseConverter.convertToLowercase("Martin"));
}
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
4453
days inactive
4872
days old
arquillian-issues@lists.jboss.org
17 comments
10 participants
participants (10)
-
Andrew Rubinger (JIRA) -
Aslak Knutsen (JIRA)
-
Brian Reilly (JIRA)
-
Daniel Miklancic (Commented) (JIRA)
-
Hanspeter Gisler (Commented) (JIRA)
-
Hanspeter Gisler (Issue Comment Edited) (JIRA)
-
Karel Piwko (JIRA)
-
Kristoffer Richardsson (JIRA)
-
Martin Kouba (JIRA)
-
SBS JIRA Integration (Updated) (JIRA)