2 a.m.
Rethink WebDriver browser configuration
---------------------------------------
Key: ARQ-666
URL: https://issues.jboss.org/browse/ARQ-666
Project: Arquillian
Issue Type: Enhancement
Security Level: Public (Everyone can see)
Components: Extension - Drone
Affects Versions: drone_1.0.0.CR2
Reporter: Karel Piwko
Priority: Critical
Fix For: drone_1.0.0.Final
Current binding of browser type to the type defined in the class itself limits the usage
of generic WebDriver drivers.
This means that you can simply change WebDriver type by configuration, you have to modify
Java code. The usage should be modified to implementationClass be the property which
decides what instance will be used even for generic webdrivers.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:52 a.m.
New subject: [JBoss JIRA] (ARQ-666) Redesign WebDriver browser configuration
[
https://issues.jboss.org/browse/ARQ-666?page=com.atlassian.jira.plugin.sy...
]
Karel Piwko updated ARQ-666:
----------------------------
Summary: Redesign WebDriver browser configuration (was: Rethink WebDriver browser
configuration)
Redesign WebDriver browser configuration
----------------------------------------
Key: ARQ-666
URL: https://issues.jboss.org/browse/ARQ-666
Project: Arquillian
Issue Type: Enhancement
Security Level: Public(Everyone can see)
Components: Extension - Drone
Affects Versions: drone_1.0.0.CR2
Reporter: Karel Piwko
Priority: Critical
Fix For: drone_1.0.0.Final
Current binding of browser type to the type defined in the class itself limits the usage
of generic WebDriver drivers.
This means that you can simply change WebDriver type by configuration, you have to modify
Java code. The usage should be modified to implementationClass be the property which
decides what instance will be used even for generic webdrivers.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:31 a.m.
New subject: [JBoss JIRA] (ARQ-666) Redesign WebDriver browser configuration
[
https://issues.jboss.org/browse/ARQ-666?page=com.atlassian.jira.plugin.sy...
]
Karel Piwko commented on ARQ-666:
---------------------------------
We have two constraints here:
* We need to be able to switch between different WebDriver impls using arquillian.xml
only
* We need to know that some property is not valid for certain type of the browser
My idea here is to have a single backing class which will allow user to define all the
properties and restrict that via a list of interfaces which corresponds to a specific
drivers.
This means that:
User can specify anything he wants for <extension qualifier="webdriver">
And than use @Drone WebDriver driver; to get the instance specified by
implementationClass.
On the other way, if he says @Drone FirefoxDriver, the list of available system properties
will be restricted (e.g. a warning will be logged that is have no effect on the current
browser type)
Redesign WebDriver browser configuration
----------------------------------------
Key: ARQ-666
URL: https://issues.jboss.org/browse/ARQ-666
Project: Arquillian
Issue Type: Enhancement
Security Level: Public(Everyone can see)
Components: Extension - Drone
Affects Versions: drone_1.0.0.CR2
Reporter: Karel Piwko
Priority: Critical
Fix For: drone_1.0.0.Final
Current binding of browser type to the type defined in the class itself limits the usage
of generic WebDriver drivers.
This means that you can simply change WebDriver type by configuration, you have to modify
Java code. The usage should be modified to implementationClass be the property which
decides what instance will be used even for generic webdrivers.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:33 p.m.
New subject: [JBoss JIRA] (ARQ-666) Redesign WebDriver browser configuration
[
https://issues.jboss.org/browse/ARQ-666?page=com.atlassian.jira.plugin.sy...
]
Karel Piwko commented on ARQ-666:
---------------------------------
Pushed into https://github.com/kpiwko/arquillian-extension-drone/tree/ARQ-666, waiting for
feedback.
Redesign WebDriver browser configuration
----------------------------------------
Key: ARQ-666
URL: https://issues.jboss.org/browse/ARQ-666
Project: Arquillian
Issue Type: Enhancement
Security Level: Public(Everyone can see)
Components: Extension - Drone
Affects Versions: drone_1.0.0.CR2
Reporter: Karel Piwko
Priority: Critical
Fix For: drone_1.0.0.Final
Current binding of browser type to the type defined in the class itself limits the usage
of generic WebDriver drivers.
This means that you can simply change WebDriver type by configuration, you have to modify
Java code. The usage should be modified to implementationClass be the property which
decides what instance will be used even for generic webdrivers.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:40 p.m.
New subject: [JBoss JIRA] (ARQ-666) Redesign WebDriver browser configuration
[
https://issues.jboss.org/browse/ARQ-666?page=com.atlassian.jira.plugin.sy...
]
Karel Piwko commented on ARQ-666:
---------------------------------
Implementation note:
No warning are issue. Configuration is hidden from tests, so user will see no warnings
based on implementationClass value. This leads to following situation:
{code}
@Drone HtmlUnitDriver driver;
{code}
{code:xml}
<property name="implementationClass">...FirefoxDriver</property>
{code}
This will use HtmlUnitDriverFactory to get instance of FirefoxDriver. This is incorrect
and will fail (because HtmlUnitDriverFactory has specific instantiation). Following must
be specified in order to pass, however than implementation specific details are no
triggered, e.g. no ChromeSwitches will be executed.
{code}
@Drone WebDriver driver;
{code}
Is that generic approach enough?
Redesign WebDriver browser configuration
----------------------------------------
Key: ARQ-666
URL: https://issues.jboss.org/browse/ARQ-666
Project: Arquillian
Issue Type: Enhancement
Security Level: Public(Everyone can see)
Components: Extension - Drone
Affects Versions: drone_1.0.0.CR2
Reporter: Karel Piwko
Priority: Critical
Fix For: drone_1.0.0.Final
Current binding of browser type to the type defined in the class itself limits the usage
of generic WebDriver drivers.
This means that you can simply change WebDriver type by configuration, you have to modify
Java code. The usage should be modified to implementationClass be the property which
decides what instance will be used even for generic webdrivers.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:21 a.m.
New subject: [JBoss JIRA] (ARQ-666) Redesign WebDriver browser configuration
[
https://issues.jboss.org/browse/ARQ-666?page=com.atlassian.jira.plugin.sy...
]
Lukáš Fryč commented on ARQ-666:
--------------------------------
Hi Karel, this seems correct to me.
Since the assignment will fail, the user will be simply able to recognize whats the real
issue.
Redesign WebDriver browser configuration
----------------------------------------
Key: ARQ-666
URL: https://issues.jboss.org/browse/ARQ-666
Project: Arquillian
Issue Type: Enhancement
Security Level: Public(Everyone can see)
Components: Extension - Drone
Affects Versions: drone_1.0.0.CR2
Reporter: Karel Piwko
Priority: Critical
Fix For: drone_1.0.0.Final
Current binding of browser type to the type defined in the class itself limits the usage
of generic WebDriver drivers.
This means that you can simply change WebDriver type by configuration, you have to modify
Java code. The usage should be modified to implementationClass be the property which
decides what instance will be used even for generic webdrivers.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:52 a.m.
New subject: [JBoss JIRA] (ARQ-666) Redesign WebDriver browser configuration
[
https://issues.jboss.org/browse/ARQ-666?page=com.atlassian.jira.plugin.sy...
]
Karel Piwko commented on ARQ-666:
---------------------------------
I've updated WebDriver specific behavior to chain to given factories.
E.g.
{code}
@Drone WebDriver driver;
{code:xml}
<property name="implementationClass">...FirefoxDriver</property>
<property name="firefoxBinary">/path/to/binary</property>
{code}
This will now check if there is a factory for implementationClass instead calling generic
stuff in WebDriverFactory. So firefoxBinary property will be used even if you requested
WebDriver class.
Redesign WebDriver browser configuration
----------------------------------------
Key: ARQ-666
URL: https://issues.jboss.org/browse/ARQ-666
Project: Arquillian
Issue Type: Enhancement
Security Level: Public(Everyone can see)
Components: Extension - Drone
Affects Versions: drone_1.0.0.CR2
Reporter: Karel Piwko
Priority: Critical
Fix For: drone_1.0.0.Final
Current binding of browser type to the type defined in the class itself limits the usage
of generic WebDriver drivers.
This means that you can simply change WebDriver type by configuration, you have to modify
Java code. The usage should be modified to implementationClass be the property which
decides what instance will be used even for generic webdrivers.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:52 a.m.
New subject: [JBoss JIRA] (ARQ-666) Redesign WebDriver browser configuration
[
https://issues.jboss.org/browse/ARQ-666?page=com.atlassian.jira.plugin.sy...
]
Karel Piwko edited comment on ARQ-666 at 11/29/11 7:51 AM:
-----------------------------------------------------------
I've updated WebDriver specific behavior to chain to given factories.
E.g.
{code}
@Drone WebDriver driver;
{code}
{code:xml}
<property name="implementationClass">...FirefoxDriver</property>
<property name="firefoxBinary">/path/to/binary</property>
{code}
This will now check if there is a factory for implementationClass instead calling generic
stuff in WebDriverFactory. So `firefoxBinary` property will be used even if you requested
WebDriver class because you specified `FirefoxDriver` in arquillian.xml.
was (Author: kpiwko):
I've updated WebDriver specific behavior to chain to given factories.
E.g.
{code}
@Drone WebDriver driver;
{code:xml}
<property name="implementationClass">...FirefoxDriver</property>
<property name="firefoxBinary">/path/to/binary</property>
{code}
This will now check if there is a factory for implementationClass instead calling generic
stuff in WebDriverFactory. So firefoxBinary property will be used even if you requested
WebDriver class.
Redesign WebDriver browser configuration
----------------------------------------
Key: ARQ-666
URL: https://issues.jboss.org/browse/ARQ-666
Project: Arquillian
Issue Type: Enhancement
Security Level: Public(Everyone can see)
Components: Extension - Drone
Affects Versions: drone_1.0.0.CR2
Reporter: Karel Piwko
Priority: Critical
Fix For: drone_1.0.0.Final
Current binding of browser type to the type defined in the class itself limits the usage
of generic WebDriver drivers.
This means that you can simply change WebDriver type by configuration, you have to modify
Java code. The usage should be modified to implementationClass be the property which
decides what instance will be used even for generic webdrivers.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:15 a.m.
New subject: [JBoss JIRA] (ARQ-666) Redesign WebDriver browser configuration
[
https://issues.jboss.org/browse/ARQ-666?page=com.atlassian.jira.plugin.sy...
]
Karel Piwko resolved ARQ-666.
-----------------------------
Assignee: Karel Piwko
Resolution: Done
Pushed upstream in
https://github.com/arquillian/arquillian-extension-drone/commit/492495153...
Redesign WebDriver browser configuration
----------------------------------------
Key: ARQ-666
URL: https://issues.jboss.org/browse/ARQ-666
Project: Arquillian
Issue Type: Enhancement
Security Level: Public(Everyone can see)
Components: Extension - Drone
Affects Versions: drone_1.0.0.CR2
Reporter: Karel Piwko
Assignee: Karel Piwko
Priority: Critical
Fix For: drone_1.0.0.Final
Current binding of browser type to the type defined in the class itself limits the usage
of generic WebDriver drivers.
This means that you can simply change WebDriver type by configuration, you have to modify
Java code. The usage should be modified to implementationClass be the property which
decides what instance will be used even for generic webdrivers.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:46 a.m.
New subject: [JBoss JIRA] (ARQ-666) Redesign WebDriver browser configuration
[
https://issues.jboss.org/browse/ARQ-666?page=com.atlassian.jira.plugin.sy...
]
Aslak Knutsen updated ARQ-666:
------------------------------
Fix Version/s: drone_1.0.0.CR3
(was: drone_1.0.0.Final)
Redesign WebDriver browser configuration
----------------------------------------
Key: ARQ-666
URL: https://issues.jboss.org/browse/ARQ-666
Project: Arquillian
Issue Type: Enhancement
Security Level: Public(Everyone can see)
Components: Extension - Drone
Affects Versions: drone_1.0.0.CR2
Reporter: Karel Piwko
Assignee: Karel Piwko
Priority: Critical
Fix For: drone_1.0.0.CR3
Current binding of browser type to the type defined in the class itself limits the usage
of generic WebDriver drivers.
This means that you can simply change WebDriver type by configuration, you have to modify
Java code. The usage should be modified to implementationClass be the property which
decides what instance will be used even for generic webdrivers.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:37 p.m.
New subject: [JBoss JIRA] (ARQ-666) Redesign WebDriver browser configuration
[
https://issues.jboss.org/browse/ARQ-666?page=com.atlassian.jira.plugin.sy...
]
Aslak Knutsen closed ARQ-666.
-----------------------------
Redesign WebDriver browser configuration
----------------------------------------
Key: ARQ-666
URL: https://issues.jboss.org/browse/ARQ-666
Project: Arquillian
Issue Type: Enhancement
Security Level: Public(Everyone can see)
Components: Extension - Drone
Affects Versions: drone_1.0.0.CR2
Reporter: Karel Piwko
Assignee: Karel Piwko
Priority: Critical
Fix For: drone_1.0.0.CR3
Current binding of browser type to the type defined in the class itself limits the usage
of generic WebDriver drivers.
This means that you can simply change WebDriver type by configuration, you have to modify
Java code. The usage should be modified to implementationClass be the property which
decides what instance will be used even for generic webdrivers.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
4688
days inactive
4689
days old
arquillian-issues@lists.jboss.org
10 comments
8 participants
participants (8)
-
Aslak Knutsen (Closed) (JIRA) -
Aslak Knutsen (Updated) (JIRA)
-
Karel Piwko (Commented) (JIRA)
-
Karel Piwko (Created) (JIRA)
-
Karel Piwko (Issue Comment Edited) (JIRA)
-
Karel Piwko (Resolved) (JIRA)
-
Karel Piwko (Updated) (JIRA)
-
Lukáš Fryč (Commented) (JIRA)