[JBoss JIRA] (ARQ-796) Remove the GlassFishRestDeploymentAppender from the GlassFish container adapter
12:33 p.m.
Vineet Reynolds created ARQ-796:
-----------------------------------
Summary: Remove the GlassFishRestDeploymentAppender from the GlassFish
container adapter
Key: ARQ-796
URL: https://issues.jboss.org/browse/ARQ-796
Project: Arquillian
Issue Type: Enhancement
Security Level: Public (Everyone can see)
Components: GlassFish Containers
Reporter: Vineet Reynolds
Priority: Minor
The GlassFishRestDeploymentAppender does not appear to serve any purpose. Although it is
implemented as an auxiliary archive appender, it does not appear to be used to enhance the
deployment archive. It assumes the responsibility of enhancing the archive with
TestEnrichers, but this is already done by the TestEnricher extensions themselves.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:49 p.m.
[
https://issues.jboss.org/browse/ARQ-796?page=com.atlassian.jira.plugin.sy...
]
Aslak Knutsen commented on ARQ-796:
-----------------------------------
It is not registered in the Container Extension itself, so it's not in use.
Old SPI file should be removed as well
https://github.com/arquillian/arquillian-container-glassfish/blob/master/...
Remove the GlassFishRestDeploymentAppender from the GlassFish
container adapter
-------------------------------------------------------------------------------
Key: ARQ-796
URL: https://issues.jboss.org/browse/ARQ-796
Project: Arquillian
Issue Type: Enhancement
Security Level: Public(Everyone can see)
Components: GlassFish Containers
Reporter: Vineet Reynolds
Priority: Minor
The GlassFishRestDeploymentAppender does not appear to serve any purpose. Although it is
implemented as an auxiliary archive appender, it does not appear to be used to enhance the
deployment archive. It assumes the responsibility of enhancing the archive with
TestEnrichers, but this is already done by the TestEnricher extensions themselves.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:54 a.m.
[
https://issues.jboss.org/browse/ARQ-796?page=com.atlassian.jira.plugin.sy...
]
Vineet Reynolds reassigned ARQ-796:
-----------------------------------
Assignee: Vineet Reynolds
Remove the GlassFishRestDeploymentAppender from the GlassFish
container adapter
-------------------------------------------------------------------------------
Key: ARQ-796
URL: https://issues.jboss.org/browse/ARQ-796
Project: Arquillian
Issue Type: Enhancement
Security Level: Public(Everyone can see)
Components: GlassFish Containers
Reporter: Vineet Reynolds
Assignee: Vineet Reynolds
Priority: Minor
The GlassFishRestDeploymentAppender does not appear to serve any purpose. Although it is
implemented as an auxiliary archive appender, it does not appear to be used to enhance the
deployment archive. It assumes the responsibility of enhancing the archive with
TestEnrichers, but this is already done by the TestEnricher extensions themselves.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:01 p.m.
[
https://issues.jboss.org/browse/ARQ-796?page=com.atlassian.jira.plugin.sy...
]
Vineet Reynolds commented on ARQ-796:
-------------------------------------
Deleted the {{GlassFishRestDeploymentAppender}}.
Aslak, I've not deleted the older SPI file referenced in the comment - the
{{glassfish-embedded-3}} artifact is no longer built, since it is not registered as a
Maven module in the project. Would it be wise to delete the {{glassfish-embedded-3}} and
{{glassfish-remote-3}} directories, seeing that they're not built anymore ? I think we
should test the current adapter against GF 3.0 (we test against 3.1 currently) and then
proceed to delete the older unused ones.
NB - The modules built in CI currently are {{glassfish-managed-3.1}},
{[glassfish-remote-3.1}}, {{glassfish-embedded-3.1}} and {{glassfish-common}}.
Remove the GlassFishRestDeploymentAppender from the GlassFish
container adapter
-------------------------------------------------------------------------------
Key: ARQ-796
URL: https://issues.jboss.org/browse/ARQ-796
Project: Arquillian
Issue Type: Enhancement
Security Level: Public(Everyone can see)
Components: GlassFish Containers
Reporter: Vineet Reynolds
Assignee: Vineet Reynolds
Priority: Minor
The GlassFishRestDeploymentAppender does not appear to serve any purpose. Although it is
implemented as an auxiliary archive appender, it does not appear to be used to enhance the
deployment archive. It assumes the responsibility of enhancing the archive with
TestEnrichers, but this is already done by the TestEnricher extensions themselves.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:01 p.m.
[
https://issues.jboss.org/browse/ARQ-796?page=com.atlassian.jira.plugin.sy...
]
Vineet Reynolds edited comment on ARQ-796 at 11/17/12 1:00 PM:
---------------------------------------------------------------
Deleted the {{GlassFishRestDeploymentAppender}}.
Aslak, I've not deleted the older SPI file referenced in the comment - the
{{glassfish-embedded-3}} artifact is no longer built, since it is not registered as a
Maven module in the project. Would it be wise to delete the {{glassfish-embedded-3}} and
{{glassfish-remote-3}} directories, seeing that they're not built anymore ? I think we
should test the current adapter against GF 3.0 (we test against 3.1 currently) and then
proceed to delete the older unused ones.
NB - The modules built in CI currently are {{glassfish-managed-3.1}},
{{glassfish-remote-3.1}}, {{glassfish-embedded-3.1}} and {{glassfish-common}}.
was (Author: vineet.reynolds):
Deleted the {{GlassFishRestDeploymentAppender}}.
Aslak, I've not deleted the older SPI file referenced in the comment - the
{{glassfish-embedded-3}} artifact is no longer built, since it is not registered as a
Maven module in the project. Would it be wise to delete the {{glassfish-embedded-3}} and
{{glassfish-remote-3}} directories, seeing that they're not built anymore ? I think we
should test the current adapter against GF 3.0 (we test against 3.1 currently) and then
proceed to delete the older unused ones.
NB - The modules built in CI currently are {{glassfish-managed-3.1}},
{[glassfish-remote-3.1}}, {{glassfish-embedded-3.1}} and {{glassfish-common}}.
Remove the GlassFishRestDeploymentAppender from the GlassFish
container adapter
-------------------------------------------------------------------------------
Key: ARQ-796
URL: https://issues.jboss.org/browse/ARQ-796
Project: Arquillian
Issue Type: Enhancement
Security Level: Public(Everyone can see)
Components: GlassFish Containers
Reporter: Vineet Reynolds
Assignee: Vineet Reynolds
Priority: Minor
The GlassFishRestDeploymentAppender does not appear to serve any purpose. Although it is
implemented as an auxiliary archive appender, it does not appear to be used to enhance the
deployment archive. It assumes the responsibility of enhancing the archive with
TestEnrichers, but this is already done by the TestEnricher extensions themselves.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:56 p.m.
[
https://issues.jboss.org/browse/ARQ-796?page=com.atlassian.jira.plugin.sy...
]
Vineet Reynolds commented on ARQ-796:
-------------------------------------
Deciding to not remove the complete GF 3.0 related sources as they may be worked upon in
the future. When implementing ARQ-1213 the GF 3.0 adapter will be restructured and cleaned
up. Closing this issue for now.
Remove the GlassFishRestDeploymentAppender from the GlassFish
container adapter
-------------------------------------------------------------------------------
Key: ARQ-796
URL: https://issues.jboss.org/browse/ARQ-796
Project: Arquillian
Issue Type: Enhancement
Security Level: Public(Everyone can see)
Components: GlassFish Containers
Reporter: Vineet Reynolds
Assignee: Vineet Reynolds
Priority: Minor
The GlassFishRestDeploymentAppender does not appear to serve any purpose. Although it is
implemented as an auxiliary archive appender, it does not appear to be used to enhance the
deployment archive. It assumes the responsibility of enhancing the archive with
TestEnrichers, but this is already done by the TestEnricher extensions themselves.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:56 p.m.
[
https://issues.jboss.org/browse/ARQ-796?page=com.atlassian.jira.plugin.sy...
]
Vineet Reynolds resolved ARQ-796.
---------------------------------
Resolution: Done
Remove the GlassFishRestDeploymentAppender from the GlassFish
container adapter
-------------------------------------------------------------------------------
Key: ARQ-796
URL: https://issues.jboss.org/browse/ARQ-796
Project: Arquillian
Issue Type: Enhancement
Security Level: Public(Everyone can see)
Components: GlassFish Containers
Reporter: Vineet Reynolds
Assignee: Vineet Reynolds
Priority: Minor
The GlassFishRestDeploymentAppender does not appear to serve any purpose. Although it is
implemented as an auxiliary archive appender, it does not appear to be used to enhance the
deployment archive. It assumes the responsibility of enhancing the archive with
TestEnrichers, but this is already done by the TestEnricher extensions themselves.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
4420
days inactive
4680
days old
arquillian-issues@lists.jboss.org
6 comments
2 participants
participants (2)
-
Aslak Knutsen (JIRA) -
Vineet Reynolds (JIRA)