April 2009 - hibernate-issues - Jboss List Archives

[Hibernate-JIRA] Created: (HHH-2668) Caching Fails with Composite-Ids Containing Nested, Complex Entities

by Juan Osuna (JIRA)

Caching Fails with Composite-Ids Containing Nested, Complex Entities -------------------------------------------------------------------- Key: HHH-2668 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2668 Project: Hibernate3 Issue Type: Bug Components: caching (L2) Affects Versions: 3.2.4.sp1 Environment: Problem is independent of environment or platform and most likely exists in prior versions. Reporter: Juan Osuna Attachments: hibernate-caching-fix.zip Description of Failing Test Case Scenario Preconditions: An entity class is mapped that uses a composite-id that contains a nested entity class. Only the composite-id class implements equals/hashcode, not the nested entity class. Steps to Reproduce: 1. open session and fetch object using composite-id 2. open new session and fetch same object again using different instance of composite-id but with same identity Invalid Postconditions: On second retrieve, Hibernate fails to get the object from the cache and unnecessarily reloads the object. CachKeys containing different instances of the composite-id always fail to be equal even though they have the same persistent identity. Attachment Contents Code fix is attached as well as a Junit test case that reproduces the problem and validates the fix. The full Hibernate suite was also executed with no impact. Attachment contains: New Test Method: org.hibernate.test.cache.BaseCacheProviderTestCase.testQueryCacheComplexItem New Test Entity Items: org\hibernate\test\cache\ComplexItem.hbm.xml org.hibernate.test.cache.ComplexItem org.hibernate.test.cache.ComplexItemPK Code Fix: org.hibernate.cache.CacheKey (see FIX comments) Problem and Fix Details Hibernate generally strives to use persistent identifiers for managing object identity rather than the equals/hashcode methods implemented by entity classes. While it is good practice to implement equals/hashcode, Hibernate does not generally force users to do this. When wrapping a composite-id object, the current implementation of CacheKey fails to recurse through nested complex entities to query for equality based on persistent identity. Instead, when the recursion algorithm hits a complex entity, it invokes equals directly on that entity rather than further recursing through the identifier object. Notably, the recursion logic for equals is not symmetrical with the recursion logic for hashcode, which does recurse through identifier objects. So, while CacheKey never invokes hashcode on nested complex entities, it does invoke equals on these entities. A simple fix to this inconsistency is to store the factory parameter passed to CacheKey and later pass that parameter to the overloaded method: Type.isEqual(Object x, Object y, EntityMode entityMode, SessionFactoryImplementor factory). This fix restores symmetry to equals and hashcode behavior. By calling this overloaded method, the thread of execution will enter EntityType. isEqual(Object x, Object y, EntityMode entityMode, SessionFactoryImplementor factory), which correctly recurses through complex identifiers. Design Principles Hibernate should strive to behave predictably even in scenarios where users do not follow best practices. Hibernate should strive to be as forgiving as possible as long there is no negative consequence caused by such forgiveness. Hibernate should behave as consistently as possible. If Hibernate does not generally rely user-implemented equals/hashcode, it is best to avoid exceptions to this rule wherever possible. Possible Future Enhancement Mapping composite-ids that contain complex entities can cause deep object graphs to be cached as part of CacheKey. This is unsettling because of it's potential to consume memory unnecessarily and unpredictably. Currently, CacheKey caches the hashcode by recursing through a complex graph of identifier objects. Perhaps, it would also be possible for CacheKey to cache an object graph of identifier objects whose leaves hold primitive values. This would further add symmetry between hashcode and equals and lighten the load for caching composite-ids that hold entity classes. Robustly supporting composite-ids that hold complex identifiers seems like a worthwhile design goal. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

14 years, 10 months

6
8
0 / 0

[Hibernate-JIRA] Created: (HHH-2047) make Query and Criteria extend java.lang.Iterable

by Amir Pashazadeh (JIRA)

make Query and Criteria extend java.lang.Iterable ------------------------------------------------- Key: HHH-2047 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2047 Project: Hibernate3 Type: Improvement Components: core Versions: 3.2.0.cr2 Reporter: Amir Pashazadeh Priority: Trivial Objects which implement java.lang.Iterable can be iterated using extended for loop. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

14 years, 10 months

2
2
0 / 0

[Hibernate-JIRA] Created: (ANN-407) <synchronize table="table_name"/> is missed using annotations

by Amir Pashazadeh (JIRA)

<synchronize table="table_name"/> is missed using annotations -------------------------------------------------------------- Key: ANN-407 URL: http://opensource.atlassian.com/projects/hibernate/browse/ANN-407 Project: Hibernate Annotations Type: Patch Components: binder Versions: 3.2.0.cr1 Reporter: Amir Pashazadeh in old .hbm.xml notation there was a possibility to set a synchronize for caches on particular tables, and I could not find such thing using annotations, is it possible to set "synchronize" tables using annotations? and if not will it be added to 3.2? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

14 years, 10 months

3
3
0 / 0

[Hibernate-JIRA] Created: (HHH-3720) Method getSession(EntityMode) on child session does not return value provided by root session

by Michael Bezoyan (JIRA)

Method getSession(EntityMode) on child session does not return value provided by root session --------------------------------------------------------------------------------------------- Key: HHH-3720 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3720 Project: Hibernate Core Issue Type: Bug Components: core Affects Versions: 3.3.1 Reporter: Michael Bezoyan Priority: Critical Current code at line 251 in class org.hibernate.impl.SessionImpl public Session getSession(EntityMode entityMode) { if ( this.entityMode == entityMode ) { return this; } if ( rootSession != null ) { rootSession.getSession( entityMode ); } Should be: public Session getSession(EntityMode entityMode) { if ( this.entityMode == entityMode ) { return this; } if ( rootSession != null ) { return rootSession.getSession( entityMode ); } -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

14 years, 10 months

3
2
0 / 0

[Hibernate-JIRA] Created: (HHH-3817) JBC second level cache integration can cache collection data

by Brian Stansberry (JIRA)

JBC second level cache integration can cache collection data ------------------------------------------------------------ Key: HHH-3817 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3817 Project: Hibernate Core Issue Type: Bug Components: caching (L2) Reporter: Brian Stansberry Assignee: Brian Stansberry Fix For: 3.3.x Scenario with two transactions dealing with a single collection: tx1 reads collection, cache miss tx1 goes to database to read collection tx2 reads collection, cache miss tx2 goes to database to read collection tx2 does JBC putForExternalRead to store empty collection tx2 updates collection tx2 removes collection from JBC (since any collection update triggers a org.hibernate.cache.Cache.evict which is implemented as a JBC removeNode) tx1 does JBC putForExternalRead to store empty collection -- STALE DATA With entities, if the db is using REPEATABLE_READ this won't be a problem, as the DB won't allow the tx2 update until tx1 commits. With a collection there is nothing to lock on. It would be a problem for entities with READ_COMMITTED as well. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

14 years, 10 months

2
7
0 / 0

[Hibernate-JIRA] Created: (ANN-660) HHH-2545 Alive

by Eugene Batogov (JIRA)

HHH-2545 Alive -------------- Key: ANN-660 URL: http://opensource.atlassian.com/projects/hibernate/browse/ANN-660 Project: Hibernate Annotations Issue Type: Bug Affects Versions: 3.3.0.ga Environment: Gentoo Linux x86 JDK: 1.6. SUN and BEA JBoss-4.2.1.GA Hibernate: 3.2.5 Annotation: 3.3.0.GA EntityManager: 3.3.1 Reporter: Eugene Batogov Priority: Critical I have a same problem how in HHH-2545 bug ! I update Hibernate to 3.2.5, hibernate-annotation to 3.3.0.GA hibernate-entitymanager to 3.3.1.GA. But this bug alive! I use ehcache-1.3.0. jBoss-4.2.1.GA. My query, which get from cache with null elements in collections: Long customerAccount = customerIdentity.getCustomerAccount().getId(); try{ String sql = "select npvr.npvrChannels from NpvrServiceSpec npvr"+ " where npvr.id in ("+ " select ss.id from Customer cust join cust.accounts acc join cust.subscriptions sub"+ " join sub.serviceSpecifications ss"+ " where acc.id =:customerAccount and"+ " ss in (from NpvrServiceSpec))"; Query query = emanager.createQuery(sql); query.setParameter("customerAccount", customerAccount); query.setHint("org.hibernate.cacheRegion", "query.findQueryNpvrChannelsBySubsription"); query.setHint("org.hibernate.cacheable", true); result = query.getResultList(); Help me, please ! Thanks in advance. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

14 years, 10 months

5
12
0 / 0

[Hibernate-JIRA] Created: (HSEARCH-53) Add support for projection (ie read the data from the index only)

by Emmanuel Bernard (JIRA)

Add support for projection (ie read the data from the index only) ----------------------------------------------------------------- Key: HSEARCH-53 URL: http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-53 Project: Hibernate Search Issue Type: New Feature Components: query Reporter: Emmanuel Bernard Assignee: Emmanuel Bernard Fix For: 3.0.0.beta2 -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

14 years, 10 months

2
2
0 / 0

[Hibernate-JIRA] Created: (HV-66) 3.1.0.CR1 incompatible with Hibernate 3.3.0

by Juergen Zimmermann (JIRA)

3.1.0.CR1 incompatible with Hibernate 3.3.0 ------------------------------------------- Key: HV-66 URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-66 Project: Hibernate Validator Issue Type: Bug Affects Versions: 3.1.0.CR1 Environment: Hibernate 3.3.0, Hibernate Common Annotations 3.1.0.CR2, Hibernate Annotations 3.4.0.CR2, Hibernate EntityManager 3.4.0.CR2, Javassist, 3.8.1, CGLib 2.2, EHCache 1.5.0, SLF4J 1.5.2, JDK 1.6.0_07 Reporter: Juergen Zimmermann I'm getting this stacktrace after upgrading from Hibernate 3.3.0.CR2 to 3.3.0: java.lang.NoSuchMethodError: org.hibernate.event.PreUpdateEvent.getSource()Lorg/hibernate/engine/SessionImplementor; at org.hibernate.validator.event.ValidateEventListener.onPreUpdate(ValidateEventListener.java:177) at org.hibernate.action.EntityUpdateAction.preUpdate(EntityUpdateAction.java:237) at org.hibernate.action.EntityUpdateAction.execute(EntityUpdateAction.java:88) at org.hibernate.engine.ActionQueue.execute(ActionQueue.java:279) at org.hibernate.engine.ActionQueue.executeActions(ActionQueue.java:263) at org.hibernate.engine.ActionQueue.executeActions(ActionQueue.java:168) at org.hibernate.event.def.AbstractFlushingEventListener.performExecutions(AbstractFlushingEventListener.java:321) at org.hibernate.event.def.DefaultAutoFlushEventListener.onAutoFlush(DefaultAutoFlushEventListener.java:64) at org.hibernate.impl.SessionImpl.autoFlushIfRequired(SessionImpl.java:996) at org.hibernate.impl.SessionImpl.list(SessionImpl.java:1141) at org.hibernate.impl.QueryImpl.list(QueryImpl.java:102) at org.hibernate.ejb.QueryImpl.getResultList(QueryImpl.java:65) at de.hska.kundenverwaltung.db.KundenverwaltungDaoImpl.findKundenByNachname(KundenverwaltungDaoImpl.java:67) at de.hska.kundenverwaltung.KundenverwaltungImpl.updateKunde(KundenverwaltungImpl.java:392) at de.hska.kundenverwaltung.rest.KundenverwaltungResource.updateKunde(KundenverwaltungResource.java:194) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at com.sun.jersey.impl.model.method.dispatch.EntityParamDispatchProvider$TypeOutInvoker._dispatch(EntityParamDispatchProvider.java:132) at com.sun.jersey.impl.model.method.dispatch.ResourceJavaMethodDispatcher.dispatch(ResourceJavaMethodDispatcher.java:81) at com.sun.jersey.impl.uri.rules.HttpMethodRule.accept(HttpMethodRule.java:133) at com.sun.jersey.impl.uri.rules.RightHandPathRule.accept(RightHandPathRule.java:111) at com.sun.jersey.impl.uri.rules.ResourceClassRule.accept(ResourceClassRule.java:71) at com.sun.jersey.impl.uri.rules.RightHandPathRule.accept(RightHandPathRule.java:111) at com.sun.jersey.impl.uri.rules.RootResourceClassesRule.accept(RootResourceClassesRule.java:64) at com.sun.jersey.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:680) at com.sun.jersey.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:650) at com.sun.jersey.spi.container.servlet.ServletContainer.service(ServletContainer.java:309) at javax.servlet.http.HttpServlet.service(HttpServlet.java:717) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:290) at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206) at de.hska.util.HskaFilter.doFilter(HskaFilter.java:46) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235) at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206) at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:233) at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:191) at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:128) at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:102) at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109) at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:286) at org.apache.coyote.http11.Http11AprProcessor.process(Http11AprProcessor.java:857) at org.apache.coyote.http11.Http11AprProtocol$Http11ConnectionHandler.process(Http11AprProtocol.java:565) at org.apache.tomcat.util.net.AprEndpoint$Worker.run(AprEndpoint.java:1509) at java.lang.Thread.run(Thread.java:619) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

14 years, 10 months

8
20
0 / 0

[Hibernate-JIRA] Created: (HHH-2928) optimizers for enhanced id generators should be synchronized against multi-threaded access

by Steve Ebersole (JIRA)

optimizers for enhanced id generators should be synchronized against multi-threaded access ------------------------------------------------------------------------------------------ Key: HHH-2928 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2928 Project: Hibernate3 Issue Type: Bug Components: core Affects Versions: 3.2.5 Reporter: Steve Ebersole Assignee: Steve Ebersole Fix For: 3.2.6 Currently the optimizers do not serialize access to their internal state when applying their optimizations. This only affects the pooled and hilo optimizers. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

14 years, 10 months

4
12
0 / 0

[Hibernate-JIRA] Created: (HHH-3739) Problem using BTMTransactionManagerLookup with Tomcat

by Helder Sousa (JIRA)

Problem using BTMTransactionManagerLookup with Tomcat ----------------------------------------------------- Key: HHH-3739 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3739 Project: Hibernate Core Issue Type: Patch Components: core Affects Versions: 3.3.1 Environment: Hibernate 3.3.1 GA Reporter: Helder Sousa Attachments: BTMTransactionManagerLookup.patch Hi. When using Bitronix Transaction Manager with tomcat there is a problem resolving the TransactionManager by JNDI. Please take a look to this thread: http://www.nabble.com/Hibernate-JTATransactionFactory-and-BTMTransactionM... In 5th post, Ludovic wrote: "The UserTransaction name is java:comp/UserTransaction and when a JNDI lookup happens in Tomcat, the Tomcat provider takes precedence because Tomcat registered a java: namespace handler." So, when using BTM in Tomcat, the BTM users should configure in BTM Configuration a JNDI name that does not start with java:comp and the BTMTransactionManagerLookup class should read this configuration: Here is the change to the BTMTransactionManagerLookup class (I attached the patch): public String getUserTransactionName() { try { Class transactionManagerServiceClass = Class.forName("bitronix.tm.TransactionManagerServices"); Method getConfigurationMethod = transactionManagerServiceClass.getMethod("getConfiguration", null); Object configurationInstance = getConfigurationMethod.invoke(null, null); Class bitronixConfigurationClass = configurationInstance.getClass(); Method getJndiUserTransactionNameMethod = bitronixConfigurationClass .getMethod("getJndiUserTransactionName", null); String configuredJndiUserTransactionName = (String) getJndiUserTransactionNameMethod.invoke( configurationInstance, null); if (configuredJndiUserTransactionName != null && configuredJndiUserTransactionName.trim().length() >= 0) { return configuredJndiUserTransactionName; } return "java:comp/UserTransaction"; } catch (Exception e) { throw new HibernateException("Could not obtain BTM UserTransactionName", e); } } Can you apply the patch? Best regards, Helder Sousa -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

14 years, 10 months

3
2
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

hibernate-issues April 2009