March 2020 - hibernate-issues - Jboss List Archives

[JIRA] (HSEARCH-3325) Search 6 groundwork - Restore support for full-text filters

by Waldemar Kłaczyński (JIRA)

Waldemar Kłaczyński ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *commented* on HSEARCH-3325 ( https://hibernate.atlassian.net/browse/HSEARCH-3325?atlOrigin=eyJpIjoiMmM... ) Re: Search 6 groundwork - Restore support for full-text filters ( https://hibernate.atlassian.net/browse/HSEARCH-3325?atlOrigin=eyJpIjoiMmM... ) As for caching filters in version 5.x, it seems to me that this possibility should be in the predicate in the new version. .filter(f.cashe(otherFilter).mode(ceshe params...)) This solution gives you the flexibility to use such solutions. In this model, it makes no sense to combine predefined filters with caching. ( https://hibernate.atlassian.net/browse/HSEARCH-3325#add-comment?atlOrigin... ) Add Comment ( https://hibernate.atlassian.net/browse/HSEARCH-3325#add-comment?atlOrigin... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100122- sha1:87fe5bb )

4 years, 9 months

1
0
0 / 0

[JIRA] (HSEARCH-3848) Dynamic entities are ignored when creating a scope targeting Object.class

by Yoann Rodière (JIRA)

Yoann Rodière ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *updated* an issue Hibernate Search ( https://hibernate.atlassian.net/browse/HSEARCH?atlOrigin=eyJpIjoiZTZjY2Y5... ) / Bug ( https://hibernate.atlassian.net/browse/HSEARCH-3848?atlOrigin=eyJpIjoiZTZ... ) HSEARCH-3848 ( https://hibernate.atlassian.net/browse/HSEARCH-3848?atlOrigin=eyJpIjoiZTZ... ) Dynamic entities are ignored when creating a scope targeting Object.class ( https://hibernate.atlassian.net/browse/HSEARCH-3848?atlOrigin=eyJpIjoiZTZ... ) Change By: Yoann Rodière ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) Pull Request: https://github.com/hibernate/hibernate-search/pull/2247 Status: In Progress Pull Request Sent ( https://hibernate.atlassian.net/browse/HSEARCH-3848#add-comment?atlOrigin... ) Add Comment ( https://hibernate.atlassian.net/browse/HSEARCH-3848#add-comment?atlOrigin... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100122- sha1:87fe5bb )

4 years, 9 months

1
0
0 / 0

[JIRA] (HSEARCH-3325) Search 6 groundwork - Restore support for full-text filters

by Yoann Rodière (JIRA)

Yoann Rodière ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *commented* on HSEARCH-3325 ( https://hibernate.atlassian.net/browse/HSEARCH-3325?atlOrigin=eyJpIjoiODV... ) Re: Search 6 groundwork - Restore support for full-text filters ( https://hibernate.atlassian.net/browse/HSEARCH-3325?atlOrigin=eyJpIjoiODV... ) I can conceive that a feature that was present in Search 5 would still be useful in Search 6. However, the feature as you implemented it is not the same as the one that was present in Search 5: * In Search 5, filters were applied *after* the query was built, as some kind of "mask", which was useful in particular for aspect-oriented programming (and incidentally caused the query to be mutable, which is not something we want in 6). * In Search 5, there was no magic around the filter reference that would associate a filter to a single field ("prices.is-shared" contains both the field name and the filter name) * In Search 5, the value of filters arguments was defined exclusively when applying a filter, not when defining the filter using the @FullTextFilterDef annotation. * In Search 5, filters used to be cached, which doesn't seem useful in your case. * And so on. My point is, this is not the same feature as in Search 5. Thus, we can't just say "there was this feature in Search 5, we need to merge this patch". You're proposing essentially a new feature, or at least a heavily revamped feature, and I need to understand the use case. > > > > And whether it is useful for someone should be left to the end user > > True... let me put it another way: I need to know there is something you cannot achieve without this feature, or at least that would be complicated or time-consuming to achieve without this feature. I need to know there is value in this feature. Sometimes I can see it clearly, but here I need your help to understand. You have to understand that even when you provide the code of a new feature, there is a cost for the maintainers. First when merging it to make sure everything is well tested and documented, and fix the code where appropriate, and later to keep the feature in working order when we modify some code it uses. For the record, I spent more than one week, full-time, just testing, fixing and documenting your other PR about multi-valued sorts. That was time well spent, because I knew the feature is very useful. But still, that's a lot of time, and I cannot spend all my time on features without any idea of their value. > > > > It's about simplifying your queries > > Alright. Then I ask you, honestly: in what ways do you feel the code you gave is simpler than this, which doesn't require any additional API : private class BeansDataModel extends SearchDataModel<Assortment> { @Override public SearchQuery<Assortment> search(List<SortMeta> multiSortMeta, Map< String , Object > filters) { try { SearchSession session = Search.session(em); SearchScope<Assortment> scope = session.scope(Assortment.class); SearchSortFactory sorter = scope.sort(); CompositeSortComponentsStep sort = sorter.composite(); SearchPredicateFactory spf = scope.predicate(); BooleanPredicateClausesStep pricesFilter = spf.bool() .filter(isPriceActive(scope)) .filter(isPriceShared(scope, identity.getAccount())); sort.add(sorter.field( "prices.bruttoPrice_sort" ) .asc() .mode(MultiValue.MIN) .filter(pricesFilter)); for (SortMeta sortMeta : multiSortMeta) { String fieldName = sortMeta.getSortField(); switch (sortMeta.getSortOrder()) { case ASCENDING: sort.add(sorter.field(fieldName).asc()); break ; case DESCENDING: sort.add(sorter.field(fieldName).desc()); break ; } } PredicateFinalStep select; if (searchFullText != null ) { select = scope.predicate().simpleQueryString() .field( "shoppingName" ).boost(0.5f) .matching(searchFullText); } else { select = scope.predicate() .matchAll(); } SearchQuery<Assortment> query = session.search(scope) .where((f) -> f.bool().must(select) .filter(f.nested() .objectField( "prices" ) .nest(pricesFilter) )).sort(sort.toSort()).toQuery(); return query; } catch (Exception ex) { throw new IllegalStateException(ex); } } } private static SearchPredicate isPriceActive(SearchScope scope) { return PermissionsFilterFactory.create(scope, "prices" ); } private static SearchPredicate isPriceShared(SearchScope scope, Account user) { return PricesActiveFilterFactory.create(scope, "prices.sharings" , user, "share" ); } @Entity(name = "Assortment" ) public class Assortment { .... @IndexedEmbedded(storage = ObjectFieldStorage.NESTED) @OneToMany(mappedBy = "assortment" , orphanRemoval = true , fetch = FetchType.EAGER, cascade = CascadeType.ALL) private List<AssortmentPrice> prices = new ArrayList<>(); ... @Entity(name = "AssortmentPrice" ) public class AssortmentPrice implements Serializable { .... @FullTextField(analyzer = "permission" ) @Convert(converter = PermissionsConverter.class) @Column(name = "Sharings" , length = 2048) private Permissions sharings = new Permissions(); @GenericField @Column(name = "Active" ) private boolean active = true ; } public class PermissionsFilterFactory { public SearchPredicate create(SearchScope scope, String fieldPath, Account user, String operation) { SearchPredicate filter; SearchPredicateFactory predicate = scope.predicate(); if (operation == null ) { operation = "read" ; } PermissionQuery query = new PermissionQuery(fieldPath, operation, user); filter = predicate.extension(LuceneExtension.get()) .fromLuceneQuery(query) .toPredicate(); return filter; } } public class PricesActiveFilterFactory { @Override public SearchPredicate create(SearchScope scope, String fieldPath) { SearchPredicate filter; filter = ctx.predicate() .match().field(fieldPath) .matching( true ) .toPredicate(); return filter; } } ( https://hibernate.atlassian.net/browse/HSEARCH-3325#add-comment?atlOrigin... ) Add Comment ( https://hibernate.atlassian.net/browse/HSEARCH-3325#add-comment?atlOrigin... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100122- sha1:87fe5bb )

4 years, 9 months

1
0
0 / 0

[JIRA] (WEBSITE-582) Link to release notes of hibernate orm 5.3.14 is broken.

by Yoann Rodière (JIRA)

4 years, 9 months

1
0
0 / 0

[JIRA] (WEBSITE-582) Link to release notes of hibernate orm 5.3.14 is broken.

by Website Form collector (JIRA)

4 years, 9 months

1
0
0 / 0

[JIRA] (HSEARCH-3325) Search 6 groundwork - Restore support for full-text filters

by Waldemar Kłaczyński (JIRA)

Waldemar Kłaczyński ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *commented* on HSEARCH-3325 ( https://hibernate.atlassian.net/browse/HSEARCH-3325?atlOrigin=eyJpIjoiNWI... ) Re: Search 6 groundwork - Restore support for full-text filters ( https://hibernate.atlassian.net/browse/HSEARCH-3325?atlOrigin=eyJpIjoiNWI... ) It's about simplifying your queries. This allows you to restore the previous strategy of defining filters. Of course, it does not impose anything, it is an additional solution that already existed in the previous version and was very useful. The solution restores the previous functionality. It only consists in the fact that in queries you can, as before, draw on predefined filters. Of course, you can do without it. But it is about building as many tools as possible to simplify work with Apache Lucene. Currently, with my patch, I can write a query in a simpler way: private class BeansDataModel extends SearchDataModel<Assortment> { @Override public SearchQuery<Assortment> search(List<SortMeta> multiSortMeta, Map< String , Object > filters) { try { SearchSession session = Search.session(em); SearchScope<Assortment> scope = session.scope(Assortment.class); SearchSortFactory sorter = scope.sort(); CompositeSortComponentsStep sort = sorter.composite(); SearchPredicateFactory spf = scope.predicate(); BooleanPredicateClausesStep pricesFilter = spf.bool() .filter(spf.def( "prices.is-active" )) .filter(spf.def( "prices.is-shared" ) .param( "user" , identity.getAccount()) ); sort.add(sorter.field( "prices.bruttoPrice_sort" ) .asc() .mode(MultiValue.MIN) .filter(pricesFilter)); for (SortMeta sortMeta : multiSortMeta) { String fieldName = sortMeta.getSortField(); switch (sortMeta.getSortOrder()) { case ASCENDING: sort.add(sorter.field(fieldName).asc()); break ; case DESCENDING: sort.add(sorter.field(fieldName).desc()); break ; } } PredicateFinalStep select; if (searchFullText != null ) { select = scope.predicate().simpleQueryString() .field( "shoppingName" ).boost(0.5f) .matching(searchFullText); } else { select = scope.predicate() .matchAll(); } SearchQuery<Assortment> query = session.search(scope) .where((f) -> f.bool().must(select) .filter(f.nested() .objectField( "prices" ) .nest(pricesFilter) )).sort(sort.toSort()).toQuery(); return query; } catch (Exception ex) { throw new IllegalStateException(ex); } } } @Entity(name = "Assortment" ) public class Assortment { .... @IndexedEmbedded(storage = ObjectFieldStorage.NESTED) @OneToMany(mappedBy = "assortment" , orphanRemoval = true , fetch = FetchType.EAGER, cascade = CascadeType.ALL) private List<AssortmentPrice> prices = new ArrayList<>(); ... @FullTextFilter(name = "is-active" , factory = @FilterFactoryRef(type = PricesActiveFilterFactory.class)) @FullTextFilter(name = "is-shared" , factory = @FilterFactoryRef(type = PermissionsFilterFactory.class), params = { @FilterParam(name = "operation" , value = "share" ), @FilterParam(name = "field" , value = "sharings" ) }) @Entity(name = "AssortmentPrice" ) public class AssortmentPrice implements Serializable { .... @FullTextField(analyzer = "permission" ) @Convert(converter = PermissionsConverter.class) @Column(name = "Sharings" , length = 2048) private Permissions sharings = new Permissions(); @GenericField @Column(name = "Active" ) private boolean active = true ; } public class PermissionsFilterFactory implements FilterFactory { @Override public SearchPredicate create(FilterFactoryContext ctx) { SearchPredicate filter; SearchPredicateFactory predicate = ctx.predicate(); Account user = ctx.param( "user" ); String fieldPath = ctx.resolvePath(ctx.param( "field" )); String operation = ctx.param( "operation" ); if (operation == null ) { operation = "read" ; } PermissionQuery query = new PermissionQuery(fieldPath, operation, user); filter = predicate.extension(LuceneExtension.get()) .fromLuceneQuery(query) .toPredicate(); return filter; } } public class PricesActiveFilterFactory implements FilterFactory { @Override public SearchPredicate create(FilterFactoryContext ctx) { SearchPredicate filter; String fieldPath = ctx.resolvePath( "active" ); filter = ctx.predicate() .match().field(fieldPath) .matching( true ) .toPredicate(); return filter; } } Of course I know you can do it differently. Similarly to version 5 it was possible but defining filters in the object type was useful for some. For me it was a valuable property that was in the previous version. I think that this possibility will not hurt in version 6.x, and for some it can be very useful. I have a working solution ready. ( https://hibernate.atlassian.net/browse/HSEARCH-3325#add-comment?atlOrigin... ) Add Comment ( https://hibernate.atlassian.net/browse/HSEARCH-3325#add-comment?atlOrigin... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100122- sha1:53b6171 )

4 years, 9 months

1
0
0 / 0

[JIRA] (HSEARCH-3865) Clean up any change to the permission of index files during tests

by Yoann Rodière (JIRA)

4 years, 9 months

1
0
0 / 0

[JIRA] (HSEARCH-3865) Clean up any change to the permission of index files during tests

by Yoann Rodière (JIRA)

4 years, 9 months

1
0
0 / 0

[JIRA] (HSEARCH-3865) Clean up any change to the permission of index files during tests

by Yoann Rodière (JIRA)

Yoann Rodière ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *created* an issue Hibernate Search ( https://hibernate.atlassian.net/browse/HSEARCH?atlOrigin=eyJpIjoiOWI5YzIw... ) / Task ( https://hibernate.atlassian.net/browse/HSEARCH-3865?atlOrigin=eyJpIjoiOWI... ) HSEARCH-3865 ( https://hibernate.atlassian.net/browse/HSEARCH-3865?atlOrigin=eyJpIjoiOWI... ) Clean up any change to the permission of index files during tests ( https://hibernate.atlassian.net/browse/HSEARCH-3865?atlOrigin=eyJpIjoiOWI... ) Issue Type: Task Assignee: Yoann Rodière ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) Components: tests Created: 16/Mar/2020 02:25 AM Fix Versions: 6.0.0.Beta-backlog-high-priority Priority: Major Reporter: Yoann Rodière ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) In some tests, we change the permission of some files in order to make indexing fail and to test the behavior of Hibernate Search when such failure happens. That's neat as it allows us to simulate very low-level errors without relying on bytecode manipulation, but... it currently leaves files on the filesystem that cannot be removed with mvn clean. We should add a cleanup to tests relying on this permission change, so as to restore original permissions after the test. ( https://hibernate.atlassian.net/browse/HSEARCH-3865#add-comment?atlOrigin... ) Add Comment ( https://hibernate.atlassian.net/browse/HSEARCH-3865#add-comment?atlOrigin... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100122- sha1:53b6171 )

4 years, 9 months

1
0
0 / 0

[JIRA] (HSEARCH-3103) Sorts on multi-valued fields

by Yoann Rodière (JIRA)

4 years, 9 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

hibernate-issues March 2020