August 2020 - hibernate-issues - Jboss List Archives

[JIRA] (HHH-14139) BasicBinder Trace Logging Causes Duplicated Message

by Chris Popp (JIRA)

Chris Popp ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *commented* on HHH-14139 ( https://hibernate.atlassian.net/browse/HHH-14139?atlOrigin=eyJpIjoiMTc2MD... ) Re: BasicBinder Trace Logging Causes Duplicated Message ( https://hibernate.atlassian.net/browse/HHH-14139?atlOrigin=eyJpIjoiMTc2MD... ) It was a Spring boot based project using spring start logging so the logging was a little more complex than I anticipated but I created a simple reproduction. * I created a simple maven project with these dependencies <dependencies> <dependency> <groupId>org.hibernate</groupId> <artifactId>hibernate-core</artifactId> <version>5.4.19.Final</version> </dependency> <dependency> <groupId>org.apache.logging.log4j</groupId> <artifactId>log4j-api</artifactId> <version>2.13.3</version> </dependency> <dependency> <groupId>org.apache.logging.log4j</groupId> <artifactId>log4j-to-slf4j</artifactId> <version>2.13.3</version> </dependency> <dependency> <groupId>ch.qos.logback</groupId> <artifactId>logback-classic</artifactId> <version>1.2.3</version> </dependency> <dependency> <groupId>ch.qos.logback</groupId> <artifactId>logback-core</artifactId> <version>1.2.3</version> </dependency> </dependencies> * And then ran this test class public class LogTest { public static void main(String[] args) throws Exception { Logger root = (Logger)LoggerFactory.getLogger(BasicBinder.class); root.setLevel(Level.TRACE); BasicBinder basicBinder = new TestBinder(); basicBinder.bind(null, "{}", "someName", null); } private static class TestBinder extends BasicBinder { public TestBinder() { super(new StringTypeDescriptor(), new VarcharTypeDescriptor()); } @Override protected void doBind(CallableStatement st, Object value, String name, WrapperOptions options) throws SQLException { } @Override protected void doBind(PreparedStatement st, Object value, int index, WrapperOptions options)throws SQLException { } } } * And saw the following when I ran it > > > > 20:44:06.561 [main] DEBUG org.jboss.logging - Logging Provider: > org.jboss.logging.Log4j2LoggerProvider > > > > 20:44:06.582 [main] TRACE org.hibernate.type.descriptor.sql.BasicBinder - > binding parameter [someName] as [VARCHAR] - [binding parameter [someName] > as [VARCHAR] - [{}]] > > ( https://hibernate.atlassian.net/browse/HHH-14139#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-14139#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100141- sha1:76df2fe )

4 years, 5 months

1
0
0 / 0

[JIRA] (HHH-14139) BasicBinder Trace Logging Causes Duplicated Message

by Nathan Xu (JIRA)

Nathan Xu ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *commented* on HHH-14139 ( https://hibernate.atlassian.net/browse/HHH-14139?atlOrigin=eyJpIjoiNGE1Yz... ) Re: BasicBinder Trace Logging Causes Duplicated Message ( https://hibernate.atlassian.net/browse/HHH-14139?atlOrigin=eyJpIjoiNGE1Yz... ) Interesting bug reporting. I tried to reproduce the bug by specifying the system property (i.e. org.jboss.logging.provider ) to both log4j and `log4j2 ( https://hibernate.atlassian.net/browse/HHH-14139#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-14139#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100141- sha1:76df2fe )

4 years, 5 months

1
0
0 / 0

[JIRA] (HHH-14139) BasicBinder Trace Logging Causes Duplicated Message

by Chris Popp (JIRA)

4 years, 5 months

1
0
0 / 0

[JIRA] (HHH-14139) BasicBinder Trace Logging Causes Duplicated Messagee

by Chris Popp (JIRA)

Chris Popp ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *created* an issue Hibernate ORM ( https://hibernate.atlassian.net/browse/HHH?atlOrigin=eyJpIjoiZGM4YTkwODkw... ) / Bug ( https://hibernate.atlassian.net/browse/HHH-14139?atlOrigin=eyJpIjoiZGM4YT... ) HHH-14139 ( https://hibernate.atlassian.net/browse/HHH-14139?atlOrigin=eyJpIjoiZGM4YT... ) BasicBinder Trace Logging Causes Duplicated Messagee ( https://hibernate.atlassian.net/browse/HHH-14139?atlOrigin=eyJpIjoiZGM4YT... ) Issue Type: Bug Affects Versions: 6.0.0.Alpha5, 5.4.19 Assignee: Unassigned Created: 06/Aug/2020 16:26 PM Priority: Major Reporter: Chris Popp ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) When binding a parameter that includes the text {} the BasicBinder String.format call will include the value as part of the messagePattern passed to the logger. When using log4j {} is interpreted as a variable to be replaced by a argument, and since no arguments are supplied the entire message is considered to be an argument. As a result, when a log message should be: binding parameter [2] as [VARCHAR] - [{}] it ends up getting logged as: binding parameter [2] as [VARCHAR] - [binding parameter [2] as [VARCHAR] - [{}]] ( https://hibernate.atlassian.net/browse/HHH-14139#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-14139#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100141- sha1:76df2fe )

4 years, 5 months

1
0
0 / 0

[JIRA] (HV-1797) Validation on classes with a bidirectional relationship cause stack overflow on 6.1.x

by Chris Westmorland (JIRA)

Chris Westmorland ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=5f2c38a... ) *updated* an issue Hibernate Validator ( https://hibernate.atlassian.net/browse/HV?atlOrigin=eyJpIjoiYWMxZGUzMTI5N... ) / Bug ( https://hibernate.atlassian.net/browse/HV-1797?atlOrigin=eyJpIjoiYWMxZGUz... ) HV-1797 ( https://hibernate.atlassian.net/browse/HV-1797?atlOrigin=eyJpIjoiYWMxZGUz... ) Validation on classes with a bidirectional relationship cause stack overflow on 6.1.x ( https://hibernate.atlassian.net/browse/HV-1797?atlOrigin=eyJpIjoiYWMxZGUz... ) Change By: Chris Westmorland ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=5f2c38a... ) We recently upgraded one of our microservices from Spring Boot 2.2 to 2.3 and ran into a bug with hibernate validator that seems to affect all 6.1.x versions. Here is an example that reproduces the issue. ``` {code:java} @JsonIdentityInfo( generator = ObjectIdGenerators.PropertyGenerator.class, property = "id", scope = Parent.class) public class Parent { @NotNull private Long id; @Valid private Set<Child> children = new HashSet<>(); // getters and setters } @JsonIdentityInfo( generator = ObjectIdGenerators.PropertyGenerator.class, property = "id", scope = Child.class) public class Child { @NotNull private Long id; @NotNull @Valid private Parent parent; // getters and setters } @RestController @Validated public class ValidatorController { @GetMapping("/") public Parent get() { final Parent parent = new Parent(); parent.setId(1L); final Child child = new Child(); child.setId(1L); child.setParent(parent); parent.getChildren().add(child); return parent; } @PostMapping("/") public void post(@Valid @NotNull @RequestBody Parent parent) { System.out.println(parent.getId()); } } @SpringBootTest @RunWith(SpringRunner.class) @AutoConfigureMockMvc public class ValidatorTest { @Autowired private MockMvc mvc; @Test public void test() throws Exception { final MvcResult result = mvc.perform(get("/").accept(MediaType.APPLICATION_JSON)) .andExpect(status().is2xxSuccessful()).andReturn(); final String json = result.getResponse().getContentAsString(); System.out.println(json); mvc.perform(post("/").contentType(MediaType.APPLICATION_JSON).content(json)) .andExpect(status().is2xxSuccessful()); } } {code} ``` This will trigger a stack overflow... ``` {noformat} at org.hibernate.validator.internal.engine.ValidatorImpl.access$300(ValidatorImpl.java:84) at org.hibernate.validator.internal.engine.ValidatorImpl$CascadingValueReceiver.doValidate(ValidatorImpl.java:715) at org.hibernate.validator.internal.engine.ValidatorImpl$CascadingValueReceiver.iterableValue(ValidatorImpl.java:675) at org.hibernate.validator.internal.engine.valueextraction.IterableValueExtractor.extractValues(IterableValueExtractor.java:24) at org.hibernate.validator.internal.engine.valueextraction.IterableValueExtractor.extractValues(IterableValueExtractor.java:14) at org.hibernate.validator.internal.engine.valueextraction.ValueExtractorHelper.extractValues(ValueExtractorHelper.java:42) at org.hibernate.validator.internal.engine.ValidatorImpl.validateCascadedContainerElementsForCurrentGroup(ValidatorImpl.java:651) at org.hibernate.validator.internal.engine.ValidatorImpl.validateCascadedConstraints(ValidatorImpl.java:598) at org.hibernate.validator.internal.engine.ValidatorImpl.validateInContext(ValidatorImpl.java:409) at org.hibernate.validator.internal.engine.ValidatorImpl.validateCascadedAnnotatedObjectForCurrentGroup(ValidatorImpl.java:629) at org.hibernate.validator.internal.engine.ValidatorImpl.validateCascadedConstraints(ValidatorImpl.java:590) at org.hibernate.validator.internal.engine.ValidatorImpl.validateInContext(ValidatorImpl.java:409) at org.hibernate.validator.internal.engine.ValidatorImpl.access$300(ValidatorImpl.java:84) ``` {noformat} ( https://hibernate.atlassian.net/browse/HV-1797#add-comment?atlOrigin=eyJp... ) Add Comment ( https://hibernate.atlassian.net/browse/HV-1797#add-comment?atlOrigin=eyJp... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100141- sha1:76df2fe )

4 years, 5 months

1
0
0 / 0

[JIRA] (HV-1797) Validation on classes with a bidirectional relationship cause stack overflow on 6.1.x

by Chris Westmorland (JIRA)

Chris Westmorland ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=5f2c38a... ) *created* an issue Hibernate Validator ( https://hibernate.atlassian.net/browse/HV?atlOrigin=eyJpIjoiYTBjZjU3MjFiM... ) / Bug ( https://hibernate.atlassian.net/browse/HV-1797?atlOrigin=eyJpIjoiYTBjZjU3... ) HV-1797 ( https://hibernate.atlassian.net/browse/HV-1797?atlOrigin=eyJpIjoiYTBjZjU3... ) Validation on classes with a bidirectional relationship cause stack overflow on 6.1.x ( https://hibernate.atlassian.net/browse/HV-1797?atlOrigin=eyJpIjoiYTBjZjU3... ) Issue Type: Bug Affects Versions: 6.1.0.Final, 6.1.1.Final, 6.1.2.Final, 6.1.3.Final, 6.1.4.Final, 6.1.5.Final Assignee: Unassigned Components: validators Created: 06/Aug/2020 10:20 AM Environment: Spring Boot 2.3.2, Java 11 Priority: Major Reporter: Chris Westmorland ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=5f2c38a... ) We recently upgraded one of our microservices from Spring Boot 2.2 to 2.3 and ran into a bug with hibernate validator that seems to affect all 6.1.x versions. Here is an example that reproduces the issue. ``` @JsonIdentityInfo( generator = ObjectIdGenerators.PropertyGenerator.class, property = "id", scope = Parent.class) public class Parent { @NotNull private Long id; @Valid private Set<Child> children = new HashSet<>(); // getters and setters } @JsonIdentityInfo( generator = ObjectIdGenerators.PropertyGenerator.class, property = "id", scope = Child.class) public class Child { @NotNull private Long id; @NotNull @Valid private Parent parent; // getters and setters } @RestController @Validated public class ValidatorController { @GetMapping("/") public Parent get() { final Parent parent = new Parent(); parent.setId(1L); final Child child = new Child(); child.setId(1L); child.setParent(parent); parent.getChildren().add(child); return parent; } @PostMapping("/") public void post(@Valid @NotNull @RequestBody Parent parent) { System.out.println(parent.getId()); } } @SpringBootTest @RunWith(SpringRunner.class) @AutoConfigureMockMvc public class ValidatorTest { @Autowired private MockMvc mvc; @Test public void test() throws Exception { final MvcResult result = mvc.perform(get("/").accept(MediaType.APPLICATION_JSON)) .andExpect(status().is2xxSuccessful()).andReturn(); final String json = result.getResponse().getContentAsString(); System.out.println(json); mvc.perform(post("/").contentType(MediaType.APPLICATION_JSON).content(json)) .andExpect(status().is2xxSuccessful()); } } ``` This will trigger a stack overflow... ``` at org.hibernate.validator.internal.engine.ValidatorImpl.access$300(ValidatorImpl.java:84) at org.hibernate.validator.internal.engine.ValidatorImpl$CascadingValueReceiver.doValidate(ValidatorImpl.java:715) at org.hibernate.validator.internal.engine.ValidatorImpl$CascadingValueReceiver.iterableValue(ValidatorImpl.java:675) at org.hibernate.validator.internal.engine.valueextraction.IterableValueExtractor.extractValues(IterableValueExtractor.java:24) at org.hibernate.validator.internal.engine.valueextraction.IterableValueExtractor.extractValues(IterableValueExtractor.java:14) at org.hibernate.validator.internal.engine.valueextraction.ValueExtractorHelper.extractValues(ValueExtractorHelper.java:42) at org.hibernate.validator.internal.engine.ValidatorImpl.validateCascadedContainerElementsForCurrentGroup(ValidatorImpl.java:651) at org.hibernate.validator.internal.engine.ValidatorImpl.validateCascadedConstraints(ValidatorImpl.java:598) at org.hibernate.validator.internal.engine.ValidatorImpl.validateInContext(ValidatorImpl.java:409) at org.hibernate.validator.internal.engine.ValidatorImpl.validateCascadedAnnotatedObjectForCurrentGroup(ValidatorImpl.java:629) at org.hibernate.validator.internal.engine.ValidatorImpl.validateCascadedConstraints(ValidatorImpl.java:590) at org.hibernate.validator.internal.engine.ValidatorImpl.validateInContext(ValidatorImpl.java:409) at org.hibernate.validator.internal.engine.ValidatorImpl.access$300(ValidatorImpl.java:84) ``` ( https://hibernate.atlassian.net/browse/HV-1797#add-comment?atlOrigin=eyJp... ) Add Comment ( https://hibernate.atlassian.net/browse/HV-1797#add-comment?atlOrigin=eyJp... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100141- sha1:76df2fe )

4 years, 5 months

1
0
0 / 0

[JIRA] (HSEARCH-3980) Expose multiValuedInRoot in the metamodel

by Fabio Massimo Ercoli (JIRA)

Fabio Massimo Ercoli ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *created* an issue Hibernate Search ( https://hibernate.atlassian.net/browse/HSEARCH?atlOrigin=eyJpIjoiZjJlZDgx... ) / Task ( https://hibernate.atlassian.net/browse/HSEARCH-3980?atlOrigin=eyJpIjoiZjJ... ) HSEARCH-3980 ( https://hibernate.atlassian.net/browse/HSEARCH-3980?atlOrigin=eyJpIjoiZjJ... ) Expose multiValuedInRoot in the metamodel ( https://hibernate.atlassian.net/browse/HSEARCH-3980?atlOrigin=eyJpIjoiZjJ... ) Issue Type: Task Affects Versions: 6.0.0.Beta9 Assignee: Fabio Massimo Ercoli ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) Components: backend-elasticsearch, backend-lucene Created: 06/Aug/2020 09:07 AM Fix Versions: 6.0.0.Beta10 Priority: Major Reporter: Fabio Massimo Ercoli ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) A projection on a field will produce multiple results if the field is multi valued or if the field is contained in a multi valued object field. If either of them are true we say that the field is multi valued in the root. Those are the same fields that need multi() to be projected. See HSEARCH-3391 ( https://hibernate.atlassian.net/browse/HSEARCH-3391 ). We want to expose this information in the field metamodel provided by the framework. ( https://hibernate.atlassian.net/browse/HSEARCH-3980#add-comment?atlOrigin... ) Add Comment ( https://hibernate.atlassian.net/browse/HSEARCH-3980#add-comment?atlOrigin... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100141- sha1:76df2fe )

4 years, 5 months

1
0
0 / 0

[JIRA] (HHH-14137) Empty String Check Performance Improvement

by Sanne Grinovero (JIRA)

4 years, 5 months

1
0
0 / 0

[JIRA] (HHH-14137) Empty String Check Performance Improvement

by Sanne Grinovero (JIRA)

4 years, 5 months

1
0
0 / 0

[JIRA] (HHH-14137) Empty String Check Performance Improvement

by Sanne Grinovero (JIRA)

Sanne Grinovero ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *commented* on HHH-14137 ( https://hibernate.atlassian.net/browse/HHH-14137?atlOrigin=eyJpIjoiNGNkND... ) Re: Empty String Check Performance Improvement ( https://hibernate.atlassian.net/browse/HHH-14137?atlOrigin=eyJpIjoiNGNkND... ) Thanks for the fix! N.B. we already have isNotEmpty}}and {{isEmpty}}and other such optimised helpers in {{StringHelper , but it seems that indeed not all code was using these consistently. Merged the PR. ( https://hibernate.atlassian.net/browse/HHH-14137#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-14137#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100141- sha1:76df2fe )

4 years, 5 months

1
0
0 / 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

hibernate-issues August 2020