[JIRA] (HHH-15466) Compatibility with Jandex 3.0.0
by Ladislav Thon (JIRA)
Ladislav Thon ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *created* an issue
Hibernate ORM ( https://hibernate.atlassian.net/browse/HHH?atlOrigin=eyJpIjoiYzE4N2U5MTJj... ) / Improvement ( https://hibernate.atlassian.net/browse/HHH-15466?atlOrigin=eyJpIjoiYzE4N2... ) HHH-15466 ( https://hibernate.atlassian.net/browse/HHH-15466?atlOrigin=eyJpIjoiYzE4N2... ) Compatibility with Jandex 3.0.0 ( https://hibernate.atlassian.net/browse/HHH-15466?atlOrigin=eyJpIjoiYzE4N2... )
Issue Type: Improvement Affects Versions: 5.6.10, 6.1.2 Assignee: Ladislav Thon ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) Components: hibernate-core Created: 26/Aug/2022 06:46 AM Priority: Major Reporter: Ladislav Thon ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... )
I suggest Hibernate ORM 5.6 (used in Quarkus), 6.0 (used in WildFly) and possibly also the main branch adopts a tiny change that allows compiling with Jandex 2.4 and running with both Jandex 2.4 and 3.0.
The only change in Jandex 3.0 relevant to Hibernate ORM is that Indexer.index() used to return ClassInfo , but now returns void. This is a breaking change, but Jandex 3.0 has a synthetic bridge method with the old signature for binary compatibility – except it always return null. Therefore, Hibernate ORM either needs to ignore the return value completely (preferrable, as that makes it source-compatible with Jandex 3.0), or be prepared to handle null.
This is not a duplicate of https://hibernate.atlassian.net/browse/HHH-15465 ( https://hibernate.atlassian.net/browse/HHH-15465 ). That issue suggests direct upgrade, which is a breaking change. In my opinion, that requires at least a minor release and isn’t suitable for backporting. In that sense, this issue is a short-term thing that can be included in a micro release, while the other is more of a long-term kind of change that requires at least a minor release in my opinion.
( https://hibernate.atlassian.net/browse/HHH-15466#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-15466#add-comment?atlOrigin=ey... )
Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100206- sha1:4ed3dc7 )
2 years, 4 months