February 2023 - hibernate-issues - Jboss List Archives

[JIRA] (HHH-16226) Introduce JdbcValuesMappingProducerProvider

by Steve Ebersole (JIRA)

1 year, 10 months

1
0
0 / 0

[JIRA] (HHH-16019) @Where not applied across association boundaries

by Steve Ebersole (JIRA)

Steve Ebersole ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *commented* on HHH-16019 ( https://hibernate.atlassian.net/browse/HHH-16019?atlOrigin=eyJpIjoiMjEyYj... ) Re: @Where not applied across association boundaries ( https://hibernate.atlassian.net/browse/HHH-16019?atlOrigin=eyJpIjoiMjEyYj... ) > > > > As you can see, the unique constraint has been added to the user_id column. > > Perhaps this is an intentional change in behavior in version 6.2.0? > > We did in fact change the behavior ( https://docs.jboss.org/hibernate/orm/6.0/migration-guide/migration-guide.... ) such that a unique constraint is always added for a 1-1 mapping. That was actually a bug in previous releases. But as as you can see from the link, that was actually changed in 6.0. Perhaps an additional condition was recognized later and addressed. But regardless, hopefully you can understand that a 1-1 mapping would more-than-correctly have unique constraints defined. ( https://hibernate.atlassian.net/browse/HHH-16019#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-16019#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100217- sha1:077879e )

1 year, 10 months

1
0
0 / 0

[JIRA] (HHH-16216) @Query creates additional not null checks for SybaseASEDialect

by Jan Schatteman (JIRA)

1 year, 10 months

1
0
0 / 0

[JIRA] (HHH-16230) Wrong data in self-reference using L2C and BatchSize

by MK (JIRA)

MK ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=70121%3... ) *created* an issue Hibernate ORM ( https://hibernate.atlassian.net/browse/HHH?atlOrigin=eyJpIjoiYWU4NjMxY2M4... ) / Bug ( https://hibernate.atlassian.net/browse/HHH-16230?atlOrigin=eyJpIjoiYWU4Nj... ) HHH-16230 ( https://hibernate.atlassian.net/browse/HHH-16230?atlOrigin=eyJpIjoiYWU4Nj... ) Wrong data in self-reference using L2C and BatchSize ( https://hibernate.atlassian.net/browse/HHH-16230?atlOrigin=eyJpIjoiYWU4Nj... ) Issue Type: Bug Affects Versions: 6.2.0.CR2 Assignee: Unassigned Attachments: wrong-data-in-self-reference.zip Components: hibernate-core Created: 24/Feb/2023 05:18 AM Environment: Worked in 6.1.7.Final, regression in 6.2.0.CR2. Priority: Blocker Reporter: MK ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=70121%3... ) When loading entities that have a field referencing itself (representing a parent-child-relationship), the field may be filled with wrong data if the second-level cache is used along with BatchSize. In the example below (it is also attached), an entity which does not have a parent category set is loaded with a parent category. The last assertion fails in 6.2.0.CR2 but passes in 6.1.7.Final, as it should. Entity: @NamedQueries( { @NamedQuery(name = "Category.selectAll" , query = " SELECT c" + " FROM Category c" + " ORDER BY c.name" ) }) @Entity @BatchSize(size = 500) @Cacheable @Cache(usage = CacheConcurrencyStrategy.READ_WRITE) public class Category { @Id @GeneratedValue private Long id; @Column private String name; @ManyToOne @JoinColumn @Fetch(value = FetchMode.SELECT) private Category parentCategory; } Test: @Test public void hhh123Test() throws Exception { createEntities(); EntityManager entityManager = entityManagerFactory.createEntityManager(); entityManager.getTransaction().begin(); List<Category> categories = entityManager.createNamedQuery( "Category.selectAll" , Category.class).getResultList(); entityManager.getTransaction().commit(); entityManager.close(); Assert.assertNull(categories.get(0).getParentCategory()); Assert.assertEquals( "A" , categories.get(1).getParentCategory().getName()); Assert.assertNull(categories.get(2).getParentCategory()); // This assertion fails, even though it should pass } private void createEntities() { EntityManager entityManager = entityManagerFactory.createEntityManager(); entityManager.getTransaction().begin(); Category categoryA = new Category(); categoryA.setName( "A" ); entityManager.persist(categoryA); Category categoryB = new Category(); categoryB.setName( "B" ); categoryB.setParentCategory(categoryA); entityManager.persist(categoryB); Category categoryC = new Category(); categoryC.setName( "C" ); entityManager.persist(categoryC); entityManager.getTransaction().commit(); entityManager.close(); } ( https://hibernate.atlassian.net/browse/HHH-16230#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-16230#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100217- sha1:077879e )

1 year, 10 months

1
0
0 / 0

[JIRA] (HHH-16216) @Query creates additional not null checks for SybaseASEDialect

by Marius K (JIRA)

Marius K ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=70121%3... ) *commented* on HHH-16216 ( https://hibernate.atlassian.net/browse/HHH-16216?atlOrigin=eyJpIjoiMGQyMz... ) Re: @Query creates additional not null checks for SybaseASEDialect ( https://hibernate.atlassian.net/browse/HHH-16216?atlOrigin=eyJpIjoiMGQyMz... ) comparing SybaseASESqlAstTranslator with SybaseSqlAstTranslator the first one adds those checks in renderComparison if ( lhsNotNullPredicate ) { appendSql( " and " ); lhs.accept( this ); appendSql( " is not null" ); } if ( rhsNotNullPredicate ) { appendSql( " and " ); rhs.accept( this ); appendSql( " is not null" ); } lhsNotNullPredicate}}is true due to the {{isParameter check in boolean lhsNotNullPredicate = rhs instanceof Literal || this.isParameter(rhs); ( https://hibernate.atlassian.net/browse/HHH-16216#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-16216#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100217- sha1:077879e )

1 year, 10 months

1
0
0 / 0

[JIRA] (HHH-16019) @Where not applied across association boundaries

by Jaehoon Lee (JIRA)

Jaehoon Lee ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=61d510f... ) *updated* an issue Hibernate ORM ( https://hibernate.atlassian.net/browse/HHH?atlOrigin=eyJpIjoiNWY3M2RlYmQy... ) / Bug ( https://hibernate.atlassian.net/browse/HHH-16019?atlOrigin=eyJpIjoiNWY3M2... ) HHH-16019 ( https://hibernate.atlassian.net/browse/HHH-16019?atlOrigin=eyJpIjoiNWY3M2... ) @Where not applied across association boundaries ( https://hibernate.atlassian.net/browse/HHH-16019?atlOrigin=eyJpIjoiNWY3M2... ) Change By: Jaehoon Lee ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=61d510f... ) I am experiencing strange behavior in the process of upgrading to Hibernate 6.x. It seems {{@Where}} annotation on entity class is ignored when using with entity graph or fetch join. Despite the same entity classes and queries, wrong SQL is generated after upgrading to Hibernate 6.x, which is not what I expected. - I have created a sample project to test the issue and show the situation in detail. Here is GitHub repository for the sample project: - * - Sample project (with Hibernate 5.6.14.Final): [https://github.com/dev Refer to the repository below - jaehoonlee/hibernate-orm-demo/tree/hibernate-5.6|https://github.com/dev-j...] * - Sample project (with Hibernate 6.1.6.Final): [https://github.com/dev Refer to the repository below - jaehoonlee/hibernate-orm-demo/tree/hibernate-6.1|https://github.com/dev-j...] I have explained the details on discourse topic - [https://discourse.hibernate.org/t/where-clause-ignored-after-upgrading-to...] I also forked hibernate-test-case-templates repository and added test cases: [https://github.com/dev-jaehoonlee/hibernate-test-case-templates/tree/HHH-... -2/orm |https://github.com/dev-jaehoonlee/hibernate-test-case-templates/tree/HHH-16019 -2/orm |smart-link] [orm/hibernate-orm-5/src/test/java/org/hibernate/bugs/JPAUnitTestCase.java... -2 /orm/hibernate-orm-5/src/test/java/org/hibernate/bugs/JPAUnitTestCase.java] and [orm/hibernate-orm-6/src/test/java/org/hibernate/bugs/JPAUnitTestCase.java... -2 /orm/hibernate-orm-6/src/test/java/org/hibernate/bugs/JPAUnitTestCase.java] have the same test cases, but tests are passed with Hibernate 5.6 and failed with Hibernate 6.1 ( https://hibernate.atlassian.net/browse/HHH-16019#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-16019#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100217- sha1:077879e )

1 year, 10 months

1
0
0 / 0

[JIRA] (HHH-16019) @Where not applied across association boundaries

by Jaehoon Lee (JIRA)

Jaehoon Lee ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=61d510f... ) *commented* on HHH-16019 ( https://hibernate.atlassian.net/browse/HHH-16019?atlOrigin=eyJpIjoiODQxMm... ) Re: @Where not applied across association boundaries ( https://hibernate.atlassian.net/browse/HHH-16019?atlOrigin=eyJpIjoiODQxMm... ) @Steve Ebersole Thank you for your response and I apologize for the late reply. I've been on vacation and haven't checked in. > > > > "I assume you run the tests against a pre-existing schema" > > I ran the tests using the H2 memory database set up in hibernate-test-case-templates. > > > > "If Hibernate exports the schema, it will (properly) create a unique > constraint for the @OneToOne used on UserDetail#user" > > The is_active column on the UserDetail entity is a flag used for soft-delete purposes, so there can be multiple rows with the same user_id in the database. In versions 5.6.14.Final , 5.6.15.Final , 6.1.6.Final , and 6.1.7.Final , schema generation does not seem to create a unique constraint on that field. The following is the DDL for the user_details table generated by version 6.1.7.Final : create table user_details ( detail_id bigint generated by default as identity , is_active boolean , city varchar (255), user_id bigint , primary key (detail_id) ) However, I found that the 6.2.0.CR1 and 6.2.0.CR2 versions create their own constraints on those fields during schema generation. The following is the DDL for the user_details table generated by the 6.2.0.CR2 version: create table user_details ( is_active boolean , detail_id bigint generated by default as identity , user_id bigint unique , city varchar (255), primary key (detail_id) ) As you can see, the unique constraint has been added to the user_id column. Perhaps this is an intentional change in behavior in version 6.2.0? Anyway, in 6.2.x and later versions, the unique constraint created as above causes a "Unique index or primary key violation" error when inserting sample data for testing, but that doesn't seem to be very relevant to this issue, so let's get back to the original issue. > > > > "There is a lot going on in your tests, is that really the minimally > reproducible domain model?" > > I apologize that my tests are verbose and unclear. I have simplified the test code as much as I could. Please check it out the following repository (the HHH-16019-2 branch): * https://github.com/dev-jaehoonlee/hibernate-test-case-templates/tree/HHH-... ( https://github.com/dev-jaehoonlee/hibernate-test-case-templates/tree/HHH-... ) * Hibernate 5 test case: /orm/hibernate-orm-5/src/test/java/org/hibernate/bugs/JPAUnitTestCase.java ( https://github.com/dev-jaehoonlee/hibernate-test-case-templates/blob/HHH-... ) * Hibernate 6 test case: /orm/hibernate-orm-6/src/test/java/org/hibernate/bugs/JPAUnitTestCase.java ( https://github.com/dev-jaehoonlee/hibernate-test-case-templates/blob/HHH-... ) In versions 5.6.14.Final , 5.6.15.Final , the following query is generated on find() , and the test passes. select user0_.user_id as user_id1_1_0_, user0_.user_name as user_nam2_1_0_, userdetail1_.detail_id as detail_i1_0_1_, userdetail1_.is_active as is_active2_0_1_, userdetail1_.city as city3_0_1_, userdetail1_.user_id as user_id4_0_1_ from users user0_ left outer join user_details userdetail1_ on user0_.user_id=userdetail1_.user_id and ( userdetail1_.is_active = true ) where user0_.user_id=? On the other hand, in versions 6.1.6.Final , 6.1.7.Final , the following query is generated on find(). select u1_0.user_id, d1_0.detail_id, d1_0.is_active, d1_0.city, d1_0.user_id, u1_0.user_name from users u1_0 left join user_details d1_0 on u1_0.user_id=d1_0.user_id where u1_0.user_id=? Despite the @Where(clause = "is_active = true") condition present in the UserDetail entity, the and ( userdetail1_.is_active = true ) statement is omitted from the on clause of the join. Therefore, two rows are returned, which results in a "Duplicate row was found" error and the test fails. What I expect is for the condition d1_0.is_active = true to exist in the on clause of the join, as it did in versions 5.6.14.Final , 5.6.15.Final. Again, I apologize for the late response and thank you. ( https://hibernate.atlassian.net/browse/HHH-16019#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-16019#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100217- sha1:077879e )

1 year, 10 months

1
0
0 / 0

[JIRA] (HHH-16216) @Query creates additional not null checks for SybaseASEDialect

by Marius K (JIRA)

Marius K ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=70121%3... ) *commented* on HHH-16216 ( https://hibernate.atlassian.net/browse/HHH-16216?atlOrigin=eyJpIjoiM2Q2N2... ) Re: @Query creates additional not null checks for SybaseASEDialect ( https://hibernate.atlassian.net/browse/HHH-16216?atlOrigin=eyJpIjoiM2Q2N2... ) Hi Jan, thank you for looking into this. I attached a new example based on the hibernate-test-case-templates. hibernate-orm-6.zip ( https://hibernate.atlassian.net/secure/attachment/50228/50228_hibernate-o... ) Using <property name="hibernate.dialect" value="org.hibernate.dialect.H2Dialect"/> or <property name="hibernate.dialect" value="org.hibernate.dialect.SybaseDialect"/> results in Hibernate: select m1_0.MY_USER_ID, m1_0.FIRSTNAME, m1_0.LASTNAME from MY_USER m1_0 where m1_0.FIRSTNAME=? and m1_0.LASTNAME=? which is fine But <property name="hibernate.dialect" value="org.hibernate.dialect.SybaseASEDialect"/> results in Hibernate: select m1_0.MY_USER_ID, m1_0.FIRSTNAME, m1_0.LASTNAME from MY_USER m1_0 where m1_0.FIRSTNAME=? and m1_0.FIRSTNAME is not null and m1_0.LASTNAME=? and m1_0.LASTNAME is not null which has additionall null checks ( https://hibernate.atlassian.net/browse/HHH-16216#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-16216#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100217- sha1:077879e )

1 year, 10 months

1
0
0 / 0

[JIRA] (HHH-16229) Consider pluggability for rendering "JDBC" parameters

by Steve Ebersole (JIRA)

1 year, 10 months

1
0
0 / 0

[JIRA] (HHH-16229) Consider pluggability for rendering "JDBC" parameters

by Steve Ebersole (JIRA)

1 year, 10 months

1
0
0 / 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

hibernate-issues February 2023