June 2023 - hibernate-issues - Jboss List Archives

[JIRA] (HHH-16858) Can't compare test expression of type [BasicSqmPathSource(type : Enum)] with element of type [basicType@5(java.lang.Integer,4)]

by Gavin King (JIRA)

Gavin King ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *commented* on HHH-16858 ( https://hibernate.atlassian.net/browse/HHH-16858?atlOrigin=eyJpIjoiMjEwYz... ) Re: Can't compare test expression of type [BasicSqmPathSource(type : Enum)] with element of type [basicType(a)5(java.lang.Integer,4)] ( https://hibernate.atlassian.net/browse/HHH-16858?atlOrigin=eyJpIjoiMjEwYz... ) I mean, at the very least it seems like you should be comparing the enum field to an enum literal, not to an integer literal! (Note that I do agree that the error here is quite ugly.) ( https://hibernate.atlassian.net/browse/HHH-16858#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-16858#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100227- sha1:3bc807d )

1 year, 6 months

1
0
0 / 0

[JIRA] (HHH-16858) Can't compare test expression of type [BasicSqmPathSource(type : Enum)] with element of type [basicType@5(java.lang.Integer,4)]

by Gavin King (JIRA)

Gavin King ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *commented* on HHH-16858 ( https://hibernate.atlassian.net/browse/HHH-16858?atlOrigin=eyJpIjoiMjEyYj... ) Re: Can't compare test expression of type [BasicSqmPathSource(type : Enum)] with element of type [basicType(a)5(java.lang.Integer,4)] ( https://hibernate.atlassian.net/browse/HHH-16858?atlOrigin=eyJpIjoiMjEyYj... ) So the reason I’m suspicious of this, and think it would be totally reasonable if we simply disallowed it is that if you use a STRING mapped enum, which I frankly think makes more sense most of the time, then < would be doing an alphabetic string comparison, which simply doesn’t seem like it could ever be meaningful. I guess it sorta might make sense for some ORDINAL mappings, but even that is pretty doubtful. So I guess my vote would be to disallow this with a more meaningful error, but I would not strongly object to allowing it only for ordinal-mapped enums. ( https://hibernate.atlassian.net/browse/HHH-16858#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-16858#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100227- sha1:3bc807d )

1 year, 6 months

1
0
0 / 0

[JIRA] (HHH-16858) Can't compare test expression of type [BasicSqmPathSource(type : Enum)] with element of type [basicType@5(java.lang.Integer,4)]

by Jonas Gernot Steinke (JIRA)

Jonas Gernot Steinke ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=712020%... ) *commented* on HHH-16858 ( https://hibernate.atlassian.net/browse/HHH-16858?atlOrigin=eyJpIjoiYTk3Zm... ) Re: Can't compare test expression of type [BasicSqmPathSource(type : Enum)] with element of type [basicType(a)5(java.lang.Integer,4)] ( https://hibernate.atlassian.net/browse/HHH-16858?atlOrigin=eyJpIjoiYTk3Zm... ) The comparison with < in this example is only to show that comparison operators ( = , < , > , >= , <= , <> ) do not work in this case. In the example I use EnumType.ORDINAL , in the other case of EnumType ( https://docs.jboss.org/hibernate/orm/current/userguide/html_single/Hibern... ) EnumType.STRING a similar error occurs: Error interpreting query [SELECT b FROM ItemB b WHERE b.type = 'B2']; this may indicate a semantic (user query) problem or a bug in the parser [SELECT b FROM ItemB b WHERE b.type = 'B2'] Can't compare test expression of type [BasicSqmPathSource(type : Enum)] with element of type [basicType(a)15(java.lang.String,12)] The question is, why does it work with ItemA: public interface ItemARepository extends JpaRepository<ItemA, Long >, JpaSpecificationExecutor<ItemA> { @Query( "SELECT a FROM ItemA a WHERE a.type < 1" ) List<ItemA> findAllByTypeA2(); } https://github.com/JGSteinke/hibernate-test/blob/main/src/main/java/de/hi... As I wrote before, it has only stopped working since the Hibernate update. My guess is that in case A the enum is compared depending on the EnumType ( EnumType.ORDINAL as Integer or EnumType.STRING as String) and in case B this does not happen. The question of sense of compare enums using < is not at issue here, but I would like to discuss it briefly. In this way you can, for example, find all entries that precede a certain status. ( https://hibernate.atlassian.net/browse/HHH-16858#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-16858#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100227- sha1:3bc807d )

1 year, 6 months

1
0
0 / 0

[JIRA] (HHH-16860) OneToMany with inherited classes on both sides

by Rob Scala (JIRA)

Rob Scala ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *updated* an issue Hibernate ORM ( https://hibernate.atlassian.net/browse/HHH?atlOrigin=eyJpIjoiNzY2MzM3YTdj... ) / Bug ( https://hibernate.atlassian.net/browse/HHH-16860?atlOrigin=eyJpIjoiNzY2Mz... ) HHH-16860 ( https://hibernate.atlassian.net/browse/HHH-16860?atlOrigin=eyJpIjoiNzY2Mz... ) OneToMany with inherited classes on both sides ( https://hibernate.atlassian.net/browse/HHH-16860?atlOrigin=eyJpIjoiNzY2Mz... ) Change By: Rob Scala ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) I have two base classes, company and computer_system. Each of the base classes has two subclasses, and they use the InheritanceType.JOINED strategy. !company_computer_systems.png|width=879,height=232! Each computer system has a company owner. A customer_computer_system is owned by a customer_company and a distributor_computer_system is owned by a distributor_company. {noformat}@Entity ... @Inheritance(strategy= InheritanceType.JOINED) public abstract class ComputerSystem { @Id @GeneratedValue(strategy = GenerationType.IDENTITY) private long id; @ManyToOne(fetch = FetchType.LAZY) @JoinColumn(name = "OWNER_ID", foreignKey = @ForeignKey()) protected Company owner; } {noformat} One of the company subclasses has a OneToMany collection with one of the computer_system subclasses. {noformat}@Entity ... public class CustomerCompany { @OneToMany(mappedBy = "owner", orphanRemoval = true, cascade = CascadeType.PERSIST, fetch = FetchType.LAZY) private List<CustomerComputerSystem> computerSystems; } {noformat} With this mapping, I am able to access the list of computer systems. The problem is that when I use the schema migrator tool to produce an update script, it creates this: {noformat}alter table if exists customer_computer_system add column OWNER_ID bigint; alter table if exists distributor_computer_system add column OWNER_ID bigint;{noformat} It wants to add “id” fields to the ComputerSystem subclasses. The test case is attached and is also here - [https://github.com/robscala/onetomany_inherited_test_case|https://github....] [^HHH-16860.zip] One thing go note. This test case properly shows the problem in Hibernate 6.2.1, but fails to create the EMF in later versions due to an assertion error in the SimpleForeignKeyDescriptor. If I turn off assertions, the test case completes even in version 6.3.0-SNAPSHOT, showing the same incorrect update script. ( https://hibernate.atlassian.net/browse/HHH-16860#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-16860#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100227- sha1:3bc807d )

1 year, 6 months

1
0
0 / 0

[JIRA] (HHH-16860) OneToMany with inherited classes on both sides

by Rob Scala (JIRA)

Rob Scala ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *created* an issue Hibernate ORM ( https://hibernate.atlassian.net/browse/HHH?atlOrigin=eyJpIjoiNzczZjZmYzZl... ) / Bug ( https://hibernate.atlassian.net/browse/HHH-16860?atlOrigin=eyJpIjoiNzczZj... ) HHH-16860 ( https://hibernate.atlassian.net/browse/HHH-16860?atlOrigin=eyJpIjoiNzczZj... ) OneToMany with inherited classes on both sides ( https://hibernate.atlassian.net/browse/HHH-16860?atlOrigin=eyJpIjoiNzczZj... ) Issue Type: Bug Affects Versions: 6.2.1, 6.2.5 Assignee: Unassigned Attachments: company_computer_systems.png Components: hibernate-core Created: 27/Jun/2023 10:32 AM Priority: Major Reporter: Rob Scala ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) I have two base classes, company and computer_system. Each of the base classes has two subclasses, and they use the InheritanceType.JOINED strategy. Each computer system has a company owner. A customer_computer_system is owned by a customer_company and a distributor_computer_system is owned by a distributor_company. @Entity ... @Inheritance(strategy= InheritanceType.JOINED) public abstract class ComputerSystem { @Id @GeneratedValue(strategy = GenerationType.IDENTITY) private long id; @ManyToOne(fetch = FetchType.LAZY) @JoinColumn(name = "OWNER_ID", foreignKey = @ForeignKey()) protected Company owner; } One of the company subclasses has a OneToMany collection with one of the computer_system subclasses. @Entity ... public class CustomerCompany { @OneToMany(mappedBy = "owner", orphanRemoval = true, cascade = CascadeType.PERSIST, fetch = FetchType.LAZY) private List<CustomerComputerSystem> computerSystems; } With this mapping, I am able to access the list of computer systems. The problem is that when I use the schema migrator tool to produce an update script, it creates this: alter table if exists customer_computer_system add column OWNER_ID bigint; alter table if exists distributor_computer_system add column OWNER_ID bigint; It wants to add “id” fields to the ComputerSystem subclasses. The test case is attached and is also here - https://github.com/robscala/onetomany_inherited_test_case One thing go note. This test case properly shows the problem in Hibernate 6.2.1, but fails to create the EMF in later versions due to an assertion error in the SimpleForeignKeyDescriptor. If I turn off assertions, the test case completes even in version 6.3.0-SNAPSHOT, showing the same incorrect update script. ( https://hibernate.atlassian.net/browse/HHH-16860#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-16860#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100227- sha1:3bc807d )

1 year, 6 months

1
0
0 / 0

[JIRA] (HSEARCH-4805) Remove workarounds related to HHH-15604/HHH-16209 from tests

by Automation for Jira (JIRA)

1 year, 6 months

1
0
0 / 0

[JIRA] (HSEARCH-4394) Switch to Jakarta EE as the default standard instead of Java EE

by Automation for Jira (JIRA)

1 year, 6 months

1
0
0 / 0

[JIRA] (HSEARCH-4755) Upgrade to Spring Boot 3 for -orm6 artifacts

by Marko Bekhta (JIRA)

Marko Bekhta ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *commented* on HSEARCH-4755 ( https://hibernate.atlassian.net/browse/HSEARCH-4755?atlOrigin=eyJpIjoiNDM... ) Re: Upgrade to Spring Boot 3 for -orm6 artifacts ( https://hibernate.atlassian.net/browse/HSEARCH-4755?atlOrigin=eyJpIjoiNDM... ) looks like Narayana starter is updated with this PR: https://github.com/snowdrop/narayana-spring-boot/pull/99 but it hasn’t been released yet. ( https://hibernate.atlassian.net/browse/HSEARCH-4755#add-comment?atlOrigin... ) Add Comment ( https://hibernate.atlassian.net/browse/HSEARCH-4755#add-comment?atlOrigin... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100227- sha1:3bc807d )

1 year, 6 months

1
0
0 / 0

[JIRA] (HHH-13506) hibernate-jpamodelgen generated resources have Turkish Character problem

by Jan Schatteman (JIRA)

1 year, 6 months

1
0
0 / 0

[JIRA] (HHH-16790) Performance issue when retrieving a large bulk of entity in bidirectionnal association

by Thomas Herth (JIRA)

Thomas Herth ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=712020%... ) *commented* on HHH-16790 ( https://hibernate.atlassian.net/browse/HHH-16790?atlOrigin=eyJpIjoiMTA2NT... ) Re: Performance issue when retrieving a large bulk of entity in bidirectionnal association ( https://hibernate.atlassian.net/browse/HHH-16790?atlOrigin=eyJpIjoiMTA2NT... ) I uploaded hibernate6-eager-fetching-performance-issue.zip with two sample projects, one using Spring Boot 3 and Hibernate 6 and the other using Spring Boot 2 and Hibernate 5. Even the domain classes can be optimized - I detected two unnecessary eager fetchings - we can see that Hibernate 6 is significantly slower than Hibernate 5 when fetching the collections. The log files included in the ZIP file show two runs with 200 C1Sets. First the run of H6Sample creates the C1Sets and then lists them. Second the run of H5Sample uses the same data to list all C1Sets. Time needed for listing: 40 seconds vs 1.5 seconds using Postgres 13 H6Sample: http://localhost:8086/c1sets http://localhost:8086/swagger-ui/index.html#/c-1-set-controller/listAll H5Sample http://localhost:8085/c1sets http://localhost:8085/swagger-ui/index.html#/c-1-set-controller/listAll In BootstrapService the number of C1Sets to be created can be changed. Maybe you want more C1Sets e.g. when using using an H2 database for the tests - or less. Using Postgres 20 C1Sets are enough to see a difference. I hope this helps finding a solution for this issue. ( https://hibernate.atlassian.net/browse/HHH-16790#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-16790#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100227- sha1:3bc807d )

1 year, 6 months

1
0
0 / 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

hibernate-issues June 2023