[hibernate-issues] [Hibernate-JIRA] Commented: (HHH-5024) MetadataContext#registerAttribute does not recognize inherited fields

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-5024?page=c... ] Steve Ebersole commented on HHH-5024: ------------------------------------- So the tests I created from these issues show what we think are 2 different "issues". First, the specific case Hardy and I were discussing above which came originally from Alexis. We both agree this is just incorrect mapping. Specifically, attributes defined on a {{MappedSuperclass}} can be "overridden" on an entity sub class, but the proper way to do that is to use ((AttributeOverrides)). And there is no spec provided way to say that a basic attribute defined on a {{MappedSuperclass}} become {{Id}} mappings on an entity sub class. Given that model, we think the correct way to map that to match the intent and meet the spec is to mark those 2 attributes as {{Transient}} on the {{MappedSuperclass}} like so: {code:title=AbstractAttribute.java|borderStyle=solid} @MappedSuperclass public abstract class AbstractAttribute implements Serializable { protected String key; protected String value; public AbstractAttribute() { super(); } @Transient public abstract String getOwner(); @Transient public String getKey() { return key; } public void setKey(String key) { this.key = key; } @Column(name = "attribute_value") public String getValue() { return value; } public void setValue(String value) { this.value = value; } } {code} The entity class stays as it was. And this works in terms of both the metamodel generator and Hibernate populating that static metamodel. ---- The second issue deals with "embeddable" classes defined on a {{MappedSuperclass}}. This holds true for both {{Embedded}} and {{EmbeddedId}}. The issue is the way in which support for {{MappedSuperclass}} was originally "bolted on" to the existing Hibernate {{PersistentClass}} mapping classes. Changing the {{getDeclaredField}} call to {{getField}} as suggested here is really just a band aid. But we will make that change for embeddable attributes for 4.1 as better solutions are already targeted for 5.0 -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira