[hibernate-issues] [Hibernate-JIRA] Resolved: (METAGEN-54) XML-only field access type Set attribute not generated

XML-only field access type Set attribute not generated ------------------------------------------------------ Key: METAGEN-54 URL: http://opensource.atlassian.com/projects/hibernate/browse/METAGEN-54 Project: Hibernate Metamodel Generator Issue Type: Bug Components: processor Affects Versions: 1.1.1.Final Environment: maven 3.0.2 Java: java version "1.6.0_22", Java(TM) SE Runtime Environment (build 1.6.0_22-b04) Uname: Linux xxx 2.6.32-28-generic-pae #55-Ubuntu SMP Mon Jan 10 22:34:08 UTC 2011 i686 GNU/Linux Reporter: Martijn Blankestijn Assignee: Hardy Ferentschik Fix For: 1.x Attachments: 0001-XML-only-field-access-type-Set-attribute-not-generat.patch, 0002-Extra-check-on-return-type-from-a-method.patch I have a xml-only mapping with no target-entity attribute specified on collections. For the collections generics were used, so type information was available. The collections were not generated by the generator in the meta-model classes. I have checked out the current version of the source from Git and made the changes (testcases and solution). You find these files attached to this bugreport. It is not a very 'clean' solution yet, but I wanted to shared the bug and possible solution first. When I run maven just after checkout I had 4 failing testcases: testAccessTypeForXmlConfiguredEmbeddables(org.hibernate.jpamodelgen.test.mixedmode.MixedConfigurationTest) testDefaultAccessTypeApplied(org.hibernate.jpamodelgen.test.mixedmode.MixedConfigurationTest) testExplicitXmlConfiguredAccessTypeApplied(org.hibernate.jpamodelgen.test.mixedmode.MixedConfigurationTest) testMixedConfiguration(org.hibernate.jpamodelgen.test.mixedmode.MixedConfigurationTest) I still had these 4 failing testcase with my solution and I have not investigated this further. In my search for the answer (error in my mapping, incorrect understanding of the generator or a bug in the Generator) I found a couple of points I got confused about. First is that the access type on the XML entity was not set if it was specified only on the entity (not in the persistence unit default or on the collection itself). It then defaulted to METHOD (a.k.a. property access) In XmlMetaEntity (line 542) return TypeUtils.getElementKindForAccessType( accessTypeInfo.getDefaultAccessType() ); probably should be return TypeUtils.getElementKindForAccessType( accessTypeInfo.getAccessType() ); which was good because line 196 would lead the code to look for attributes (not methods) to compare to the property-name. If the element was not the same one as was expected, the loop would skip that element. This seemed strange to me. if ( expectedElementKind.equals( elem.getKind() ) ) { continue; } As I said, attached is my solution in which, I hope, will confirm to the JPA-specification ;-). Regards, Martijn Blankestijn