[hibernate-issues] [JIRA] (HSEARCH-4703) HSearch Outbox table module -> inaccesible private field error using Java 9 modules

Yoann Rodière ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *commented* on HSEARCH-4703 ( https://hibernate.atlassian.net/browse/HSEARCH-4703?atlOrigin=eyJpIjoiZjg... ) Re: HSearch Outbox table module -> inaccesible private field error using Java 9 modules ( https://hibernate.atlassian.net/browse/HSEARCH-4703?atlOrigin=eyJpIjoiZjg... ) Right, thanks for reporting this, we should add a few open statements to the module-info of hibernate-search-mapper-orm-coordination-outbox-polling. Marko Bekhta ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) I think we need to do that ^ and also add a few tests, because currently we only test a very specific case in the modulepath. It’s a bit inconvenient to run the main tests in the modulepath (in particular because of test utils), but perhaps we could expand our smoke tests related to the modulepath: instead of just having one test module, integrationtest/java/modules , we’d have several, each with its own set of dependencies, module-info and test: * integrationtest/java/modules/orm-elasticsearch (the existing one, renamed) * integrationtest/java/modules/orm-lucene (we don’t have a full Java module for backend-lucene, but we define an automatic module name, so this should be possible) * integrationtest/java/modules/pojo-standalone-elasticsearch * integrationtest/java/modules/pojo-standalone-lucene * integrationtest/java/modules/orm-coordination-outbox-polling-elasticsearch (this will check that you solved https://hibernate.atlassian.net/browse/HSEARCH-4703 ( https://hibernate.atlassian.net/browse/HSEARCH-4703 ) ) * integrationtest/java/modules/orm-coordination-outbox-polling-lucene (if it’s easy - it’s a rather exotic combination). * And I would stop there for now. Note that those are smoke tests, so each test class should be fairly simple, basically just checking a roundtrip persist → index → search, with another test checking that Hibernate Search is actually running in the modulepath, just in case. See the existing test, org.hibernate.search.integrationtest.java.modules.service.JavaModulePathIT , for an example. In the long run we could have more complete smoke tests such as what’s described in https://hibernate.atlassian.net/browse/HSEARCH-3392 ( https://hibernate.atlassian.net/browse/HSEARCH-3392 ) , but that will require significantly more work so let’s not do that right now. ( https://hibernate.atlassian.net/browse/HSEARCH-4703#add-comment?atlOrigin... ) Add Comment ( https://hibernate.atlassian.net/browse/HSEARCH-4703#add-comment?atlOrigin... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=Em... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100207- sha1:591c2ef )