[hibernate-issues] [Hibernate-JIRA] Commented: (HSEARCH-572) a plea to reconsider deprecating luceneOptions.getStore(), luceneOptions.getIndex() etc

[ http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-572?pag... ] Sanne Grinovero commented on HSEARCH-572: ----------------------------------------- thanks for the example. Consider that some Solr modules are an (optional) dependency of Hibernate Search already; it's used for example to ease the definition of Analyzers, so you might be able to use the Solr code directly. It's not clear to me why you can't replace the lines {noformat}final Map<String, Object> map = (Map<String, Object>) value; for (final Map.Entry<String, Object> entry : map.entrySet()) { if (entry.getValue() == null){ continue; } final String propertyName =name+"."+ entry.getKey(); final String propertyValue = entry.getValue().toString(); final Field field = new Field(propertyName, propertyValue, luceneOptions.getStore(), luceneOptions.getIndex()); if (luceneOptions.getBoost() != null){ field.setBoost(luceneOptions.getBoost()); } document.add(field); } } {noformat} with the code: {noformat}final Map<String, Object> map = (Map<String, Object>) value; for ( final Map.Entry<String, Object> entry : map.entrySet() ) { if ( entry.getValue() == null ) { continue; } final String propertyName = name + "." + entry.getKey(); final String propertyValue = entry.getValue().toString(); luceneOptions.addFieldToDocument( propertyName, propertyValue, document ); }{noformat} BTW the latter is shorter and it benefits from isEmpty() check to skip it, supports compression on both Lucene <3 and >3 and might benefit from more features or optimizations in the future. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira