[hibernate-issues] [Hibernate-JIRA] Commented: (HSEARCH-323) Fault tolerant FSSlaveDirectoryProvider

[ http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-323?pag... ] Sanne Grinovero commented on HSEARCH-323: ----------------------------------------- Hi Oliver, thanks for the patch; I hope you'll have 30 minutes for some improvements: # could you please avoid changing all whitespaces? it doesn't apply on our code as-is, and I'm having an hard time trying to fix it by editing myself. # "throw new IllegalStateException(e);", I'd suggest to keep the IOException, or if you really need to wrap it in a runtime exception it's better to use the SearchException which we consistently use for those cases. I wouldn't consider it illegal to have a disk full ;) # dummyDirectory: this one will always be empty, right? Why not using a RAMDirectory instead of physically writing an index to disk? Also I wouldn't close it in the TriggerTask, some IndexReader might still be using it and cause collateral errors. If you where sure no reader could be using it yet, there would be no point in using a dummy at all - so I guess that in your use case it's actually being used. I think you could have it closed at the next task period, or if it gets too complex just leave it open. # Why starting a new TimerTask, couldn't we reuse the existing one? every time it triggers, it could check if we already performed proper initialization. It would make sense to have a separate InitTask if you wanted to configure initial retry periods on a different time base than the copy task, but it doesn't seem the case in the current patch. If you want you can add a new configuration property, make sure to document it. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira