[hibernate-issues] [Hibernate-JIRA] Updated: (HHH-5095) BasicLoader.isBag() checks type assignability wrongly

BasicLoader.isBag() checks type assignability wrongly ----------------------------------------------------- Key: HHH-5095 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-5095 Project: Hibernate Core Issue Type: Bug Components: core Affects Versions: 3.5.0-Final, 3.5.1 Environment: N/A Reporter: Matt Benson Assignee: Gail Badner Method defined as: {code} private boolean isBag(CollectionPersister collectionPersister) { return collectionPersister.getCollectionType().getClass().isAssignableFrom( BagType.class ); } {code} Will never return true if the returned CollectionType subclasses BagType; should IMO be: {code} private boolean isBag(CollectionPersister collectionPersister) { return BagType.class.isInstance( collectionPersister.getCollectionType() ); } {code} My humble apologies for the submission without a test case, but this one feels pretty simple. Thanks!