[Hibernate-JIRA] Created: (HSEARCH-285) Refactor DocumentBuilder to support containedIn only and regular Indexed entities

[Hibernate-JIRA] Created:...

Emmanuel Bernard (JIRA)

Thursday, 23 October 2008 Thu, 23 Oct '08

4:35 a.m.

Refactor DocumentBuilder to support containedIn only and regular Indexed entities --------------------------------------------------------------------------------- Key: HSEARCH-285 URL: http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-285 Project: Hibernate Search Issue Type: Improvement Reporter: Emmanuel Bernard Fix For: 3.1.0.CR1 Probably an inheritance approach would be better. There is a lot of "dead code" when contained in only entities are using DocumentBuilder (and a lot of inapropriate APIs). class ContainableEntityBuilder class IndexedEntityBuilder extends ContainableEntityBuilder (names to be refined) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

Show replies by date

Emmanuel Bernard (JIRA)

Thursday, 23 October Thu, 23 Oct

4:35 a.m.

New subject: [Hibernate-JIRA] Updated: (HSEARCH-285) Refactor DocumentBuilder to support containedIn only and regular Indexed entities

[ http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-285?pag... ] Emmanuel Bernard updated HSEARCH-285: ------------------------------------- Component/s: engine

...

Refactor DocumentBuilder to support containedIn only and regular Indexed entities --------------------------------------------------------------------------------- Key: HSEARCH-285 URL: http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-285 Project: Hibernate Search Issue Type: Improvement Components: engine Reporter: Emmanuel Bernard Fix For: 3.1.0.CR1 Probably an inheritance approach would be better. There is a lot of "dead code" when contained in only entities are using DocumentBuilder (and a lot of inapropriate APIs). class ContainableEntityBuilder class IndexedEntityBuilder extends ContainableEntityBuilder (names to be refined)

-- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

Hardy Ferentschik (JIRA)

Monday, 17 November Mon, 17 Nov

12:01 p.m.

New subject: [Hibernate-JIRA] Assigned: (HSEARCH-285) Refactor DocumentBuilder to support containedIn only and regular Indexed entities

[ http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-285?pag... ] Hardy Ferentschik reassigned HSEARCH-285: ----------------------------------------- Assignee: Hardy Ferentschik

...

Refactor DocumentBuilder to support containedIn only and regular Indexed entities --------------------------------------------------------------------------------- Key: HSEARCH-285 URL: http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-285 Project: Hibernate Search Issue Type: Improvement Components: engine Reporter: Emmanuel Bernard Assignee: Hardy Ferentschik Fix For: 3.1.0 Probably an inheritance approach would be better. There is a lot of "dead code" when contained in only entities are using DocumentBuilder (and a lot of inapropriate APIs). class ContainableEntityBuilder class IndexedEntityBuilder extends ContainableEntityBuilder (names to be refined)

Hardy Ferentschik (JIRA)

12:01 p.m.

New subject: [Hibernate-JIRA] Updated: (HSEARCH-285) Refactor DocumentBuilder to support containedIn only and regular Indexed entities

[ http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-285?pag... ] Hardy Ferentschik updated HSEARCH-285: -------------------------------------- Fix Version/s: (was: 3.1.0.CR1) 3.1.0

...

Refactor DocumentBuilder to support containedIn only and regular Indexed entities --------------------------------------------------------------------------------- Key: HSEARCH-285 URL: http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-285 Project: Hibernate Search Issue Type: Improvement Components: engine Reporter: Emmanuel Bernard Assignee: Hardy Ferentschik Fix For: 3.1.0 Probably an inheritance approach would be better. There is a lot of "dead code" when contained in only entities are using DocumentBuilder (and a lot of inapropriate APIs). class ContainableEntityBuilder class IndexedEntityBuilder extends ContainableEntityBuilder (names to be refined)

Hardy Ferentschik (JIRA)

Saturday, 22 November Sat, 22 Nov

1:20 p.m.

New subject: [Hibernate-JIRA] Commented: (HSEARCH-285) Refactor DocumentBuilder to support containedIn only and regular Indexed entities

...

Refactor DocumentBuilder to support containedIn only and regular Indexed entities --------------------------------------------------------------------------------- Key: HSEARCH-285 URL: http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-285 Project: Hibernate Search Issue Type: Improvement Components: engine Reporter: Emmanuel Bernard Assignee: Hardy Ferentschik Fix For: 3.1.0 Probably an inheritance approach would be better. There is a lot of "dead code" when contained in only entities are using DocumentBuilder (and a lot of inapropriate APIs). class ContainableEntityBuilder class IndexedEntityBuilder extends ContainableEntityBuilder (names to be refined)

Emmanuel Bernard (JIRA)

7:12 p.m.

New subject: [Hibernate-JIRA] Commented: (HSEARCH-285) Refactor DocumentBuilder to support containedIn only and regular Indexed entities

[ http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-285?pag... ] Emmanuel Bernard commented on HSEARCH-285: ------------------------------------------ ok

...

Refactor DocumentBuilder to support containedIn only and regular Indexed entities --------------------------------------------------------------------------------- Key: HSEARCH-285 URL: http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-285 Project: Hibernate Search Issue Type: Improvement Components: engine Reporter: Emmanuel Bernard Assignee: Hardy Ferentschik Fix For: 3.1.0 Probably an inheritance approach would be better. There is a lot of "dead code" when contained in only entities are using DocumentBuilder (and a lot of inapropriate APIs). class ContainableEntityBuilder class IndexedEntityBuilder extends ContainableEntityBuilder (names to be refined)

Emmanuel Bernard (JIRA)

Sunday, 23 November Sun, 23 Nov

9:53 p.m.

New subject: [Hibernate-JIRA] Commented: (HSEARCH-285) Refactor DocumentBuilder to support containedIn only and regular Indexed entities

[ http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-285?pag... ] Emmanuel Bernard commented on HSEARCH-285: ------------------------------------------ I haven't had a chance to look at the commit but the change breaks a bunch of apps. We need to keep DocumentBuilder.CLASS_FIELDNAME as it is. The book references it in several places.

...

Refactor DocumentBuilder to support containedIn only and regular Indexed entities --------------------------------------------------------------------------------- Key: HSEARCH-285 URL: http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-285 Project: Hibernate Search Issue Type: Improvement Components: engine Reporter: Emmanuel Bernard Assignee: Hardy Ferentschik Fix For: 3.1.0 Probably an inheritance approach would be better. There is a lot of "dead code" when contained in only entities are using DocumentBuilder (and a lot of inapropriate APIs). class ContainableEntityBuilder class IndexedEntityBuilder extends ContainableEntityBuilder (names to be refined)

Emmanuel Bernard (JIRA)

10:03 p.m.

New subject: [Hibernate-JIRA] Commented: (HSEARCH-285) Refactor DocumentBuilder to support containedIn only and regular Indexed entities

[ http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-285?pag... ] Emmanuel Bernard commented on HSEARCH-285: ------------------------------------------ an interface is good enough BTW

...

Refactor DocumentBuilder to support containedIn only and regular Indexed entities --------------------------------------------------------------------------------- Key: HSEARCH-285 URL: http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-285 Project: Hibernate Search Issue Type: Improvement Components: engine Reporter: Emmanuel Bernard Assignee: Hardy Ferentschik Fix For: 3.1.0 Probably an inheritance approach would be better. There is a lot of "dead code" when contained in only entities are using DocumentBuilder (and a lot of inapropriate APIs). class ContainableEntityBuilder class IndexedEntityBuilder extends ContainableEntityBuilder (names to be refined)

Hardy Ferentschik (JIRA)

10:05 p.m.

New subject: [Hibernate-JIRA] Commented: (HSEARCH-285) Refactor DocumentBuilder to support containedIn only and regular Indexed entities

[ http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-285?pag... ] Hardy Ferentschik commented on HSEARCH-285: ------------------------------------------- Actually i was hoping to move the DocumentBuilder.CLASS_FIELDNAME into ProjectionConstants in order to make the classname projectable. I believe there is a issue for that. But if we have to really keep it what do you suggest? Should be we introduce yet another base class or interface called DocumentBuilder for DocumentBuilderContainedEntity and DocumentBuilderIndexedEntity?

...

Refactor DocumentBuilder to support containedIn only and regular Indexed entities --------------------------------------------------------------------------------- Key: HSEARCH-285 URL: http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-285 Project: Hibernate Search Issue Type: Improvement Components: engine Reporter: Emmanuel Bernard Assignee: Hardy Ferentschik Fix For: 3.1.0 Probably an inheritance approach would be better. There is a lot of "dead code" when contained in only entities are using DocumentBuilder (and a lot of inapropriate APIs). class ContainableEntityBuilder class IndexedEntityBuilder extends ContainableEntityBuilder (names to be refined)

Emmanuel Bernard (JIRA)

10:15 p.m.

New subject: [Hibernate-JIRA] Commented: (HSEARCH-285) Refactor DocumentBuilder to support containedIn only and regular Indexed entities

[ http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-285?pag... ] Emmanuel Bernard commented on HSEARCH-285: ------------------------------------------ Hummmmm I guess it makes more sense to put this constant onto ProjectionConstants.OBJECT_CLASS It is slightly different semantically than the other constants, This is not a logical placeholder but the actual value used for the field name. This constant can be sued in plain Lucene query (contrary to the other ones). In any case, we need to reintroduce a DocumentBuilder interface with the constant on it and mark that as deprecated. This is a public API, we can't mess too much with it.

...

Refactor DocumentBuilder to support containedIn only and regular Indexed entities --------------------------------------------------------------------------------- Key: HSEARCH-285 URL: http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-285 Project: Hibernate Search Issue Type: Improvement Components: engine Reporter: Emmanuel Bernard Assignee: Hardy Ferentschik Fix For: 3.1.0 Probably an inheritance approach would be better. There is a lot of "dead code" when contained in only entities are using DocumentBuilder (and a lot of inapropriate APIs). class ContainableEntityBuilder class IndexedEntityBuilder extends ContainableEntityBuilder (names to be refined)

Emmanuel Bernard (JIRA)

10:17 p.m.

New subject: [Hibernate-JIRA] Commented: (HSEARCH-285) Refactor DocumentBuilder to support containedIn only and regular Indexed entities

...

Refactor DocumentBuilder to support containedIn only and regular Indexed entities --------------------------------------------------------------------------------- Key: HSEARCH-285 URL: http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-285 Project: Hibernate Search Issue Type: Improvement Components: engine Reporter: Emmanuel Bernard Assignee: Hardy Ferentschik Fix For: 3.1.0 Probably an inheritance approach would be better. There is a lot of "dead code" when contained in only entities are using DocumentBuilder (and a lot of inapropriate APIs). class ContainableEntityBuilder class IndexedEntityBuilder extends ContainableEntityBuilder (names to be refined)

Hardy Ferentschik (JIRA)

Monday, 24 November Mon, 24 Nov

11:13 a.m.

New subject: [Hibernate-JIRA] Commented: (HSEARCH-285) Refactor DocumentBuilder to support containedIn only and regular Indexed entities

[ http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-285?pag... ] Hardy Ferentschik commented on HSEARCH-285: ------------------------------------------- Works for me.

...

Refactor DocumentBuilder to support containedIn only and regular Indexed entities --------------------------------------------------------------------------------- Key: HSEARCH-285 URL: http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-285 Project: Hibernate Search Issue Type: Improvement Components: engine Reporter: Emmanuel Bernard Assignee: Hardy Ferentschik Fix For: 3.1.0 Probably an inheritance approach would be better. There is a lot of "dead code" when contained in only entities are using DocumentBuilder (and a lot of inapropriate APIs). class ContainableEntityBuilder class IndexedEntityBuilder extends ContainableEntityBuilder (names to be refined)

Hardy Ferentschik (JIRA)

12:47 p.m.

New subject: [Hibernate-JIRA] Commented: (HSEARCH-285) Refactor DocumentBuilder to support containedIn only and regular Indexed entities

[ http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-285?pag... ] Hardy Ferentschik commented on HSEARCH-285: ------------------------------------------- Added the DocumentBuilder interface and the CLASS_FIELDNAME constant. I deprecated the class, but did not replace occurrences of the constant in the code. I agree that it might cause some ambiguities. Maybe DocumentBuilder should not be deprecated??

...

Refactor DocumentBuilder to support containedIn only and regular Indexed entities --------------------------------------------------------------------------------- Key: HSEARCH-285 URL: http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-285 Project: Hibernate Search Issue Type: Improvement Components: engine Reporter: Emmanuel Bernard Assignee: Hardy Ferentschik Fix For: 3.1.0 Probably an inheritance approach would be better. There is a lot of "dead code" when contained in only entities are using DocumentBuilder (and a lot of inapropriate APIs). class ContainableEntityBuilder class IndexedEntityBuilder extends ContainableEntityBuilder (names to be refined)

Hardy Ferentschik (JIRA)

Monday, 1 December Mon, 1 Dec

5:57 p.m.

New subject: [Hibernate-JIRA] Resolved: (HSEARCH-285) Refactor DocumentBuilder to support containedIn only and regular Indexed entities

[ http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-285?pag... ] Hardy Ferentschik resolved HSEARCH-285. --------------------------------------- Resolution: Fixed Introduced a basic split into DocumentBuilderIndexedEntity and DocumentBuilderContainedEntity. Maybe there is more we could refactor, but this we should do after the GA release.

...

Refactor DocumentBuilder to support containedIn only and regular Indexed entities --------------------------------------------------------------------------------- Key: HSEARCH-285 URL: http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-285 Project: Hibernate Search Issue Type: Improvement Components: engine Reporter: Emmanuel Bernard Assignee: Hardy Ferentschik Fix For: 3.1.0 Probably an inheritance approach would be better. There is a lot of "dead code" when contained in only entities are using DocumentBuilder (and a lot of inapropriate APIs). class ContainableEntityBuilder class IndexedEntityBuilder extends ContainableEntityBuilder (names to be refined)

5876

days inactive

5915

days old

hibernate-issues@lists.jboss.org

Manage subscription

13 comments

2 participants

tags (0)

participants (2)

Emmanuel Bernard (JIRA)
Hardy Ferentschik (JIRA)

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

[Hibernate-JIRA] Created: (HSEARCH-285) Refactor DocumentBuilder to support containedIn only and regular Indexed entities