[ http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-153?pag... ] Sanne Grinovero updated HSEARCH-153: ------------------------------------ Attachment: patch.txt Hi, this includes the new feature, a trivial test case and some documentation updates. Also some refactoring has been done, so to make management of other parameters easier. I couldn't write a test case verifying that the parameters are actually set on the indexwriter, as I didn't manage to get visibility on the indexwriter; so tests just verify the options are picked up and don't break previous behavior. I think the "default values" management got simplified, it is no longer needed to have a copy of the values from lucene, it just skips the setter on undefined values. The "DEFAULT_MAX_BUFFERED_DOCS" is still set to 10, as it is different than the lucene defaults; I think it could be a bug and would be tempted to remove it, but will leave that decision to Emmanuel or Hardy; The lucene default is "not set it", so to use only RamBuffer as flush control limit. Also, it would be nice to have the option to put "null" in the configuration, to explicitly set options to "lucene default", without having to know them; Currently settings are inherited from "default" directoryprovider if any, and "batch" settings inherit from "transaction", so I think it could be useful explicitly setting some value to null. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-153?pag... ] Emmanuel Bernard updated HSEARCH-153: ------------------------------------- Description: I applied the patch. It was all good. I also apply the suggestion to delegate all defaults to Lucene. Two questions and remarks: - why is //batchIndexParameters.setMaxBufferedDocs(null); //batchIndexParameters.setRamBufferSizeMB(64); a better default than the one picked by the Lucene team? - I am for a "default" value, open a different JIRA issue for it. Fix Version/s: 3.1.0 -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-153?pag... ] Sanne Grinovero commented on HSEARCH-153: ----------------------------------------- about "batchIndexParameters.setRamBufferSizeMB(64); " : I'm sure the Lucene team knows how to set good defaults for general use, what I'm suggesting is to set a default for the "batch" indexing mode; For non-batch indexing mode the RamBufferSize is less critical, as I expect it to never fill the default value before a forced flush(), but in batch mode it has a great impact on performance: the IndexWriter javadoc recommends setting it as high as possible, so I was thinking in proposing a bit higher default for batch mode; maybe 64MB could be dangerous for people not setting JVM heap parameters(or automated testings), so maybe it's not a good idea and it could be better to just recommend the user to set a high setting (already done in docs). What do you mean with "I am for a "default" value, open a different JIRA issue for it."? Should I open another issue to discuss appropriate default values? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-153?pag... ] Sanne Grinovero commented on HSEARCH-153: ----------------------------------------- You're perfectly right, I agree. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira