[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-5562?page=c... ] Steve Ebersole updated HHH-5562: -------------------------------- Attachment: HHH-5562.patch Patch of initial attempt maintaining backwards compatibility. Unfortunately it lead to many regression errors which manifested in strange test failures that made it difficult to track down the real cause. Anyway I was not a fan of the hacks I needed to put in place for backwards compatibility. Lets revisit this for 4.x as we can drop the backwards compatibility (of exposing {{EventListeners}} directly from {{Configuration}} and {{SessionFactory}}). Specifics about the patch: # Really liked the "configuration time" aspect with the {{org.hibernate.event.EventListenerRegistry}} and {{org.hibernate.event.RegisteredEventListeners}} classes. Not sure about the names; perhaps {{EventListenerRegistry}} (listeners for given type) and {{EventListenerRegistryRegistry}} (listener registry, per type via map) are better # Really really liked the definition of org.hibernate.event.EventType # {{org.hibernate.event.spi.EventListenerRegistrationService}} defined the registration service contract, the idea being we'd look for a file named {{META-INF/org.hibernate.event.spi.EventListenerRegistrationService}} via classpath which would name implementations of {{org.hibernate.event.spi.EventListenerRegistrationService}} to load and execute # New explicit exception type for listener registration problems, rather than odd errors like ArrayStoreException etc -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-5562?page=c... ] Emmanuel Bernard commented on HHH-5562: --------------------------------------- A couple of remarks from my integration with HSearch 1. I would adjsut the API to allow the use of varargs when adding listeners EventListenerRegistry.appendListener(EventType<T> type, T listener) => EventListenerRegistry.appendListener(EventType<T> type, T... listener); EventListenerRegistry.appendListener(EventType<T> type, T listener, DuplicationResolutionStrategy dupStrategy) => EventListenerRegistry.appendListener(EventType<T> type, DuplicationResolutionStrategy dupStrategy, T... listener); 2. BV does META-INF/services/org.hibernate.event.spi.EventListenerRegistrationService and not META-INF/org.hibernate.event.spi.EventListenerRegistrationService I think that's aligned with the recommended approach for the service locator pattern 3. to check for duplication, you use isInstance which surprised me a bit. We might want to add a pluggable mechanism for the isDuplicateOf logi -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-5562?page=c... ] Emmanuel Bernard updated HHH-5562: ---------------------------------- Summary: Improve how event listeners are handled and introduce a service pattern for integrators to leverage (was: Improve how event listeners are handled and introduce a serivice pattern for integrators to leverage) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-5562?page=c... ] Steve Ebersole updated HHH-5562: -------------------------------- Fix Version/s: (was: 4.0.0.Alpha1) 4.0.0.Alpha3 -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-5562?page=c... ] Steve Ebersole closed HHH-5562. ------------------------------- Resolution: Fixed Fix Version/s: (was: 4.0.0.Alpha3) 4.0.0.Alpha2 -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-5562?page=c... ] Steve Ebersole closed HHH-5562. ------------------------------- Resolution: Fixed fixing subject -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira