[Hibernate-JIRA] Created: (HHH-3543) method org.hibernate.transaction.JDBCTransaction.notifyLocalSynchsBeforeTransactionCompletion "swallows" all exceptions occured inside it
6 a.m.
method
org.hibernate.transaction.JDBCTransaction.notifyLocalSynchsBeforeTransactionCompletion
"swallows" all exceptions occured inside it
-----------------------------------------------------------------------------------------------------------------------------------------
Key: HHH-3543
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3543
Project: Hibernate Core
Issue Type: Bug
Components: core
Affects Versions: 3.3.1
Environment: MS Windows XP SP2, JDK 1.6.8, Eclipse 3.2.0
Reporter: Roman
When using JBoss Envers any exceptions occured during saving data into version tables are
swallowed by code block in class org.hibernate.transaction.JDBCTransaction (line 273):
try {
sync.beforeCompletion();
}
catch (Throwable t) {
log.error("exception calling user Synchronization", t);
}
Thereby, any exceptions occured in sync.beforeCompletion() will only be shown in log, but
will not have any effect on application functionality
So I have such behaviour:
1. Entity changes are saved in database by hibernate
2. Version tables for entities are empty, because, for example, of invalid column names
3. Transaction commits successfully.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:28 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-3543) method org.hibernate.transaction.JDBCTransaction.notifyLocalSynchsBeforeTransactionCompletion "swallows" all exceptions occured inside it
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-3543?page=c...
]
Krasimir Chobantonov commented on HHH-3543:
-------------------------------------------
I have the same problem but with different hibernate listener (Hibernate Audit)
Workaround of this problem if using slf4j + log4j is the following ( the code needs to be
executed when the hibernate & log4j are initialized)
private static final org.apache.log4j.Logger JDBC_TRANSACTION_LOG =
org.apache.log4j.Logger.getLogger(JDBCTransaction.class);
// method that will call interceptLog()
private void interceptLog() {
if (Level.OFF.equals(JDBC_TRANSACTION_LOG.getLevel())) {
JDBC_TRANSACTION_LOG.setLevel(Level.ERROR);
}
JDBC_TRANSACTION_LOG.addAppender(new AppenderSkeleton() {
@Override
public boolean requiresLayout() {
return false;
}
@Override
public void close() {
}
@Override
protected void append(LoggingEvent event) {
if (event.getThrowableInformation().getThrowable() instanceof
ExceptionToPass) {
throw (ExceptionToPass)
event.getThrowableInformation().getThrowable();
}
}
});
}
Where ExceptionToPass is a runtime exception that is thrown by your listener.
Krasimir
method
org.hibernate.transaction.JDBCTransaction.notifyLocalSynchsBeforeTransactionCompletion
"swallows" all exceptions occured inside it
-----------------------------------------------------------------------------------------------------------------------------------------
Key: HHH-3543
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3543
Project: Hibernate Core
Issue Type: Bug
Components: core
Affects Versions: 3.3.1
Environment: MS Windows XP SP2, JDK 1.6.8, Eclipse 3.2.0
Reporter: Roman
Original Estimate: 4 days
Remaining Estimate: 4 days
When using JBoss Envers any exceptions occured during saving data into version tables are
swallowed by code block in class org.hibernate.transaction.JDBCTransaction (line 273):
try {
sync.beforeCompletion();
}
catch (Throwable t) {
log.error("exception calling user Synchronization", t);
}
Thereby, any exceptions occured in sync.beforeCompletion() will only be shown in log, but
will not have any effect on application functionality
So I have such behaviour:
1. Entity changes are saved in database by hibernate
2. Version tables for entities are empty, because, for example, of invalid column names
3. Transaction commits successfully.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:55 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-3543) method org.hibernate.transaction.JDBCTransaction.notifyLocalSynchsBeforeTransactionCompletion "swallows" all exceptions occured inside it
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-3543?page=c...
]
Silvan Eugen Lincan commented on HHH-3543:
------------------------------------------
Hi,
Since my http://opensource.atlassian.com/projects/hibernate/browse/HHH-4784 is a duplicate
of this one, probably I will move my comments here.
Until then, please see my comments there.
method
org.hibernate.transaction.JDBCTransaction.notifyLocalSynchsBeforeTransactionCompletion
"swallows" all exceptions occured inside it
-----------------------------------------------------------------------------------------------------------------------------------------
Key: HHH-3543
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3543
Project: Hibernate Core
Issue Type: Bug
Components: core
Affects Versions: 3.3.1
Environment: MS Windows XP SP2, JDK 1.6.8, Eclipse 3.2.0
Reporter: Roman
Original Estimate: 4 days
Remaining Estimate: 4 days
When using JBoss Envers any exceptions occured during saving data into version tables are
swallowed by code block in class org.hibernate.transaction.JDBCTransaction (line 273):
try {
sync.beforeCompletion();
}
catch (Throwable t) {
log.error("exception calling user Synchronization", t);
}
Thereby, any exceptions occured in sync.beforeCompletion() will only be shown in log, but
will not have any effect on application functionality
So I have such behaviour:
1. Entity changes are saved in database by hibernate
2. Version tables for entities are empty, because, for example, of invalid column names
3. Transaction commits successfully.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:12 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-3543) method org.hibernate.transaction.JDBCTransaction.notifyLocalSynchsBeforeTransactionCompletion "swallows" all exceptions occured inside it
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-3543?page=c...
]
Silvan Eugen Lincan commented on HHH-3543:
------------------------------------------
Hi again,
Sorry for delay, as promised, I attached a proposal patch on HHH-4784 for this problem.
method
org.hibernate.transaction.JDBCTransaction.notifyLocalSynchsBeforeTransactionCompletion
"swallows" all exceptions occured inside it
-----------------------------------------------------------------------------------------------------------------------------------------
Key: HHH-3543
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3543
Project: Hibernate Core
Issue Type: Bug
Components: core
Affects Versions: 3.3.1
Environment: MS Windows XP SP2, JDK 1.6.8, Eclipse 3.2.0
Reporter: Roman
Original Estimate: 4 days
Remaining Estimate: 4 days
When using JBoss Envers any exceptions occured during saving data into version tables are
swallowed by code block in class org.hibernate.transaction.JDBCTransaction (line 273):
try {
sync.beforeCompletion();
}
catch (Throwable t) {
log.error("exception calling user Synchronization", t);
}
Thereby, any exceptions occured in sync.beforeCompletion() will only be shown in log, but
will not have any effect on application functionality
So I have such behaviour:
1. Entity changes are saved in database by hibernate
2. Version tables for entities are empty, because, for example, of invalid column names
3. Transaction commits successfully.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:16 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-3543) method org.hibernate.transaction.JDBCTransaction.notifyLocalSynchsBeforeTransactionCompletion "swallows" all exceptions occured inside it
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-3543?page=c...
]
Silvan Eugen Lincan commented on HHH-3543:
------------------------------------------
I forgot to say that the patch is against the sources from
http://anonsvn.jboss.org/repos/hibernate/core/tags/hibernate-3.5.0-Final
method
org.hibernate.transaction.JDBCTransaction.notifyLocalSynchsBeforeTransactionCompletion
"swallows" all exceptions occured inside it
-----------------------------------------------------------------------------------------------------------------------------------------
Key: HHH-3543
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3543
Project: Hibernate Core
Issue Type: Bug
Components: core
Affects Versions: 3.3.1
Environment: MS Windows XP SP2, JDK 1.6.8, Eclipse 3.2.0
Reporter: Roman
Original Estimate: 4 days
Remaining Estimate: 4 days
When using JBoss Envers any exceptions occured during saving data into version tables are
swallowed by code block in class org.hibernate.transaction.JDBCTransaction (line 273):
try {
sync.beforeCompletion();
}
catch (Throwable t) {
log.error("exception calling user Synchronization", t);
}
Thereby, any exceptions occured in sync.beforeCompletion() will only be shown in log, but
will not have any effect on application functionality
So I have such behaviour:
1. Entity changes are saved in database by hibernate
2. Version tables for entities are empty, because, for example, of invalid column names
3. Transaction commits successfully.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:37 p.m.
New subject: [Hibernate-JIRA] Resolved: (HHH-3543) method org.hibernate.transaction.JDBCTransaction.notifyLocalSynchsBeforeTransactionCompletion "swallows" all exceptions occured inside it
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-3543?page=c...
]
Adam Warski resolved HHH-3543.
------------------------------
Assignee: Adam Warski
Resolution: Fixed
Fix Version/s: 3.5.x
As per Steve's Ebersole's suggestion, BeforeTransactionCompletionProcess is now
used instead of a transaction synchronization to properly handle exceptions.
method
org.hibernate.transaction.JDBCTransaction.notifyLocalSynchsBeforeTransactionCompletion
"swallows" all exceptions occured inside it
-----------------------------------------------------------------------------------------------------------------------------------------
Key: HHH-3543
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3543
Project: Hibernate Core
Issue Type: Bug
Components: core
Affects Versions: 3.3.1
Environment: MS Windows XP SP2, JDK 1.6.8, Eclipse 3.2.0
Reporter: Roman
Assignee: Adam Warski
Fix For: 3.5.x
Original Estimate: 4 days
Remaining Estimate: 4 days
When using JBoss Envers any exceptions occured during saving data into version tables are
swallowed by code block in class org.hibernate.transaction.JDBCTransaction (line 273):
try {
sync.beforeCompletion();
}
catch (Throwable t) {
log.error("exception calling user Synchronization", t);
}
Thereby, any exceptions occured in sync.beforeCompletion() will only be shown in log, but
will not have any effect on application functionality
So I have such behaviour:
1. Entity changes are saved in database by hibernate
2. Version tables for entities are empty, because, for example, of invalid column names
3. Transaction commits successfully.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:12 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-3543) method org.hibernate.transaction.JDBCTransaction.notifyLocalSynchsBeforeTransactionCompletion "swallows" all exceptions occured inside it
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-3543?page=c...
]
Sanne Grinovero commented on HHH-3543:
--------------------------------------
nice solution, but you likely need to update the title?
having "DBCTransaction.notifyLocalSynchsBeforeTransactionCompletion swallow the
transactions" is still true right? so I think we should either reject this and open
another for the Envers fix or rename this issue or it will be quite misleading in
changelogs.
method
org.hibernate.transaction.JDBCTransaction.notifyLocalSynchsBeforeTransactionCompletion
"swallows" all exceptions occured inside it
-----------------------------------------------------------------------------------------------------------------------------------------
Key: HHH-3543
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3543
Project: Hibernate Core
Issue Type: Bug
Components: core
Affects Versions: 3.3.1
Environment: MS Windows XP SP2, JDK 1.6.8, Eclipse 3.2.0
Reporter: Roman
Assignee: Adam Warski
Fix For: 3.5.x
Original Estimate: 32h
Remaining Estimate: 32h
When using JBoss Envers any exceptions occured during saving data into version tables are
swallowed by code block in class org.hibernate.transaction.JDBCTransaction (line 273):
try {
sync.beforeCompletion();
}
catch (Throwable t) {
log.error("exception calling user Synchronization", t);
}
Thereby, any exceptions occured in sync.beforeCompletion() will only be shown in log, but
will not have any effect on application functionality
So I have such behaviour:
1. Entity changes are saved in database by hibernate
2. Version tables for entities are empty, because, for example, of invalid column names
3. Transaction commits successfully.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:17 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-3543) method org.hibernate.transaction.JDBCTransaction.notifyLocalSynchsBeforeTransactionCompletion "swallows" all exceptions occured inside it
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-3543?page=c...
]
Adam Warski commented on HHH-3543:
----------------------------------
True. Although the original issue is with Envers, and that's fixed, so that's why
I closed it.
In fact, users can now choose which mechanizm to use (synchronization or process) if they
want the exceptions to propagate or not.
As I understood Steve, only logging the exceptions and not propagating them is the desired
behavior and will not change.
method
org.hibernate.transaction.JDBCTransaction.notifyLocalSynchsBeforeTransactionCompletion
"swallows" all exceptions occured inside it
-----------------------------------------------------------------------------------------------------------------------------------------
Key: HHH-3543
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3543
Project: Hibernate Core
Issue Type: Bug
Components: core
Affects Versions: 3.3.1
Environment: MS Windows XP SP2, JDK 1.6.8, Eclipse 3.2.0
Reporter: Roman
Assignee: Adam Warski
Fix For: 3.5.x
Original Estimate: 32h
Remaining Estimate: 32h
When using JBoss Envers any exceptions occured during saving data into version tables are
swallowed by code block in class org.hibernate.transaction.JDBCTransaction (line 273):
try {
sync.beforeCompletion();
}
catch (Throwable t) {
log.error("exception calling user Synchronization", t);
}
Thereby, any exceptions occured in sync.beforeCompletion() will only be shown in log, but
will not have any effect on application functionality
So I have such behaviour:
1. Entity changes are saved in database by hibernate
2. Version tables for entities are empty, because, for example, of invalid column names
3. Transaction commits successfully.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5373
days inactive
5906
days old
hibernate-issues@lists.jboss.org
7 comments
5 participants
participants (5)
-
Adam Warski (JIRA) -
Krasimir Chobantonov (JIRA)
-
Roman (JIRA)
-
Sanne Grinovero (JIRA)
-
Silvan Eugen Lincan (JIRA)