December 2006 - hibernate-issues - Jboss List Archives

[Hibernate-JIRA] Commented: (HHH-1646) Bad code in FastClass.equals

by Scott Marlow (JIRA)

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-1646?page=c... ] Scott Marlow commented on HHH-1646: ----------------------------------- I tried modifying org.hibernate.test.bytecode.BytecodeSuite (really org.hibernate.test.bytecode.javassist.ReflectionOptimizerTest.suite()) to recreate this bug but couldn't trigger FastClass.equals. I know that equals wasn't called because the call to Thread.dumpStack that I added didn't show up in the output. Yes, I'm removing the call to dumpstack. ;) > Bad code in FastClass.equals > ---------------------------- > > Key: HHH-1646 > URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-1646 > Project: Hibernate3 > Type: Bug > Versions: 3.1.3, 3.2.0 cr1 > Environment: 3.2.0 > Reporter: Niels Harremoës > Assignee: Scott Marlow > Priority: Blocker > Fix For: 3.2.2 > Attachments: FastClass.patch > > Original Estimate: 30 minutes > Remaining: 30 minutes > > In FastClass, the equals method is: > public boolean equals(Object o) { > if ( o == null || ( o instanceof FastClass ) ) { > return false; > } > return this.type.equals( ( ( FastClass ) o ).type ); > } > There's a missing ! - the first line should be > if ( o == null || ! ( o instanceof FastClass ) ) { -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

17 years, 10 months

1
0
0 / 0

[Hibernate-JIRA] Updated: (HHH-1646) Bad code in FastClass.equals

by Scott Marlow (JIRA)

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-1646?page=all ] Scott Marlow updated HHH-1646: ------------------------------ Fix Version: 3.2.2 Original Estimate: 30 minutes (was: 3 minutes) Remaining Estimate: 30 minutes (was: 3 minutes) > Bad code in FastClass.equals > ---------------------------- > > Key: HHH-1646 > URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-1646 > Project: Hibernate3 > Type: Bug > Versions: 3.1.3, 3.2.0 cr1 > Environment: 3.2.0 > Reporter: Niels Harremoës > Assignee: Scott Marlow > Priority: Blocker > Fix For: 3.2.2 > Attachments: FastClass.patch > > Original Estimate: 30 minutes > Remaining: 30 minutes > > In FastClass, the equals method is: > public boolean equals(Object o) { > if ( o == null || ( o instanceof FastClass ) ) { > return false; > } > return this.type.equals( ( ( FastClass ) o ).type ); > } > There's a missing ! - the first line should be > if ( o == null || ! ( o instanceof FastClass ) ) { -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

17 years, 10 months

1
0
0 / 0

[Hibernate-JIRA] Commented: (HHH-1646) Bad code in FastClass.equals

by Scott Marlow (JIRA)

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-1646?page=c... ] Scott Marlow commented on HHH-1646: ----------------------------------- instanceof X will return false if X is null. > Bad code in FastClass.equals > ---------------------------- > > Key: HHH-1646 > URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-1646 > Project: Hibernate3 > Type: Bug > Versions: 3.1.3, 3.2.0 cr1 > Environment: 3.2.0 > Reporter: Niels Harremoës > Assignee: Scott Marlow > Priority: Blocker > Attachments: FastClass.patch > > Original Estimate: 3 minutes > Remaining: 3 minutes > > In FastClass, the equals method is: > public boolean equals(Object o) { > if ( o == null || ( o instanceof FastClass ) ) { > return false; > } > return this.type.equals( ( ( FastClass ) o ).type ); > } > There's a missing ! - the first line should be > if ( o == null || ! ( o instanceof FastClass ) ) { -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

17 years, 10 months

1
0
0 / 0

[Hibernate-JIRA] Assigned: (HHH-1646) Bad code in FastClass.equals

by Scott Marlow (JIRA)

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-1646?page=all ] Scott Marlow reassigned HHH-1646: --------------------------------- Assign To: Scott Marlow > Bad code in FastClass.equals > ---------------------------- > > Key: HHH-1646 > URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-1646 > Project: Hibernate3 > Type: Bug > Versions: 3.1.3, 3.2.0 cr1 > Environment: 3.2.0 > Reporter: Niels Harremoës > Assignee: Scott Marlow > Priority: Blocker > Attachments: FastClass.patch > > Original Estimate: 3 minutes > Remaining: 3 minutes > > In FastClass, the equals method is: > public boolean equals(Object o) { > if ( o == null || ( o instanceof FastClass ) ) { > return false; > } > return this.type.equals( ( ( FastClass ) o ).type ); > } > There's a missing ! - the first line should be > if ( o == null || ! ( o instanceof FastClass ) ) { -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

17 years, 10 months

1
0
0 / 0

[Hibernate-JIRA] Created: (HHH-2303) generateTemporaryTableName in Oracle9Dialect does not truncate well

by Francois Jean (JIRA)

generateTemporaryTableName in Oracle9Dialect does not truncate well ------------------------------------------------------------------- Key: HHH-2303 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2303 Project: Hibernate3 Type: Patch Components: core Versions: 3.2.0.ga Environment: Hibernate 3.2, Oracle database Reporter: Francois Jean Priority: Minor Attachments: substring.patch In "org.hibernate.dialect.Oracle9Dialect" the method used to truncate the temporary table name removes the first character of the table name. I think that we should retain the first character. Using "name.substring( 0, 30 )" will return 30 character which should be ok for Oracle. I propose to change this method: public String generateTemporaryTableName(String baseTableName) { String name = super.generateTemporaryTableName(baseTableName); return name.length() > 30 ? name.substring( 1, 30 ) : name; } For: public String generateTemporaryTableName(String baseTableName) { String name = super.generateTemporaryTableName(baseTableName); return name.length() > 30 ? name.substring( 0, 30 ) : name; } François J. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

17 years, 10 months

1
0
0 / 0

[Hibernate-JIRA] Created: (HBX-830) Database errors should not be displayed in Log Error view

by Dariusz Tylus (JIRA)

Database errors should not be displayed in Log Error view --------------------------------------------------------- Key: HBX-830 URL: http://opensource.atlassian.com/projects/hibernate/browse/HBX-830 Project: Hibernate Tools Type: Improvement Components: eclipse Versions: 3.2beta8 Environment: Eclipse 3.2, Hibernate Tool 3.2 beta 8 Reporter: Dariusz Tylus When user select Refresh in eg reveng editor and there is an error during reading database schema user is not notyiied about an error and see the incompleat database schema in the three. Such situation is common when you are using Oracle database and there is problem with BIN tables. Evry errors are logged to the PDE Runtime -> Log Error View. This view is for eclipse developers not for applications programers. Database problems are application specific so they should not be diplayed in Log Error view. My sugestion is: 1. Notify the user about dtdabase error when the database schema is read. 2. Mark the database tree in reveng editor as incompleate. 3. Stop logging database errors to the Log Error view -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

17 years, 10 months

2
1
0 / 0

[Hibernate-JIRA] Created: (HBX-837) Have seperate logs per ConsoleConfiguration

by Max Rydahl Andersen (JIRA)

Have seperate logs per ConsoleConfiguration ------------------------------------------- Key: HBX-837 URL: http://opensource.atlassian.com/projects/hibernate/browse/HBX-837 Project: Hibernate Tools Type: New Feature Components: eclipse Versions: 3.2beta8 Reporter: Max Rydahl Andersen Fix For: 3.2beta9 currently we log every error/warning etc. from Hibernate into the eclipse plugin error view. We should have a seperate console log per configuration to show these instead of the error log view. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

17 years, 10 months

1
1
0 / 0

[Hibernate-JIRA] Commented: (HHH-1) Optimize Hibernate for the bulk insertion of related entities

by Martin Ross (JIRA)

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-1?page=comm... ] Martin Ross commented on HHH-1: ------------------------------- We are trying another way to sort the array. How do you order the sql strings? Or rather how to do you determine the order through the cascade mappings? Thanks, Martin > Optimize Hibernate for the bulk insertion of related entities > ------------------------------------------------------------- > > Key: HHH-1 > URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-1 > Project: Hibernate3 > Type: New Feature > Components: core > Environment: Hibernate 1.2, MySql 3.1 > Reporter: Bradley Leupen > Priority: Minor > > > It is currently difficult to batch the creation of persistent entities that maintain associations with other entities. > Add necessary api to hibernate to support the save or update of a collection of entities. An optimization can be applied in this scenario to group inserts / updates by entity class, or table. This will enable the hibernate engine to utilize batching if available, drastically improving performance over a network. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

17 years, 10 months

1
0
0 / 0

[Hibernate-JIRA] Commented: (HHH-1) Optimize Hibernate for the bulk insertion of related entities

by Adrian Lisenberg (JIRA)

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-1?page=comm... ] Adrian Lisenberg commented on HHH-1: ------------------------------------ Hi, I'm trying to solve this issue by implementing my own Batcher class. This Batcher, rader than just one PreparedStatement, has a collection of Statements, one for each sql string. Then I have a Comparator that knows the order of the sql strings (this should be based on cascade mappings). So when the flush is made, all the statements are commited in the right order. Do you think I´m missing something?? It seems to be working on my project... Thanks Adrian > Optimize Hibernate for the bulk insertion of related entities > ------------------------------------------------------------- > > Key: HHH-1 > URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-1 > Project: Hibernate3 > Type: New Feature > Components: core > Environment: Hibernate 1.2, MySql 3.1 > Reporter: Bradley Leupen > Priority: Minor > > > It is currently difficult to batch the creation of persistent entities that maintain associations with other entities. > Add necessary api to hibernate to support the save or update of a collection of entities. An optimization can be applied in this scenario to group inserts / updates by entity class, or table. This will enable the hibernate engine to utilize batching if available, drastically improving performance over a network. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

17 years, 10 months

1
0
0 / 0

[Hibernate-JIRA] Created: (ANN-494) Determine Referenced Entity For Embeddable types from the parameterised type

by Edward Costello (JIRA)

Determine Referenced Entity For Embeddable types from the parameterised type ---------------------------------------------------------------------------- Key: ANN-494 URL: http://opensource.atlassian.com/projects/hibernate/browse/ANN-494 Project: Hibernate Annotations Type: Improvement Components: binder Versions: 3.2.0.cr1 Reporter: Edward Costello When a collection is mapped using @ManyToOne or @CollectionOfElements, the entity in the collection is derived from the parametrised type of the collection. e.g. there is no need to explicitly indicate the elements of the following collection are books. @ManyToOne Set<Book> books; It would be nice if the same kind of discovery could be applied to Embeddable types when contained in a CollectionOfElements. E.g. it would be nice if Hibernate could derive that the embedded Versioned references a Book in the example below @CollectionOfElements Set<Versioned<Book>>; @Embeddable class Versioned<T> { T rightSide; Date date; } Even if it wasn't derived, it would be good to be able to specify it. Currently the only way to make the above work is to create a subclass of Versioned that explicitly binds the type parameter to Book. Without this the below exception is thrown while building the session factory Exception in thread "main" java.lang.IllegalStateException: Property rightSide has an unbound type and no explicit target entity. at org.hibernate.cfg.AnnotationBinder.addElementsOfAClass(AnnotationBinder.java:946) at org.hibernate.cfg.AnnotationBinder.fillComponent(AnnotationBinder.java:1655) at org.hibernate.cfg.annotations.CollectionBinder.bindManyToManySecondPass(CollectionBinder.java:1054) at org.hibernate.cfg.annotations.CollectionBinder.bindStarToManySecondPass(CollectionBinder.java:543) at org.hibernate.cfg.annotations.CollectionBinder$1.secondPass(CollectionBinder.java:484) at org.hibernate.cfg.CollectionSecondPass.doSecondPass(CollectionSecondPass.java:43) at org.hibernate.cfg.annotations.CollectionBinder.bind(CollectionBinder.java:377) at org.hibernate.cfg.AnnotationBinder.processElementAnnotations(AnnotationBinder.java:1476) at org.hibernate.cfg.AnnotationBinder.bindClass(AnnotationBinder.java:706) at org.hibernate.cfg.AnnotationConfiguration.processArtifactsOfType(AnnotationConfiguration.java:452) at org.hibernate.cfg.AnnotationConfiguration.secondPassCompile(AnnotationConfiguration.java:268) at org.hibernate.cfg.Configuration.buildSessionFactory(Configuration.java:1210) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

17 years, 10 months

3
14
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

hibernate-issues December 2006