[Hibernate-JIRA] Created: (HSEARCH-384) improve error messages for loading plugins and add consistency to the performed checks
by Sanne Grinovero (JIRA)
improve error messages for loading plugins and add consistency to the performed checks
--------------------------------------------------------------------------------------
Key: HSEARCH-384
URL: http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-384
Project: Hibernate Search
Issue Type: Improvement
Reporter: Sanne Grinovero
Assignee: Sanne Grinovero
Fix For: 3.2.0
the code of Hibernate Search is very extensible, as nearly all
internal modules are "overridable" by user provided implementation;
this external classes are loaded by defining a short name (in case of
built-in extensions) or fully qualified names to load
whatever is on the classpath to replace internals.
For some issues I'll soon have to be copy-pasting the usual exception
handling code around, again..
A quick regex count on the code base reveals that this same code is
duplicated in other 25 places, mostly correct but sometimes
forgetting to handle one or two cases (for example ClassCastException
is not handled often)
I am building a util class to get some consistency, and plan to unit
test this extensively to make sure it throws understandable exceptions
for the most common mistakes (hey, I need a public no-args
constructor! / not implementing the X interface! / ...)
-> DRY, improve error messages.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
15 years, 6 months
[Hibernate-JIRA] Created: (HHH-3759) c3p0 not starting with v3.3.1
by Mark Strecker (JIRA)
c3p0 not starting with v3.3.1
-----------------------------
Key: HHH-3759
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3759
Project: Hibernate Core
Issue Type: Bug
Components: core
Affects Versions: 3.3.1
Environment: 3.3.1GA
MySQL 5.0.45
Reporter: Mark Strecker
Using the hibernate.c3p0.* properties in the hibernate.cfg.xml file used to start c3p0 but now the built-in connection pool is used instead.
You can set : <property name="connection.provider_class">org.hibernate.connection.C3P0ConnectionProvider</property>
to work around this, but this is not necessary in 3.2.5GA and before. This also isn't documented anywhere and I fortunately found it in the forum.
Here is an example section in the hibernate.cfg.xml
<property name="hibernate.c3p0.acquire_increment">1</property>
<property name="hibernate.c3p0.idle_test_period">100</property> <!-- seconds -->
<property name="hibernate.c3p0.max_size">100</property>
<property name="hibernate.c3p0.max_statements">0</property>
<property name="hibernate.c3p0.min_size">1</property>
<property name="hibernate.c3p0.timeout">100</property> <!-- seconds -->
We discovered this while upgrading from 3.2.5GA to 3.3.1GA when the connections on our test server started getting JDBC Connection errors because MySQL kills them after 8 hours of inactivity.
This can be verified by turning on hibernate info logging and examining the log.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
15 years, 6 months
[Hibernate-JIRA] Created: (HBX-1129) <table-filter> and <table> tags too far away from each other
by Joachim Durchholz (JIRA)
<table-filter> and <table> tags too far away from each other
------------------------------------------------------------
Key: HBX-1129
URL: http://opensource.atlassian.com/projects/hibernate/browse/HBX-1129
Project: Hibernate Tools
Issue Type: New Feature
Components: reverse-engineer
Affects Versions: 3.2.4.GA
Environment: Irrelevant
Reporter: Joachim Durchholz
For reasons of performance (reverse engineering is slow on Oracle) and keeping the list of relevant tables under control (only 10% of tables in the database are used in Java code), I'm using a separate <table-filter> directive for each table.
This gives me a hibernate.reveng.xml like this:
<table-filter match-name="TABLE1" />
<table-filter match-name="TABLE2" />
... (dozens of additional declarations)
<table name="TABLE1">
...
</table>
<table name="TABLE2">
...
</table>
... (dozens more)
This means that the information pertaining to any specific table is distributed over two separate blocks in hibernate.reveng.xml, the <table-filter> block and the <table> block.
I see two approaches to improve this:
a) Relax the DTD so that <table-filter> and <table> can be freely mixed. This would allow to have a single block per file, and make empty separator lines between per-table blocks useful.
b) Automatically import a table if it's mentioned in a <table> tag (or in a foreign key) and wasn't imported through a <table-filter> tag already.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
15 years, 6 months
[Hibernate-JIRA] Created: (HBX-1082) Creating a formula property when reverse engineering
by Anders Reinhardt Hansen (JIRA)
Creating a formula property when reverse engineering
----------------------------------------------------
Key: HBX-1082
URL: http://opensource.atlassian.com/projects/hibernate/browse/HBX-1082
Project: Hibernate Tools
Issue Type: Improvement
Components: reverse-engineer
Affects Versions: 3.2.beta11
Environment: All environments
Reporter: Anders Reinhardt Hansen
Priority: Minor
Having lots of formula properties in mapping files is quite frustrating when reverse engineering database changes.
Therefore it would be a big help if there was a way to write formula properties in the Hibernate Reverse Engineering files.
A property formula is a property of a mapping file which is calculated by hibernate.
I.e.
<class name="XXX">
<column name="xxx" type="xxx" formula="(coloumn1+coloumn2)/coloumn3"/>
</class>
the reveng file could look like this
<hibernate-reverse-engineering>
...
<formula name="xxx" type="xxx" formula="(coloumn1+coloumn2)/coloumn3"/>
</hibernate-reverse-engineering>
Maybe the reverse engineering file is not the correct place for this feature. Suggestions are welcome
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
15 years, 6 months
[Hibernate-JIRA] Created: (HBX-1128) Fully generate hibernate.cfg.xml from hibernate.reveng.xml
by Joachim Durchholz (JIRA)
Fully generate hibernate.cfg.xml from hibernate.reveng.xml
----------------------------------------------------------
Key: HBX-1128
URL: http://opensource.atlassian.com/projects/hibernate/browse/HBX-1128
Project: Hibernate Tools
Issue Type: New Feature
Components: reverse-engineer
Affects Versions: 3.2.4.GA
Environment: Irrelevant.
Reporter: Joachim Durchholz
Currently, reverse engineering just updates hibernate.cfg.xml with those settings that it knows about and leaves the rest alone. This has two drawbacks:
* The information about database structure is scattered across two files, namely hibernate.reveng.xml and and hibernate.cfg.xml.
* When editing hibernate.cfg.xml, it's not instantly clear which parts of the configuration will be overwritten by the next reverse engineering run and which will persist.
For this reason, I'd like to suggest adding a mechanism to reveng.hibernate.xml that allows specifying arbitrary XML tags and attributes to be copied over to hibernate.cfg.xml. (One example might be a <cfg> tag that has its contents copied over to hibernate.cfg.xml.)
To make sure that no unwanted information in hibernate.cfg.xml survives, one could either add a new <purge-cfg> tag with a yes/no choice to decide whether hibernate.cfg.xml should be rewritten from scratch or retained. (It may make sense to implement a more fine-grained control over what to purge and what to keep. That might solve #HBX-1046.)
In an environment where the database model is the leading data model and the Java code has to follow, this would allow validating Java applications against database changes: do another round of reverse engineering and fix the Java compiler errors.
This is not a complete solution since changes in field widths and constraints won't stick out, but it would already be helpful.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
15 years, 6 months