October 2022 - hibernate-issues - Jboss List Archives

[JIRA] (HHH-15616) Mitigate performance impact of entity enhancement on Klass's _secondary_super_cache

by Sanne Grinovero (JIRA)

Sanne Grinovero ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *created* an issue Hibernate ORM ( https://hibernate.atlassian.net/browse/HHH?atlOrigin=eyJpIjoiMDc0N2E5MTVm... ) / Improvement ( https://hibernate.atlassian.net/browse/HHH-15616?atlOrigin=eyJpIjoiMDc0N2... ) HHH-15616 ( https://hibernate.atlassian.net/browse/HHH-15616?atlOrigin=eyJpIjoiMDc0N2... ) Mitigate performance impact of entity enhancement on Klass's _secondary_super_cache ( https://hibernate.atlassian.net/browse/HHH-15616?atlOrigin=eyJpIjoiMDc0N2... ) Issue Type: Improvement Assignee: Sanne Grinovero ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) Components: hibernate-core Created: 19/Oct/2022 10:47 AM Priority: Major Reporter: Sanne Grinovero ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) We’ve recently become aware of JDK’s limitation https://bugs.openjdk.org/browse/JDK-8180450 ( https://bugs.openjdk.org/browse/JDK-8180450 ) and an investigation via https://github.com/franz1981/type-pollution-agent/ ( https://github.com/franz1981/type-pollution-agent/ ) revealed that Hibernate ORM is affected via various paths. One of the most significant areas of concern surrounds the techniques used to handle bytecode enhanced entities; the agent reports the following: 1: io.quarkus.benchmark.model.World Count: 51703308 Types: org.hibernate.engine.spi.PersistentAttributeInterceptable org.hibernate.engine.spi.ManagedEntity org.hibernate.engine.spi.SelfDirtinessTracker org.hibernate.engine.spi.Managed Traces: org.hibernate.engine.internal.EntityEntryContext.getAssociatedManagedEntity(EntityEntryContext.java:153) class: org.hibernate.engine.spi.ManagedEntity count: 12108604 org.hibernate.engine.internal.EntityEntryContext.getAssociatedManagedEntity(EntityEntryContext.java:154) class: org.hibernate.engine.spi.ManagedEntity count: 6511885 org.hibernate.property.access.spi.EnhancedSetterImpl.set(EnhancedSetterImpl.java:49) class: org.hibernate.engine.spi.PersistentAttributeInterceptable count: 4770509 org.hibernate.tuple.entity.PojoEntityTuplizer.afterInitialize(PojoEntityTuplizer.java:227) class: org.hibernate.engine.spi.SelfDirtinessTracker count: 4762608 org.hibernate.tuple.entity.PojoEntityTuplizer.afterInitialize(PojoEntityTuplizer.java:210) class: org.hibernate.engine.spi.PersistentAttributeInterceptable count: 3617911 org.hibernate.tuple.entity.PojoEntityTuplizer.afterInitialize(PojoEntityTuplizer.java:228) class: org.hibernate.engine.spi.SelfDirtinessTracker count: 3325834 org.hibernate.tuple.entity.BytecodeEnhancementMetadataPojoImpl.extractLazyInterceptor(BytecodeEnhancementMetadataPojoImpl.java:271) class: org.hibernate.engine.spi.PersistentAttributeInterceptable count: 2883597 org.hibernate.tuple.entity.PojoEntityInstantiator.applyInterception(PojoEntityInstantiator.java:55) class: org.hibernate.engine.spi.PersistentAttributeInterceptable count: 2740804 org.hibernate.engine.internal.StatefulPersistenceContext.clear(StatefulPersistenceContext.java:236) class: org.hibernate.engine.spi.PersistentAttributeInterceptable count: 2617366 org.hibernate.property.access.spi.EnhancedSetterImpl.set(EnhancedSetterImpl.java:50) class: org.hibernate.engine.spi.PersistentAttributeInterceptable count: 2560881 org.hibernate.tuple.entity.AbstractEntityTuplizer.linkToSession(AbstractEntityTuplizer.java:717) class: org.hibernate.engine.spi.PersistentAttributeInterceptable count: 1705389 org.hibernate.engine.internal.StatefulPersistenceContext.clear(StatefulPersistenceContext.java:237) class: org.hibernate.engine.spi.PersistentAttributeInterceptable count: 1464702 org.hibernate.engine.internal.EntityEntryContext.addEntityEntry(EntityEntryContext.java:94) class: org.hibernate.engine.spi.ManagedEntity count: 1391146 org.hibernate.engine.internal.EntityEntryContext.addEntityEntry(EntityEntryContext.java:96) class: org.hibernate.engine.spi.ManagedEntity count: 1242069 org.hibernate.property.access.internal.PropertyAccessStrategyResolverStandardImpl.resolvePropertyAccessStrategy(PropertyAccessStrategyResolverStandardImpl.java:40) class: org.hibernate.engine.spi.Managed count: 2 org.hibernate.tuple.entity.PojoEntityInstantiator.<init>(PojoEntityInstantiator.java:38) class: org.hibernate.engine.spi.PersistentAttributeInterceptable count: 1 -------------------------- Source code matches Hibernate ORM version 5.6.12.Final - and while the agent is prone to reporting false positives, we believe this is not the case. This issue has - surprisingly - eluded performance diagnostic tools so far, and yet has very significant impact on performance; scalability is particularly affected as an high number of cache to cache communication is triggered, including via false sharing of the type cache information. I believe we can, at least partially, mitigage the performance hit via a minor refactoring which could be applied to both ORM 5.6 and 6+; a better and more thourough analysis will follow separately but will not be backported to older ORM versions. ( https://hibernate.atlassian.net/browse/HHH-15616#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-15616#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100209- sha1:5f5cf47 )

2 years, 3 months

1
0
0 / 0

[JIRA] (HHH-15558) Hibernate's Gradle plugin does not work with three-part source set names

by Andy Wilkinson (JIRA)

Andy Wilkinson ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *commented* on HHH-15558 ( https://hibernate.atlassian.net/browse/HHH-15558?atlOrigin=eyJpIjoiMDJkZD... ) Re: Hibernate's Gradle plugin does not work with three-part source set names ( https://hibernate.atlassian.net/browse/HHH-15558?atlOrigin=eyJpIjoiMDJkZD... ) I’ve tested against the current head of the main branch (`049d1512`) and the problem no longer occurs. Thanks for the fix. ( https://hibernate.atlassian.net/browse/HHH-15558#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-15558#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100209- sha1:5f5cf47 )

2 years, 3 months

1
0
0 / 0

[JIRA] (HHH-15612) Bad SQL generation when using entity graph with ON clause on query

by Christian Beikov (JIRA)

Christian Beikov ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *commented* on HHH-15612 ( https://hibernate.atlassian.net/browse/HHH-15612?atlOrigin=eyJpIjoiMjI1NG... ) Re: Bad SQL generation when using entity graph with ON clause on query ( https://hibernate.atlassian.net/browse/HHH-15612?atlOrigin=eyJpIjoiMjI1NG... ) Note that the additional join in your case is added because the explicit join in your query can not be reused for fetching of the association. This is because you use a custom ON clause. Note that it would not be safe to use the data from that SQL join because if you change the collection, Hibernate might remove rows which were previously filtered out through your condition. ( https://hibernate.atlassian.net/browse/HHH-15612#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-15612#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100209- sha1:5f5cf47 )

2 years, 3 months

1
0
0 / 0

[JIRA] (HHH-15612) Bad SQL generation when using entity graph with ON clause on query

by Christian Beikov (JIRA)

Christian Beikov ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *commented* on HHH-15612 ( https://hibernate.atlassian.net/browse/HHH-15612?atlOrigin=eyJpIjoiNDI1Nj... ) Re: Bad SQL generation when using entity graph with ON clause on query ( https://hibernate.atlassian.net/browse/HHH-15612?atlOrigin=eyJpIjoiNDI1Nj... ) Thanks for the report. >I also have an issue where Criteria API ignores a custom Converter that I’m using to convert VARCHAR to Boolean using spanish characters. With JPQL the same converter is working. Should I create a new issue? Yes, please create a separate issue with a reproducer 🙂 ( https://hibernate.atlassian.net/browse/HHH-15612#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-15612#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100209- sha1:5f5cf47 )

2 years, 3 months

1
0
0 / 0

[JIRA] (HHH-15612) Bad SQL generation when using entity graph with ON clause on query

by Christian Beikov (JIRA)

2 years, 3 months

1
0
0 / 0

[JIRA] (HHH-14397) Even with SQL Server 2019, the 2100 parameter limit is still being enforced

by Christian Beikov (JIRA)

Christian Beikov ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *closed* an issue as *Incomplete* I waited long enough for an answer, but didn't receive one. I don't mind removing the limit, but I need a reference for this. We can reopen the issue when you can show me documentation that says e.g. with version 2019, there is no more limit. Hibernate ORM ( https://hibernate.atlassian.net/browse/HHH?atlOrigin=eyJpIjoiMjMyNjg0NGQ0... ) / Bug ( https://hibernate.atlassian.net/browse/HHH-14397?atlOrigin=eyJpIjoiMjMyNj... ) HHH-14397 ( https://hibernate.atlassian.net/browse/HHH-14397?atlOrigin=eyJpIjoiMjMyNj... ) Even with SQL Server 2019, the 2100 parameter limit is still being enforced ( https://hibernate.atlassian.net/browse/HHH-14397?atlOrigin=eyJpIjoiMjMyNj... ) Change By: Christian Beikov ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) Resolution: Incomplete Status: Open Closed ( https://hibernate.atlassian.net/browse/HHH-14397#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-14397#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100209- sha1:5f5cf47 )

2 years, 3 months

1
0
0 / 0

[JIRA] (HHH-15605) Parameter binding of converted TemporalJavaType fails

by Christian Beikov (JIRA)

2 years, 3 months

1
0
0 / 0

[JIRA] (HHH-13927) Problem with JPA converters

by Christian Beikov (JIRA)

2 years, 3 months

1
0
0 / 0

[JIRA] (HHH-15493) allow Java record as @IdClass

by Christian Beikov (JIRA)

2 years, 3 months

1
0
0 / 0

[JIRA] (HHH-14676) PostgreSQLSkipAutoCommitTest ends up with a NPE on PostgreSQL Plus 13.1

by Christian Beikov (JIRA)

2 years, 3 months

1
0
0 / 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

hibernate-issues October 2022