October 2022 - hibernate-issues - Jboss List Archives

[JIRA] (HHH-15611) CustomEntityDirtinessStrategy is always calling findDirty independent whether canDirtyCheck would return true

by jwedding (JIRA)

jwedding ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=60a7b6e... ) *updated* an issue Hibernate ORM ( https://hibernate.atlassian.net/browse/HHH?atlOrigin=eyJpIjoiYTEzZjk1MTQ2... ) / Bug ( https://hibernate.atlassian.net/browse/HHH-15611?atlOrigin=eyJpIjoiYTEzZj... ) HHH-15611 ( https://hibernate.atlassian.net/browse/HHH-15611?atlOrigin=eyJpIjoiYTEzZj... ) CustomEntityDirtinessStrategy is always calling findDirty independent whether canDirtyCheck would return true ( https://hibernate.atlassian.net/browse/HHH-15611?atlOrigin=eyJpIjoiYTEzZj... ) Change By: jwedding ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=60a7b6e... ) Hi, I noticed a kind of inconvenient/inconsistent behaviour when using {{CustomEntityDirtinessStrategy}}: For checking whether an entity in general is dirty, a call to {{canDirtyCheck}} is made (which is fine): 5.6 / 6.1: [https://github.com/hibernate/hibernate-orm/blob/5.6/hibernate-core/src/ma...] // [https://github.com/hibernate/hibernate-orm/blob/6.1/hibernate-core/src/ma...] But then when searching for dirty attributes, the same check is not made anymore to the {{CustomEntityDirtinessStrategy}} therefore calling {{findDirty}}, even if the strategy is not capable of defining if the entity (and in my opinion implicitly its attributes) are dirty 5.6 // 6.1: [https://github.com/hibernate/hibernate-orm/blob/5.6/hibernate-core/src/ma...] // [https://github.com/hibernate/hibernate-orm/blob/6.1/hibernate-core/src/ma...] This is not docuemented documented and actually not expected in my opinion… ( https://hibernate.atlassian.net/browse/HHH-15611#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-15611#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100209- sha1:597f6a7 )

2 years, 2 months

1
0
0 / 0

[JIRA] (HHH-15611) CustomEntityDirtinessStrategy is always calling findDirty independent whether canDirtyCheck would return true

by jwedding (JIRA)

2 years, 2 months

1
0
0 / 0

[JIRA] (HHH-15610) Try getting rid of CacheKeyValueDescriptor

by Christian Beikov (JIRA)

Christian Beikov ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *created* an issue Hibernate ORM ( https://hibernate.atlassian.net/browse/HHH?atlOrigin=eyJpIjoiN2IyYmI2YTdl... ) / Improvement ( https://hibernate.atlassian.net/browse/HHH-15610?atlOrigin=eyJpIjoiN2IyYm... ) HHH-15610 ( https://hibernate.atlassian.net/browse/HHH-15610?atlOrigin=eyJpIjoiN2IyYm... ) Try getting rid of CacheKeyValueDescriptor ( https://hibernate.atlassian.net/browse/HHH-15610?atlOrigin=eyJpIjoiN2IyYm... ) Issue Type: Improvement Affects Versions: 6.1.4 Assignee: Christian Beikov ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) Components: hibernate-core Created: 18/Oct/2022 05:34 AM Priority: Major Reporter: Christian Beikov ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) It seems that the fix for https://hibernate.atlassian.net/browse/HHH-15500 ( https://hibernate.atlassian.net/browse/HHH-15500 ) was not really satisfactory for some use cases. After digging a bit into this, I found out that NaturalIdCacheKey uses Type#disassemble instead. I think it might have been an error to introduce CacheKeyValueDescriptor and we should instead rely on Type#disassemble in the CacheKeyImplementation as well. We might want to clarify the contract in Type#disassemble a bit though, as one of the implications of such a usage is, that the method must produce objects for which we can use Objects#deepEquals instead of JavaType#areEqual. ( https://hibernate.atlassian.net/browse/HHH-15610#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-15610#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100209- sha1:597f6a7 )

2 years, 2 months

1
0
0 / 0

[JIRA] (HHH-15528) Add Cockroach to Jenkins nightly test matrix and fix issues

by Christian Beikov (JIRA)

2 years, 2 months

1
0
0 / 0

[JIRA] (HSEARCH-4460) Fix failing GitHub actions build

by Yoann Rodière (JIRA)

2 years, 2 months

1
0
0 / 0

[JIRA] (HSEARCH-4702) Move build-related modules to the build directory

by Yoann Rodière (JIRA)

2 years, 2 months

1
0
0 / 0

[JIRA] (HHH-15500) Cache key is huge since migration to 6

by Christian Beikov (JIRA)

Christian Beikov ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *commented* on HHH-15500 ( https://hibernate.atlassian.net/browse/HHH-15500?atlOrigin=eyJpIjoiNGY1MG... ) Re: Cache key is huge since migration to 6 ( https://hibernate.atlassian.net/browse/HHH-15500?atlOrigin=eyJpIjoiNGY1MG... ) Please share the entity class and composite id type you are using. For composite ids there is maybe further optimization potential, but there are limits to what we can do. I think that it would be best if the cache would simple ignore the CacheKeyValueDescriptor cacheKeyValueDescriptor field when serializing CacheKeyImplementation , since that won’t be used by the remote cache anyway. ( https://hibernate.atlassian.net/browse/HHH-15500#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-15500#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100209- sha1:597f6a7 )

2 years, 2 months

1
0
0 / 0

[JIRA] (HHH-15500) Cache key is huge since migration to 6

by Dave Myron (JIRA)

Dave Myron ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=5d8e891... ) *commented* on HHH-15500 ( https://hibernate.atlassian.net/browse/HHH-15500?atlOrigin=eyJpIjoiY2UyZW... ) Re: Cache key is huge since migration to 6 ( https://hibernate.atlassian.net/browse/HHH-15500?atlOrigin=eyJpIjoiY2UyZW... ) We’re still getting very large keys with 6.1.4. And it seems like it’s generating unique keys for every instance of the same entity (very confusing). Here’s an example of a key with 6.1.4. "\x9a\x17l\x04\x04\t>3org.hibernate.cache.int\x01\x10\bl.C\x01\x0fxKeyImplementation\xe0\x02\xdb\xd8ej\x84\xdf\x00\x00\x00\x05>\x17\x053\xf0JKeyValueDescriptor\x16\x00>\x10entityOrRoleName\x16\x00>\bhashCode#\x00>\x02id\x16\x00>\btenantId\x16\x00\x16\x04\t>=v\x91\x00\x1component\x11\x9a:v\x00@\x17\xe9Z\x9a\xbb.%\xf4\x00\x00\x00\x02>\x04rol\x01t\xb8\x0esessionFactory\x16\x00\x16>Bcom.truenorthservice.nydus.9\x0e\x05\xc08ies.ShortcodeOp!\x01 #{id}\x048>)6\xac\x0057\x00S2p\x00!=h\xf2\x1f\x16\x85\x0b\xec\x9c\x8a\x00\x00\x00\x04>\x11delayedDropAc\x01Qx\x16\x00>\x16jpaPersistenceUnitUtil\x16\x00>\x04n);\x0c\x04uui!%\x14\x01\x04\t>2o2\xb7\x01\bjpa\x19~JF\x00\x01\x83\x18\xcc\x8b\xd3<\x12\x0c\xe5\x01\x83\xc8\x019\xf6\x16\x00\x169\xfd\x01>$1125a9ce-17d9-4b07-8583-105963249a2a5>=c\xee/\x01\x1c\xf8\xbai\xd5\x04\t>?\xf2t\x01\bPk\x00\t\x01\x00\x01%\xdc\x04\x06o%\x8a\x10\x16\x00>\ts1\x9d\x18\x16\x00\x16\x04\t>46\x1b\x01\xd0proxy.pojo.bytebuddy.SerializableProxy0,\xb9\xe6\\\xa1\x87\x8b\x00\x00\x00\b>\x0fcQf\x10IdTypAC\b\x1bidA\r`fierGetterMethodClass\x16\x00>\x1aV\x1f\x00\x00N)\xb9\x1d=\x00Sv=\x00.\x1f\x00\r=\x00\x1c\x19[.\x1e\x00\x10Param\x01{\x00\nEv\x0cface\x01\x0e\x04\x0fpQC\x00t\r\x9c\b\t>-N\x11\x01\x1cAbstractB\n\x01\x1c=ZL\x0f\xde\xcb\xd8\te\xddX\x1ballowLoadOutsideTransaE\xb4\x0c \x00>\n!\x14\x04ty\t\xaaD9\xde\x16\x00>\breadOnly\x16\x00>\x126w\x03\x00UI\xbe\b\x00>4\xb6\b\x02is0K\x00\x00\x00\x11P\x01\x01\x04\x15\t>8\xb6A\x00\x10BaseE\x85\x8aIAEB\b\x019\xd9\x81\b0\x05getId\x04\x15;\xff>\x05s\x01\x0bDB\x01\x15\x04\x15\a\x00\x00\x00\x14java.io..\"\x01\x15\x1e\x00\"NT\x01\x00H\xb1GES\x10\x04\x15\t9\xfa\x1dr$\a>\bcampaig!;\x00\x0f\x11\x0cXMessage \x00>\acompany \x00>\x05d\xa1H,\x16\x00>\x0cexpectsV\xa1]< \x009\xdb\x16\x009\xe4 \x00;\xfc\x04\t>7\xb6\a\x01\x95\xc4Pw\x02\x80\xa3 \xde\aq\x00\x00\x00\x0e>\naggrega\xa9\xb20\x04code\x16\x009\xfa\x16\x00>\x0b\x05\x84\x00iqg<\x16deviceLookupCree\x10\x00a\x81\xa0\x04\x14d\x1d\x1a\x14Thrott\xa5w\x14\remail\x1d\x11(\nmmsProgram\x01`\bmms\x1d\x1d\x18\apartne\x01\xf5\b\x0brc.\x1a\x00\x00\x10u\xe1I\x0bA\xe8\x04\ns2K\x00\x00s.K\x00(;\xfbK\x00\x00\x03\xfa\x04;\xf9\x00\xbe+\x02\x00A5\r\x10K\x00\x00\x00dEp\x10;\xfb9\xe6\x04\x01\x06\x00\xe7%\xfe\x04;\xfc\t\a\x00\xfd!\xe0\x00\xfd2\xe0\x01\x00\x0f.\t\x01\x04Ur!\x1c(\x0bmaxFileSiz\xc1\xf2\x10\nmm7Va\xa2\x00o\x81\xba$\x0cmmsSubmit\x05-\x049\xc4!\xf1\x00s2\x14\x00\b>\x04t\x85\x814;\xfa>\x042865\x04;\xf8\x00>5\xb6\xf9\x01\xe14\bany\x01\xd2\x00J\t\xd2 \xfa9\xdb\x04\x15;\xfa9\xdc\t\xcb\x00\xfb\t\a\x00\xfc>\xd2\x008\x029\xbd\x16\x009\xbe\x16\x00;\xf9\x01\x04;\xf7\xc2N\x01\x00CU&!\x91\x00\xe8\t| \xf99\xd7\x04\x15;\xf99\xd8\tu\x00\xfa\t\a\x00\xfb\x05|\x1c\x06\xbe\xf1\xea\n\xabL\xa3\xe5& \x10authoriz\x12t\bDKey\x16\x009\xe0\x16\x00>\bpasswor\x12<\b\x04us\x0e\xa9\b(me\x16\x00;\xf8\x01\x01\x04;\xf6\xc2\x1e\x01M\x91\x01\xa2\x00\xed\t\xa2 \xf89\xd0\x04\x15;\xf89\xd1\t\x9b\x00\xf9\t\a\x00\xfa>\xa2\x00\x0c\x03>\nc\x15\xe1\x0c\x16\x009\xb1\xc1\x8c\x00pI\xdf,Id\x16\x00;\xf7\x04;\xf5\x00>6\xb6\xad\x01q\x12\x01\x90\x00\xeb\t\x90 \xf79\xca\x04\x15;\xf79\xcb\t\x89\x00\xf8\t\a\x00\xf9\x05\x904\t\xe4\x01\x806\xb9X\x0f\x00\x00\x00\x039\xac\x0e-\b@rate'\x00>\nunitOfRat!\x1c\x04\xf6\x01\x0e5\b\x00*6\xb5\x04\x10colle\xa5\xcb\x0c.spi&7\b(tSet\x9b\xb9\xc6\x97\xc1\x17\xce\xe1t(\x01>\x03set\x16\x00\t>9r@\x00\xd1R\"\x7f\b\x04tC\x15a43\xa4\xb0J<\xf0F\x0c\x00\x00\x00\x0b9\xbc\xc1:\x126\n\x00dm\x17\x10\x05dirt\x81\xf8\x0c\x0eele\x0eg\n8Removed \x00>\x0binit\xe5\xac\x05\x0f\x18\risTemp\x1aa\t\x10 \x00>\x03kA\x19\x0c>\x05ow\x85<\x909\x99\x16\x009\xb8\x16\x00>\x0estoredSnapshot\x16\x00\x16\x00\xff\xff\xff\xff\x00\x00\x00\x00K\x81\x1e\x0c9\xd1>H\xb6\x9a\x01\xb5@\x00.>\x90\x04\x00\x01Az\x0c\xf2\x009\xe7=\xb5 \xf49\xb8\x04\x15;\xf49\xb9)\xae\x1c\xf59\xe8\x04\x15;\xfc\x04\x01'\x00\xeb\x01'\x00\xe9)\xdc\b\xf49\xb6\x05'8\xb7B\x01\x15\x04\x15;\xf59\xec\x04\x15;\xfd\x01" That’s 3,860 characters. ( https://hibernate.atlassian.net/browse/HHH-15500#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-15500#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100209- sha1:597f6a7 )

2 years, 2 months

1
0
0 / 0

[JIRA] (HHH-12647) Investigate if we could pass ARRAYs when using the ANY clause

by Christian Beikov (JIRA)

2 years, 2 months

1
0
0 / 0

[JIRA] (HSEARCH-4722) Fix postgresql container start timing out on CI

by Yoann Rodière (JIRA)

2 years, 2 months

1
0
0 / 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

hibernate-issues October 2022