October 2022 - hibernate-issues - Jboss List Archives

[JIRA] (HSEARCH-4712) Convert synchronized blocks to java.util.concurrent.Locks for better Loom compatibility

by Yoann Rodière (JIRA)

1 year, 11 months

1
0
0 / 0

[JIRA] (HSEARCH-4714) Early sanity checks for property names

by Yoann Rodière (JIRA)

1 year, 11 months

1
0
0 / 0

[JIRA] (HSEARCH-4714) Early sanity checks for property names

by Yoann Rodière (JIRA)

Yoann Rodière ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *created* an issue Hibernate Search ( https://hibernate.atlassian.net/browse/HSEARCH?atlOrigin=eyJpIjoiYjhlNDU1... ) / Improvement ( https://hibernate.atlassian.net/browse/HSEARCH-4714?atlOrigin=eyJpIjoiYjh... ) HSEARCH-4714 ( https://hibernate.atlassian.net/browse/HSEARCH-4714?atlOrigin=eyJpIjoiYjh... ) Early sanity checks for property names ( https://hibernate.atlassian.net/browse/HSEARCH-4714?atlOrigin=eyJpIjoiYjh... ) Issue Type: Improvement Assignee: Unassigned Components: mapper-pojo-base Created: 10/Oct/2022 04:59 AM Fix Versions: 6.2-backlog Priority: Minor Reporter: Yoann Rodière ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) It’s possible for users to write this by mistake: @IndexingDependency(derivedFrom = { @ObjectPath({ @PropertyValue(propertyName = "audit.username") }) }) When they should be writing this: @IndexingDependency(derivedFrom = { @ObjectPath({ @PropertyValue(propertyName = "audit"), @PropertyValue(propertyName = "username") }) }) The mistake is understandable, given the syntax is a bit obscure and cumbersome (we’ll address that in https://hibernate.atlassian.net/browse/HSEARCH-4392 ( https://hibernate.atlassian.net/browse/HSEARCH-4392 ) ). However, this mistake currently produces the following error, which is itself quite puzzling at first sight: - HSEARCH700078: No readable property named 'audit.username' on type ..... We could improve the developer experience slightly by validating property names when they are extracted from PropertyValue.propertyName , checking in particular that the property name doesn’t contain any dot or any metacharacter that org.hibernate.search.mapper.pojo.model.path.PojoModelPath#parse understands, throwing an exception saying something like Property names must not contain dots. It wouldn't be perfect, but at least would give some hint of what's going on. Suggestion of implementation: I would personally put this validation code in org.hibernate.search.mapper.pojo.model.path.PojoModelPath.Builder#property , or (perhaps better) in org.hibernate.search.mapper.pojo.model.path.PojoModelPathPropertyNode#PojoModelPathPropertyNode. Perhaps we could also add something like this to org.hibernate.search.mapper.pojo.mapping.definition.annotation.processing.impl.AbstractMappingAnnotationProcessorContext#toPojoModelPathValueNode , to provide a bit more context: try { ... } catch (SearchException e) { throw log.invalidObjectPath( objectPath, e.getMessage(), e ); } ( https://hibernate.atlassian.net/browse/HSEARCH-4714#add-comment?atlOrigin... ) Add Comment ( https://hibernate.atlassian.net/browse/HSEARCH-4714#add-comment?atlOrigin... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100207- sha1:591c2ef )

1 year, 11 months

1
0
0 / 0

[JIRA] (HHH-15585) Add support for DB2 aliases for schema validation

by Andrea Boriero (JIRA)

Andrea Boriero ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *commented* on HHH-15585 ( https://hibernate.atlassian.net/browse/HHH-15585?atlOrigin=eyJpIjoiZmQ3MD... ) Re: Add support for DB2 aliases for schema validation ( https://hibernate.atlassian.net/browse/HHH-15585?atlOrigin=eyJpIjoiZmQ3MD... ) Hi David Loewy ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=70121%3... ) , just added 5.3.13 as a fix version. ( https://hibernate.atlassian.net/browse/HHH-15585#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-15585#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100207- sha1:591c2ef )

1 year, 11 months

1
0
0 / 0

[JIRA] (HHH-15585) Add support for DB2 aliases for schema validation

by Andrea Boriero (JIRA)

1 year, 11 months

1
0
0 / 0

[JIRA] (HHH-15586) Reduce size of hibernate-core JAR

by Christoph Dreis (JIRA)

Christoph Dreis ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *commented* on HHH-15586 ( https://hibernate.atlassian.net/browse/HHH-15586?atlOrigin=eyJpIjoiZDYyZm... ) Re: Reduce size of hibernate-core JAR ( https://hibernate.atlassian.net/browse/HHH-15586?atlOrigin=eyJpIjoiZDYyZm... ) Sanne Grinovero ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) We’re not planning to move our Spring-Boot projects to Quarkus just for that, no. But thanks for the thought. Unfortunately, I don’t have a good thought on that as well, apart from really taking a deeper look if the core module is really only containing core stuff, so I understand this being closed. But I would have expected anyway some more long-term design thoughts here. This isn't something for the next bugfix release after all, but maybe something for 7.x. I don’t know if you have a different sort of ticket or state for that. E.g. pending design work. That would feel better than just closing the thing, because albeit you telling me that it’s in your minds, I know how it is. With the ticket being closed, likely nobody will be aware in a few weeks time. Nonetheless, I appreciate you looking into this and sharing your thoughts. ( https://hibernate.atlassian.net/browse/HHH-15586#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-15586#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100207- sha1:591c2ef )

1 year, 11 months

1
0
0 / 0

[JIRA] (HHH-15561) Function "IDENTITY" not found when inserting audited revision using Hibernate Envers

by Christian Beikov (JIRA)

Christian Beikov ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *commented* on HHH-15561 ( https://hibernate.atlassian.net/browse/HHH-15561?atlOrigin=eyJpIjoiMDAyMT... ) Re: Function "IDENTITY" not found when inserting audited revision using Hibernate Envers ( https://hibernate.atlassian.net/browse/HHH-15561?atlOrigin=eyJpIjoiMDAyMT... ) It seems H2 2.0+ removed the identity function as EclipseLink ( https://github.com/eclipse-ee4j/eclipselink/issues/1393 ( https://github.com/eclipse-ee4j/eclipselink/issues/1393 ) ) also has run into this issue. I guess on newer H2 versions we will have to rely on GET_GENERATED_KEYS through the JDBC driver now. ( https://hibernate.atlassian.net/browse/HHH-15561#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-15561#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100207- sha1:591c2ef )

1 year, 11 months

1
0
0 / 0

[JIRA] (HHH-15586) Reduce size of hibernate-core JAR

by Sanne Grinovero (JIRA)

1 year, 11 months

1
0
0 / 0

[JIRA] (HHH-15586) Reduce size of hibernate-core JAR

by Sanne Grinovero (JIRA)

1 year, 11 months

1
0
0 / 0

[JIRA] (HHH-15586) Reduce size of hibernate-core JAR

by Sanne Grinovero (JIRA)

Sanne Grinovero ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *commented* on HHH-15586 ( https://hibernate.atlassian.net/browse/HHH-15586?atlOrigin=eyJpIjoiODI1YT... ) Re: Reduce size of hibernate-core JAR ( https://hibernate.atlassian.net/browse/HHH-15586?atlOrigin=eyJpIjoiODI1YT... ) Hi Christoph Dreis ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) - interesting, it seems to have grown quite a bit. Unfortunately there doesn’t seem to be anything standing out that would be both pratical for typical use and having anything more than a small dent of impact. I’m afraid we’ll have to close this as it’s not really actionable - if you have good ideas please feel free to reopen. If size and bandwith are very important to your team, did you consider compiling your application into a GraalVM native-image? We worked closely with the GraalVM and Quarkus teams to make this relatively easy; one nice effect of the Quarkus design is that each component that your application isn’t going to use is automatically stripped out (for example, if you’re using the PostgreSQL Dialect, all other dialects are deleted - and the same for all other configurable components, and this has a chain-reaction effect to the dependencies of each removed class). ( https://hibernate.atlassian.net/browse/HHH-15586#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-15586#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100207- sha1:591c2ef )

1 year, 11 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

hibernate-issues October 2022