September 2022 - hibernate-issues

[JIRA] (HHH-15510) JoinColumn annotation not recognized when entity is mapped via XML file

by Mike Becker (JIRA)

Mike Becker ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=6321cb8... ) *updated* an issue Hibernate ORM ( https://hibernate.atlassian.net/browse/HHH?atlOrigin=eyJpIjoiYTM2NzE4YTM4... ) / Bug ( https://hibernate.atlassian.net/browse/HHH-15510?atlOrigin=eyJpIjoiYTM2Nz... ) HHH-15510 ( https://hibernate.atlassian.net/browse/HHH-15510?atlOrigin=eyJpIjoiYTM2Nz... ) JoinColumn annotation not recognized when entity is mapped via XML file ( https://hibernate.atlassian.net/browse/HHH-15510?atlOrigin=eyJpIjoiYTM2Nz... ) Change By: Mike Becker ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=6321cb8... ) If an entity is mapped via an XML file, an ElementCollection cannot be annotated with OnDelete because hibernate complains that JoinColumn is missing. But JoinColumn is actually there. The error message is {quote}Unidirectional one-to-many associations annotated with @OnDelete must define @JoinColumn{quote} The following test case demonstrates this behavior. Change the TRIGGER_BUG flag to observe how the test case is working when not using the XML file and how the bug occurs when using the XML file. TODO {code : insert java}/* * Copyright 2014 JBoss Inc * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. * You may obtain a copy of the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in writing, software * distributed under the License is distributed on an "AS IS" BASIS, * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. * See the License for the specific language governing permissions and * limitations under the License. */ package org.hibernate.bugs; import jakarta.persistence.*; import org.hibernate.annotations.LazyCollection; import org.hibernate.annotations.LazyCollectionOption; import org.hibernate.annotations.OnDelete; import org.hibernate.annotations.OnDeleteAction; import org.hibernate.testing.junit4.BaseCoreFunctionalTestCase; import org.junit.Test; import java.util.Collections; import java.util.HashSet; import java.util.Set; import static org.hamcrest.MatcherAssert.assertThat; import static org.hamcrest.Matchers.containsInAnyOrder; import static org.hamcrest.Matchers.hasSize; /** * This test case once demonstrates that Hibernate 6.1.3 and earlier complains about a missing * JoinColumn annotation, although this annotation is clearly there. */ public class TestHHH15510 extends BaseCoreFunctionalTestCase { private static final boolean TRIGGER_BUG = true; @Entity @Table(name = "entity_hhh15510") public static class EntityHHH15510 { @Id private Long id; public EntityHHH15510() { } public void setId(Long id) { this.id = id; } @ElementCollection @CollectionTable( name = "entity_hhh15510_strings", joinColumns = @JoinColumn(name = "parent") ) @LazyCollection(LazyCollectionOption.FALSE) @JoinColumn(name = "parent") @OnDelete(action = OnDeleteAction.CASCADE) private Set<String> strings = new HashSet<>(); public void addString(String str) { strings.add(str); } public Set<String> getStrings() { return Collections.unmodifiableSet(strings); } } @Override protected Class<?>[] getAnnotatedClasses() { return TRIGGER_BUG ? NO_CLASSES : new Class[]{EntityHHH15510.class}; } @Override protected String[] getMappings() { return TRIGGER_BUG ? new String[]{"mappings.xml"} : NO_MAPPINGS; } @Test public void hhh15510Test() { // persist a new entity try (final var s = openSession()) { final var tx = s.beginTransaction(); final var e = new EntityHHH15510(); e.setId(1L); e.addString("test01"); e.addString("test02"); s.persist(e); tx.commit(); } // verify that the issue ID entity was correctly persisted try (final var s = openSession()) { final var tx = s.beginTransaction(); final var e = s.get(EntityHHH15510.class, 1L); final var strings = e.getStrings(); assertThat(strings, hasSize(2)); assertThat(strings, containsInAnyOrder("test01", "test02")); tx.commit(); } // natively check that child entries are present and natively delete the parent entity try (final var s = openSession()) { final var tx = s.beginTransaction(); final var strings = s.createNativeQuery("select strings from entity_hhh15510_strings", String.class).list(); assertThat(strings, hasSize(2)); assertThat(strings, containsInAnyOrder("test01", "test02")); s.createNativeMutationQuery("delete from entity_hhh15510").executeUpdate(); tx.commit(); } // natively check that child table is created empty (i.e. on delete cascade did its job) try (final var s = openSession()) { final var tx = s.beginTransaction(); final var strings = s.createNativeQuery("select strings from entity_hhh15510_strings", String.class).list(); assertThat(strings, hasSize(0)); tx.commit(); } } } {code} The mappings.xml: {code:xml}<?xml version="1.0" encoding="UTF-8"?> <entity-mappings xmlns="http://java.sun.com/xml/ns/persistence/orm" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://java.sun.com/xml/ns/persistence/orm http://java.sun.com/xml/ns/persistence/orm_1_0.xsd" version="1.0"> <entity class="org.hibernate.bugs.TestHHH15510$EntityHHH15510"/> </entity-mappings> {code} ( https://hibernate.atlassian.net/browse/HHH-15510#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-15510#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100207- sha1:c85b1ee )

2 years, 3 months

1
0
0 / 0

[JIRA] (HHH-15510) JoinColumn annotation not recognized when entity is mapped via XML file

by Mike Becker (JIRA)

Mike Becker ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=6321cb8... ) *created* an issue Hibernate ORM ( https://hibernate.atlassian.net/browse/HHH?atlOrigin=eyJpIjoiMjg3MjliOTgw... ) / Bug ( https://hibernate.atlassian.net/browse/HHH-15510?atlOrigin=eyJpIjoiMjg3Mj... ) HHH-15510 ( https://hibernate.atlassian.net/browse/HHH-15510?atlOrigin=eyJpIjoiMjg3Mj... ) JoinColumn annotation not recognized when entity is mapped via XML file ( https://hibernate.atlassian.net/browse/HHH-15510?atlOrigin=eyJpIjoiMjg3Mj... ) Issue Type: Bug Affects Versions: 6.1.3 Assignee: Unassigned Components: hibernate-core Created: 14/Sep/2022 06:51 AM Priority: Major Reporter: Mike Becker ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=6321cb8... ) If an entity is mapped via an XML file, an ElementCollection cannot be annotated with OnDelete because hibernate complains that JoinColumn is missing. But JoinColumn is actually there. The error message is > > > > Unidirectional one-to-many associations annotated with @OnDelete must > define @JoinColumn > > The following test case demonstrates this behavior. Change the TRIGGER_BUG flag to observe how the test case is working when not using the XML file and how the bug occurs when using the XML file. TODO: insert test case once the issue ID is created ( https://hibernate.atlassian.net/browse/HHH-15510#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-15510#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100207- sha1:c85b1ee )

2 years, 3 months

1
0
0 / 0

[JIRA] (HHH-14943) byNaturalId API creates unparseable query (AND keyword instead of WHERE)

by Andrea Boriero (JIRA)

2 years, 3 months

1
0
0 / 0

[JIRA] (HHH-15505) Getter of loaded entity returns null when using bytecode enhancement on entity whose field is defined both in mapped superclass and concrete entity

by Yoann Rodière (JIRA)

2 years, 3 months

1
0
0 / 0

[JIRA] (HHH-15508) Backport Session#getReference(Object) to branch 5.6

by Yoann Rodière (JIRA)

2 years, 3 months

1
0
0 / 0

[JIRA] (HHH-15509) Avoid entity loading on delete() when possible

by Yoann Rodière (JIRA)

Yoann Rodière ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *created* an issue Hibernate ORM ( https://hibernate.atlassian.net/browse/HHH?atlOrigin=eyJpIjoiZmE5MDhjZGJm... ) / Improvement ( https://hibernate.atlassian.net/browse/HHH-15509?atlOrigin=eyJpIjoiZmE5MD... ) HHH-15509 ( https://hibernate.atlassian.net/browse/HHH-15509?atlOrigin=eyJpIjoiZmE5MD... ) Avoid entity loading on delete() when possible ( https://hibernate.atlassian.net/browse/HHH-15509?atlOrigin=eyJpIjoiZmE5MD... ) Issue Type: Improvement Assignee: Unassigned Components: hibernate-core Created: 14/Sep/2022 04:17 AM Fix Versions: 6.2.0 Priority: Major Reporter: Yoann Rodière ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) In some very specific cases (no lifecycle callbacks, no cascades, …), deleting an entity could only involve running a few DB statements along the lines of delete from table where id = ?. In those cases, loading the entity would (in theory) not be necessary. In those very specific cases, when EntityManager.delete(Object) gets passed an uninitialized entity proxy, it would be a nice optimization if Hibernate ORM could skip initializing the proxy and just run the delete statements. This would remove at least one DB lookup for users doing a “delete-by-id” such as session.delete(session.getReference(MyEntity.class, 42L)) in some situations, while still doing the right thing (cascades, calling listeners, …) when the optimization is not possible. Note I’m not sure this is possible, but it’s probably worth investigating, be it only to document why it’s not possible. Related discussions: * https://hibernate.zulipchat.com/#narrow/stream/132094-hibernate-orm-dev/t... ( https://hibernate.zulipchat.com/#narrow/stream/132094-hibernate-orm-dev/t... ) * https://github.com/quarkusio/quarkus/pull/27832 ( https://github.com/quarkusio/quarkus/pull/27832 ) ( https://hibernate.atlassian.net/browse/HHH-15509#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-15509#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100207- sha1:c85b1ee )

2 years, 3 months

1
0
0 / 0

[JIRA] (HHH-15500) Cache key is huge since migration to 6

by Andrea Boriero (JIRA)

2 years, 3 months

1
0
0 / 0

[JIRA] (HHH-14943) byNaturalId API creates unparseable query (AND keyword instead of WHERE)

by Andrea Boriero (JIRA)

2 years, 3 months

1
0
0 / 0

[JIRA] (HHH-15508) Backport Session#getReference(Object) to branch 5.6

by Yoann Rodière (JIRA)

2 years, 3 months

1
0
0 / 0

[JIRA] (HSEARCH-4701) [org.jboss.logging.Messages] module needs to access [org.hibernate.search.backend.elasticsearch] module

by Automation for Jira (JIRA)

Automation for Jira ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *updated* an issue Hibernate Search ( https://hibernate.atlassian.net/browse/HSEARCH?atlOrigin=eyJpIjoiOTEzYWEy... ) / Bug ( https://hibernate.atlassian.net/browse/HSEARCH-4701?atlOrigin=eyJpIjoiOTE... ) HSEARCH-4701 ( https://hibernate.atlassian.net/browse/HSEARCH-4701?atlOrigin=eyJpIjoiOTE... ) [org.jboss.logging.Messages] module needs to access [org.hibernate.search.backend.elasticsearch] module ( https://hibernate.atlassian.net/browse/HSEARCH-4701?atlOrigin=eyJpIjoiOTE... ) Change By: Automation for Jira ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) Pull Request: https://github.com/hibernate/hibernate-search/pull/3241 Status: In Progress Pull Request Sent ( https://hibernate.atlassian.net/browse/HSEARCH-4701#add-comment?atlOrigin... ) Add Comment ( https://hibernate.atlassian.net/browse/HSEARCH-4701#add-comment?atlOrigin... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100207- sha1:c85b1ee )

2 years, 3 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

hibernate-issues September 2022