]
Steve Ebersole updated HHH-3084:
--------------------------------
Issue Type: Patch (was: Improvement)
Summary: DialectFactory detection of Ingres metadata (Michael Leo) (was:
DialectFactory.java doesn't map the IngresDialect)
looks good
DialectFactory detection of Ingres metadata (Michael Leo)
---------------------------------------------------------
Key: HHH-3084
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HHH-3084
Project: Hibernate3
Issue Type: Patch
Components: core
Affects Versions: 3.2.5
Environment: Hibernate 3.x and frameworks based on the Spring Framework, like
Grails
Reporter: Michael Leo
Fix For: 3.2.6, 3.3
Attachments: DialectFactory.java.patch
Original Estimate: 15 minutes
Remaining Estimate: 15 minutes
Although Hibernate ships with an Ingres dialect
org.hibernate.dialect.IngresDialect
it can't be found by the dialect factory
org.hibernate.dialect.DialectFactory
Although most tools can be forced to use the proper dialect, there is a circumstance
in Grails where there is no way to specify the correct Hibernate dialect for a custom
data source.
The patch is pretty straightforward. I've attached the output of "svn
diff" from the
root of the latest branch.
Hope this makes sense,
Mike Leo
$ svn diff
Index: src/org/hibernate/dialect/DialectFactory.java
===================================================================
--- src/org/hibernate/dialect/DialectFactory.java (revision 14289)
+++ src/org/hibernate/dialect/DialectFactory.java (working copy)
@@ -112,6 +112,9 @@
private static final Map MAPPERS = new HashMap();
static {
// TODO : this is the stuff it'd be nice to move to a properties file
or some other easily user-editable place
+ MAPPERS.put( "Ingres", new VersionInsensitiveMapper(
"org.hibernate.dialect.IngresDialect" ) );
+ MAPPERS.put( "ingres", new VersionInsensitiveMapper(
"org.hibernate.dialect.IngresDialect" ) );
+ MAPPERS.put( "INGRES", new VersionInsensitiveMapper(
"org.hibernate.dialect.IngresDialect" ) );
MAPPERS.put( "HSQL Database Engine", new
VersionInsensitiveMapper( "org.hibernate.dialect.HSQLDialect" ) );
MAPPERS.put( "DB2/NT", new VersionInsensitiveMapper(
"org.hibernate.dialect.DB2Dialect" ) );
MAPPERS.put( "DB2/LINUX", new VersionInsensitiveMapper(
"org.hibernate.dialect.DB2Dialect" ) );
$
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: