[
http://opensource.atlassian.com/projects/hibernate/browse/HV-34?page=com....
]
Emmanuel Bernard commented on HV-34:
------------------------------------
Why did you second patch get rid of the Character.UnicodeBlock?
And for my knowledge, can you describe me in greater detail what is a full width digit, is
it just a digit coded in UTF?
AbstractLuhnValidator and EANValidator perform unnecessary
calculations in some circumstances
---------------------------------------------------------------------------------------------
Key: HV-34
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HV-34
Project: Hibernate Validator
Issue Type: Bug
Components: validators
Reporter: WATANABE Takashi
Priority: Trivial
Attachments: 20070710_2205.patch.txt, 20070710_2205.patch2.txt
There are decimal digits other than ASCII ones.
e.g. full width digits(from \uff10 to \uff19)
So if a Japanese customer(or someone) entered full width digits, the current
AbstractLuhnValidator and EANValidator would perform some unnecessary calculations.
BTW, I think I'm going to use them with something like
@Pattern(regex="^\\d*$", message="Must be ASCII digits")
and @NotNull.
Becase I don't like my customers to enter full width digits
rather than ASCII ones.
Otherwise, it might be possible for them to handle all decimal
digits in the world(Unicode).
Then, I would use them with @Pattern(regex="^\\d*$") anyway ;-)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira