Knut Wannheden (
https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=5c40586...
) *updated* an issue
Hibernate ORM (
https://hibernate.atlassian.net/browse/HHH?atlOrigin=eyJpIjoiNDFiNzU3NTli...
) / Improvement (
https://hibernate.atlassian.net/browse/HHH-13906?atlOrigin=eyJpIjoiNDFiNz...
) HHH-13906 (
https://hibernate.atlassian.net/browse/HHH-13906?atlOrigin=eyJpIjoiNDFiNz...
) Unexpected CREATE SEQUENCE defaults in DB2390V8Dialect (
https://hibernate.atlassian.net/browse/HHH-13906?atlOrigin=eyJpIjoiNDFiNz...
)
Change By: Knut Wannheden (
https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=5c40586...
)
While I have only worked with DB2 on other platforms and thus not with DB2/390 v8, when I
look at the ` {{ DB2390V8Dialect#getCreateSequenceString(String) ` }} implementation
(see [
https://github.com/hibernate/hibernate-orm/blame/master/hibernate-core/sr...)
|https://github.com/hibernate/hibernate-orm/blame/master/hibernate-core/src/main/java/org/hibernate/dialect/DB2390V8Dialect.java#L26-L28)]
it strikes me as odd to have the ` {{ NOCACHE ` }} option in there. Typically the
default would be ` {{ CACHE 20 ` }} (which is what happens when the ` {{ CACHE ` }}
clause is left out). Also a few of the other clauses could probably be left out, since
they correspond to the default value and this is also how Hibernate works in the case of
most other supported dialects.
` {{ NOCACHE ` }} is of course also bad for performance and I think it would for this
reason also make sense to just leave out the ` {{ CACHE ` }} clause here.
(
https://hibernate.atlassian.net/browse/HHH-13906#add-comment?atlOrigin=ey...
) Add Comment (
https://hibernate.atlassian.net/browse/HHH-13906#add-comment?atlOrigin=ey...
)
Get Jira notifications on your phone! Download the Jira Cloud app for Android (
https://play.google.com/store/apps/details?id=com.atlassian.android.jira....
) or iOS (
https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=Em...
) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100122- sha1:092c6a7 )