[hibernate-issues] [Hibernate-JIRA] Commented: (HHH-1685) DetachedCriteria doesn't create alias on subcriteria

DetachedCriteria doesn't create alias on subcriteria ---------------------------------------------------- Key: HHH-1685 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-1685 Project: Hibernate3 Issue Type: Bug Components: query-criteria Affects Versions: 3.1.3 Reporter: John Attachments: hhh1685-example.txt DetachedCriteria has two createCriteria methods: public DetachedCriteria createCriteria(String associationPath) throws HibernateException public DetachedCriteria createCriteria(String associationPath, String alias) throws HibernateException However, the code for both was identical - they called the inner criteria's createCriteria(String) method. The version with the alias did not call the inner's version with the alias. The following patch snipped shows the change: public DetachedCriteria createCriteria(String associationPath, String alias) throws HibernateException { - return new DetachedCriteria( impl, criteria.createCriteria(associationPath) ); + return new DetachedCriteria( impl, criteria.createCriteria(associationPath, alias) ); } This bug was discovered while trying to link a 2-deep subquery to its parent via aliases. (Surfacing this issue might only be possible with the patch HHH-952 in place - I'm not sure. Seems like a bug regardless, as it definitely fixed my alias reference issue.) I'll get an example posted shortly.