[hibernate-issues] [JIRA] (HHH-15610) Try getting rid of CacheKeyValueDescriptor

Christian Beikov ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *created* an issue Hibernate ORM ( https://hibernate.atlassian.net/browse/HHH?atlOrigin=eyJpIjoiN2IyYmI2YTdl... ) / Improvement ( https://hibernate.atlassian.net/browse/HHH-15610?atlOrigin=eyJpIjoiN2IyYm... ) HHH-15610 ( https://hibernate.atlassian.net/browse/HHH-15610?atlOrigin=eyJpIjoiN2IyYm... ) Try getting rid of CacheKeyValueDescriptor ( https://hibernate.atlassian.net/browse/HHH-15610?atlOrigin=eyJpIjoiN2IyYm... ) Issue Type: Improvement Affects Versions: 6.1.4 Assignee: Christian Beikov ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) Components: hibernate-core Created: 18/Oct/2022 05:34 AM Priority: Major Reporter: Christian Beikov ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) It seems that the fix for https://hibernate.atlassian.net/browse/HHH-15500 ( https://hibernate.atlassian.net/browse/HHH-15500 ) was not really satisfactory for some use cases. After digging a bit into this, I found out that NaturalIdCacheKey uses Type#disassemble instead. I think it might have been an error to introduce CacheKeyValueDescriptor and we should instead rely on Type#disassemble in the CacheKeyImplementation as well. We might want to clarify the contract in Type#disassemble a bit though, as one of the implications of such a usage is, that the method must produce objects for which we can use Objects#deepEquals instead of JavaType#areEqual. ( https://hibernate.atlassian.net/browse/HHH-15610#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-15610#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=Em... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100209- sha1:597f6a7 )