[hibernate-issues] [Hibernate-JIRA] Commented: (HHH-1646) Bad code in FastClass.equals
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-1646?page=c...
]
Scott Marlow commented on HHH-1646:
-----------------------------------
Fix also checked into Branch_3_2 revision 10998.
Bad code in FastClass.equals
----------------------------
Key: HHH-1646
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-1646
Project: Hibernate3
Type: Bug
Versions: 3.1.3, 3.2.0 cr1
Environment: 3.2.0
Reporter: Niels Harremoës
Assignee: Scott Marlow
Priority: Blocker
Fix For: 3.2.2
Attachments: FastClass.patch
Original Estimate: 30 minutes
Remaining: 30 minutes
In FastClass, the equals method is:
public boolean equals(Object o) {
if ( o == null || ( o instanceof FastClass ) ) {
return false;
}
return this.type.equals( ( ( FastClass ) o ).type );
}
There's a missing ! - the first line should be
if ( o == null || ! ( o instanceof FastClass ) ) {
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira