[hibernate-issues] [Hibernate-JIRA] Issue Comment Edited: (HV-376) validateValue() and validateProperty() are too restrictive regarding processable property names

[ http://opensource.atlassian.com/projects/hibernate/browse/HV-376?page=com... ] Hardy Ferentschik edited comment on HV-376 at 2/7/11 4:05 AM: -------------------------------------------------------------- The proposed solution by Kevin is to replace: {code}private static final Pattern PATH_PATTERN = Pattern.compile( "(\\w+)(\\[(\\w*)\\])?(\\.(.*))*" );{code} by {code}private static final Pattern PATH_PATTERN = Pattern.compile( "(\\p{javaJavaIdentifierStart}\\p{javaJavaIdentifierPart}*)(\\[(\\w*)\\])?(\\.(.*))*" );{code} The latter works, because of pattern categories and the fact that {{Character}} methods of the form _ismethodname_ which return boolean are valid categories. Considering this the proposed solution seems to be correct. However, there are concerns that not all JVM implementations implement these categories properly. Obviously that would be against the spec, but I still would prefer that HV is not failing in this case. At the moment we have a regexp which is not 100% correct, but at least it works on all JVMs (personally I think anyone using "€" and similar within method names should be punished anyways). If switching to a more correct regular expression means that we introduce problems for "reasonable" method names on some JVMs we maybe should look at other solutions (or keep the current one). was (Author: hardy.ferentschik): The proposed solution by Kevin is to replace: {code}private static final Pattern PATH_PATTERN = Pattern.compile( "(\\w+)(\\[(\\w*)\\])?(\\.(.*))*" );{code} by {code}private static final Pattern PATH_PATTERN = Pattern.compile( "(\\p{javaJavaIdentifierStart}\\p{javaJavaIdentifierPart}*)(\\[(\\w*)\\])?(\\.(.*))*" );{code} The latter works, because of pattern categories and the fact that {{Character}} methods of the form _ismethodname_ which return boolean are valid categories. Considering this the proposed solution seems to be correct. However, there are concerns that not all JVM implementations implement these categories properly. Obviously that would be against the spec, but I still would prefer that HV is not failing in this case. At the moment we have a regexp which is not 100% correct, but at least it works on all JVMs (personally I think anyone using "€" and similar within method names should be punished anyways). If switching to a more correct regular expression means that we introduce problems for "reasonable" method names on some JVMs we maybe should look at other solutions. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira