]
Adam Warski resolved HHH-3737.
------------------------------
Assignee: Adam Warski
Resolution: Fixed
Fix Version/s: 3.4
3.3.x
Hello,
thanks for the patch :)
I've created a branch:
, which
contains the current codebase compatible with Hibernate 3.3.1. (This required some
additional changes above the ones in the patch.)
Support Hibernate 3.3 branch in Envers until 3.4.0GA is out
-----------------------------------------------------------
Key: HHH-3737
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HHH-3737
Project: Hibernate Core
Issue Type: Improvement
Components: envers
Affects Versions: 3.4
Reporter: Erik-Berndt Scheper
Assignee: Adam Warski
Fix For: 3.3.x, 3.4
Attachments: envers-hibernate-core-3.3.x-compatibility.patch
It would be great if Envers would support the 3.3 stable branch of Hibernate at least
until Hibernate 3.4.0GA is out.
I fully understand the rationale to remove the patch to support Hibernate 3.3.1 GA. The
underlying bug HHH-3351 is resolved in the trunk (3.4.0), but also in the 3.3 branch. (See
http://fisheye.jboss.com/changelog/Hibernate/core/trunk/envers?cs=15462 )
Therefore Envers 3.4.0 (snapshot) should be able to run perfectly fine against a 3.3.2
snapshot.
Unfortunately, with the migration from envers to Hibernate,
AbstractDelegateSessionImplementor has been modified to include an unused delegation
method to org.hibernate.engine.LoadQueryInfluencers, which is new in 3.4.0 (trunk).
The attached patch removes this method, so that Envers 3.4.0 snapshot compiles with
Hibernate 3.3.2 snapshot. Also, I have verified that all Envers test cases pass with a
3.3.2-SNAPSHOT.
Related: it would be great to add a Maven profile to envers, so that the envers module
could be compiled with a 3.3.2-snapshot dependency. But this would require a
3.3.2-snapshot published in a Jboss repository, which is sadly not available.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: