[hibernate-issues] [Hibernate-JIRA] Commented: (HV-538) Perform a profiling of the HV code in order to identify performance bottlenecks

[ https://hibernate.onjira.com/browse/HV-538?page=com.atlassian.jira.plugin... ] Hardy Ferentschik commented on HV-538: -------------------------------------- Some observations from Gunnar: {quote} * The logging around Contracts#assertNotNull() caused very many invocations of String#format(), also if the asserted value actually was not null, as MESSAGES.mustNotBeNull( "bla" ) was passed as parameter. I've changed this by pushing the creation of the message into the actual null case [1]. * The logging generally causes invocations of String#format() which I think are are superfluous. More specifically format() is also invoked if a given log message doesn't have any parameters. AFAICS the message could directly be returned in that case. WDYT? I think we might create a ticket against LOGTOOLS for this. * When parsing mapping XML files, a new JAXBContext was created for each input stream. I think we can re-use the same instance for several input streams [2]. [1] https://github.com/gunnarmorling/hibernate-validator/commit/e5259254f8cd8... [2] https://github.com/gunnarmorling/hibernate-validator/commit/8a190275e9ed3... {quote} -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira