[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-4732?page=c...
]
Steve Ebersole commented on HHH-4732:
-------------------------------------
1) Yes I understand these indicate some form of "teradata limitation". The
point being, in regards to what? That is the whole reason we add these informational
methods to Dialect and use them from the testsuite. Not only is it self-documenting
("oh we are skipping this test of CLOB support because this Dialect does not support
CLOBs"...) but exposes the fact to users for their use as well.
2) Well I don't think this is a good idea at all, but here we are :) Y'all do
realize that the suggested solution completely misses out on the case where the script is
written to file instead of executed right?
3) I did not suggest otherwise. What I said was that I think a general purpose "here
is some random bit of SQL that needs to be executed after we drop any kind of database
object" is just not needed.
Update Teradata Dialect for Teradata 13.0
-----------------------------------------
Key: HHH-4732
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HHH-4732
Project: Hibernate Core
Issue Type: Improvement
Components: core
Affects Versions: 3.3.2
Environment: Hibernate 3.3.2/ Teradata JDBC Driver 13.0, Teradata Database 13.0
Reporter: David Repshas
Assignee: Strong Liu
Attachments: teradata.zip, teradataDiff.zip, testsuiteMods.zip
Would like to update Teradata Dialect to work with Teradata Database 13.0.
I've include the following files with changes as noted:
org.hibernate.dialect.dialect.java
- added include of java.sql.statement
- added code to support the removal of temporary
files created when using referential integrity
The three new methods are:
public boolean supportsDropPreProcess()
public String performDropPreProcess(Statement stmt, String dropSql) throws
SQLException
public void performDropPostProcess(Statement stmt, String dropSql) throws
SQLException
==================================
org.hibernate.dialect.TeradataDialect.java
- added new include files
- modified registerFunction calls for "current_time" and
"current_date"
- put registerKeyword list in alphabetical order and added keywords:
column,map,password,summary, type, value and year
- changed "getAddColumnString()" to return "Add"
- added new methods:
public ViolatedConstraintNameExtracter getViolatedConstraintNameExtracter()
public String extractConstraintName(SQLException sqlex)
public boolean supportsNotNullUnique()
public boolean supportsExpectedLobUsagePattern()
public boolean supportsUnboundedLobLocatorMaterialization()
public boolean supportsDropPreProcess()
public String performDropPreProcess(Statement stmt, String dropSql) throws
SQLException
public void performDropPostProcess(Statement stmt, String dropSql) throws SQLException
==================================
org.hibernate.tool.hbm2ddl.SchemaExport
- added hooks for new methods:
supportsDropPreProcess,performDropPreProcess and performDropPostProcess
==================================
Also made some changes to some of the files in testsuite:
=============================================
test/hql/astParserLoadingTest.java
- Add instance check of TeradataDialect to get correct behavior
=============================================
test/legacy/foobartest.java
- Add instance check of TeradataDialect to get correct behavior
- modified SQL: Teradata requires "<>" rather than "!="
=============================================
test/typeParameters\typeparametertest.java
-needed to disable these tests as Teradata locking was causing
a deadlock situation when they run
=============================================
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira