[hibernate-issues] [Hibernate-JIRA] Commented: (HHH-7113) NaturalIdLoadAccess not properly working on mutable NaturalId's

[ https://hibernate.onjira.com/browse/HHH-7113?page=com.atlassian.jira.plug... ] Guenther Demetz commented on HHH-7113: -------------------------------------- In my opinion the naturalIdResolutionCacheMap must always be filled using the persister of the declaring class, see following example: Class A NaturalId key1 Class AA extends A NaturalId key2 Class AAA extends AA --------------------------- assertTrue (session.bySimpleNaturalId(A.class).load(key1) instanceof AAA); // this is possible, //persister of A should be considered for caching: naturalIdResolutionCacheMap.put( persisterA, entityNaturalIdResolutionCache ); assertTrue (session.byNaturalId(AA.class).using("key1", "1").using("key2", "9").load() instanceof AAA); // also this is possible, //persister of AA should be considered for caching: naturalIdResolutionCacheMap.put( persisterAA, entityNaturalIdResolutionCache ); Thus, similiar to StatefulPersistenceContext#validateNaturalId(EntityPersister persister, Object[] naturalIdValues) we will need a method which returns the correct persister for caching, something like following: private EntityPersister findProperEntityPersisterForNaturalIdValues(EntityPersister persister, Object[] naturalIdValues) { EntityPersister ret = persister; while (persister.hasPersisterForSuperClass()) { try { validateNaturalId(ret.getPersisterForSuperClass(),naturalIdValues); ret = ret.getPersisterForSuperClass(); } catch (IllegalArgumentException i) { break; } } return ret; } -------------------------------------------------------------------------------------------------- Then modify the puts into naturalIdResolutionCacheMap as follows: naturalIdResolutionCacheMap.put(findProperEntityPersisterForNaturalIdValues(persister,naturalIdValues), entityNaturalIdResolutionCache ); -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira