[Hibernate-JIRA] Created: (HHH-3172) There should be a way to add a Serializable object that represents the user that is using the current session
1:17 p.m.
There should be a way to add a Serializable object that represents the user that is using
the current session
-------------------------------------------------------------------------------------------------------------
Key: HHH-3172
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3172
Project: Hibernate3
Issue Type: Bug
Components: core
Environment: N/A
Reporter: Will Hoover
There should be a way to add a Serializable object that represents the user that is using
the current session. The only way to do this now is:
Interceptor interceptor = new MyInterceptor();
Session session = factory.openSession(interceptor);
interceptor.setSession(session);
interceptor.setUserId(user.getId());
Should be:
Serializable user = ...
Session session = factory.openSession(user);
An alternative and more flexible solution would be to allow the session to be customized.
Currently the org.hibernate.Configuration instantiates the factory implementation (if this
is done- not sure why it is interfaced to begin with). This is repeated in session factory
implementation as well:
public SessionFactory buildSessionFactory() throws HibernateException {
...
// why not overload the build method and allow impl to be passed if desired?
return new SessionFactoryImpl(
this,
mapping,
settings,
getInitializedEventListeners()
);
}
private SessionImpl openSession(
Connection connection,
boolean autoClose,
long timestamp,
Interceptor sessionLocalInterceptor
) {
// why not overload the open session method and allow impl to be passed if desired?
return new SessionImpl(
connection,
this,
autoClose,
timestamp,
sessionLocalInterceptor == null ? interceptor : sessionLocalInterceptor,
settings.getDefaultEntityMode(),
settings.isFlushBeforeCompletionEnabled(),
settings.isAutoCloseSessionEnabled(),
settings.getConnectionReleaseMode()
);
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:58 p.m.
New subject: [Hibernate-JIRA] Resolved: (HHH-3172) There should be a way to add a Serializable object that represents the user that is using the current session
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-3172?page=c...
]
Emmanuel Bernard resolved HHH-3172.
-----------------------------------
Resolution: Rejected
There is no benefit and that's not the responsibility of a persistence framework to
deal with the concept of a "user".
There should be a way to add a Serializable object that represents
the user that is using the current session
-------------------------------------------------------------------------------------------------------------
Key: HHH-3172
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3172
Project: Hibernate3
Issue Type: Bug
Components: core
Environment: N/A
Reporter: Will Hoover
There should be a way to add a Serializable object that represents the user that is using
the current session. The only way to do this now is:
Interceptor interceptor = new MyInterceptor();
Session session = factory.openSession(interceptor);
interceptor.setSession(session);
interceptor.setUserId(user.getId());
Should be:
Serializable user = ...
Session session = factory.openSession(user);
An alternative and more flexible solution would be to allow the session to be customized.
Currently the org.hibernate.Configuration instantiates the factory implementation (if this
is done- not sure why it is interfaced to begin with). This is repeated in session factory
implementation as well:
public SessionFactory buildSessionFactory() throws HibernateException {
...
// why not overload the build method and allow impl to be passed if desired?
return new SessionFactoryImpl(
this,
mapping,
settings,
getInitializedEventListeners()
);
}
private SessionImpl openSession(
Connection connection,
boolean autoClose,
long timestamp,
Interceptor sessionLocalInterceptor
) {
// why not overload the open session method and allow impl to be passed if desired?
return new SessionImpl(
connection,
this,
autoClose,
timestamp,
sessionLocalInterceptor == null ? interceptor : sessionLocalInterceptor,
settings.getDefaultEntityMode(),
settings.isFlushBeforeCompletionEnabled(),
settings.isAutoCloseSessionEnabled(),
settings.getConnectionReleaseMode()
);
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:26 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-3172) There should be a way to add a Serializable object that represents the user that is using the current session
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-3172?page=c...
]
Will Hoover commented on HHH-3172:
----------------------------------
I should have been more clear in my explanation. What I am looking for is a facility to
add properties to the Session such as a "user". Hiberante does not need to be
aware of the "user" concept, but rather facilitate a means to store Session
properties in general. Right now there is no way to extend the Hibernate
Session/SessionFactory. What I'm proposing is:
1) Add a simple hash map where Session level properties can be stored/retrieved OR
2) Provide a way to extend the Session/SessionFactory so that properties that belong in
the Session can be stored/retrieved.
There should be a way to add a Serializable object that represents
the user that is using the current session
-------------------------------------------------------------------------------------------------------------
Key: HHH-3172
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3172
Project: Hibernate3
Issue Type: Bug
Components: core
Environment: N/A
Reporter: Will Hoover
There should be a way to add a Serializable object that represents the user that is using
the current session. The only way to do this now is:
Interceptor interceptor = new MyInterceptor();
Session session = factory.openSession(interceptor);
interceptor.setSession(session);
interceptor.setUserId(user.getId());
Should be:
Serializable user = ...
Session session = factory.openSession(user);
An alternative and more flexible solution would be to allow the session to be customized.
Currently the org.hibernate.Configuration instantiates the factory implementation (if this
is done- not sure why it is interfaced to begin with). This is repeated in session factory
implementation as well:
public SessionFactory buildSessionFactory() throws HibernateException {
...
// why not overload the build method and allow impl to be passed if desired?
return new SessionFactoryImpl(
this,
mapping,
settings,
getInitializedEventListeners()
);
}
private SessionImpl openSession(
Connection connection,
boolean autoClose,
long timestamp,
Interceptor sessionLocalInterceptor
) {
// why not overload the open session method and allow impl to be passed if desired?
return new SessionImpl(
connection,
this,
autoClose,
timestamp,
sessionLocalInterceptor == null ? interceptor : sessionLocalInterceptor,
settings.getDefaultEntityMode(),
settings.isFlushBeforeCompletionEnabled(),
settings.isAutoCloseSessionEnabled(),
settings.getConnectionReleaseMode()
);
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:13 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-3172) There should be a way to add a Serializable object that represents the user that is using the current session
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-3172?page=c...
]
Emmanuel Bernard commented on HHH-3172:
---------------------------------------
Ah. That's a concept that we have discussed in the past (for the session factory).
Steve is not really convinced though.
There should be a way to add a Serializable object that represents
the user that is using the current session
-------------------------------------------------------------------------------------------------------------
Key: HHH-3172
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3172
Project: Hibernate3
Issue Type: Bug
Components: core
Environment: N/A
Reporter: Will Hoover
There should be a way to add a Serializable object that represents the user that is using
the current session. The only way to do this now is:
Interceptor interceptor = new MyInterceptor();
Session session = factory.openSession(interceptor);
interceptor.setSession(session);
interceptor.setUserId(user.getId());
Should be:
Serializable user = ...
Session session = factory.openSession(user);
An alternative and more flexible solution would be to allow the session to be customized.
Currently the org.hibernate.Configuration instantiates the factory implementation (if this
is done- not sure why it is interfaced to begin with). This is repeated in session factory
implementation as well:
public SessionFactory buildSessionFactory() throws HibernateException {
...
// why not overload the build method and allow impl to be passed if desired?
return new SessionFactoryImpl(
this,
mapping,
settings,
getInitializedEventListeners()
);
}
private SessionImpl openSession(
Connection connection,
boolean autoClose,
long timestamp,
Interceptor sessionLocalInterceptor
) {
// why not overload the open session method and allow impl to be passed if desired?
return new SessionImpl(
connection,
this,
autoClose,
timestamp,
sessionLocalInterceptor == null ? interceptor : sessionLocalInterceptor,
settings.getDefaultEntityMode(),
settings.isFlushBeforeCompletionEnabled(),
settings.isAutoCloseSessionEnabled(),
settings.getConnectionReleaseMode()
);
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:29 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-3172) There should be a way to add a Serializable object that represents the user that is using the current session
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-3172?page=c...
]
Will Hoover commented on HHH-3172:
----------------------------------
Does Steve specify why is he not convinced?
It makes sense to be able to extend the Session/SessionFactory. Most frameworks that have
a concept of a session allow customization of that session either by providing a means to
extend it or by providing a mechanism to store data in it. Is there a separate Jira issue
that addresses this that you are aware of (I could not find one when I did a search)?
There should be a way to add a Serializable object that represents
the user that is using the current session
-------------------------------------------------------------------------------------------------------------
Key: HHH-3172
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3172
Project: Hibernate3
Issue Type: Bug
Components: core
Environment: N/A
Reporter: Will Hoover
There should be a way to add a Serializable object that represents the user that is using
the current session. The only way to do this now is:
Interceptor interceptor = new MyInterceptor();
Session session = factory.openSession(interceptor);
interceptor.setSession(session);
interceptor.setUserId(user.getId());
Should be:
Serializable user = ...
Session session = factory.openSession(user);
An alternative and more flexible solution would be to allow the session to be customized.
Currently the org.hibernate.Configuration instantiates the factory implementation (if this
is done- not sure why it is interfaced to begin with). This is repeated in session factory
implementation as well:
public SessionFactory buildSessionFactory() throws HibernateException {
...
// why not overload the build method and allow impl to be passed if desired?
return new SessionFactoryImpl(
this,
mapping,
settings,
getInitializedEventListeners()
);
}
private SessionImpl openSession(
Connection connection,
boolean autoClose,
long timestamp,
Interceptor sessionLocalInterceptor
) {
// why not overload the open session method and allow impl to be passed if desired?
return new SessionImpl(
connection,
this,
autoClose,
timestamp,
sessionLocalInterceptor == null ? interceptor : sessionLocalInterceptor,
settings.getDefaultEntityMode(),
settings.isFlushBeforeCompletionEnabled(),
settings.isAutoCloseSessionEnabled(),
settings.getConnectionReleaseMode()
);
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:15 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-3172) There should be a way to add a Serializable object that represents the user that is using the current session
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-3172?page=c...
]
Emmanuel Bernard commented on HHH-3172:
---------------------------------------
no but you can open one. As it is, Hibernate does nto provide enough lifecycle hooks to
have a decent paylod life cycle management.
There should be a way to add a Serializable object that represents
the user that is using the current session
-------------------------------------------------------------------------------------------------------------
Key: HHH-3172
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3172
Project: Hibernate3
Issue Type: Bug
Components: core
Environment: N/A
Reporter: Will Hoover
There should be a way to add a Serializable object that represents the user that is using
the current session. The only way to do this now is:
Interceptor interceptor = new MyInterceptor();
Session session = factory.openSession(interceptor);
interceptor.setSession(session);
interceptor.setUserId(user.getId());
Should be:
Serializable user = ...
Session session = factory.openSession(user);
An alternative and more flexible solution would be to allow the session to be customized.
Currently the org.hibernate.Configuration instantiates the factory implementation (if this
is done- not sure why it is interfaced to begin with). This is repeated in session factory
implementation as well:
public SessionFactory buildSessionFactory() throws HibernateException {
...
// why not overload the build method and allow impl to be passed if desired?
return new SessionFactoryImpl(
this,
mapping,
settings,
getInitializedEventListeners()
);
}
private SessionImpl openSession(
Connection connection,
boolean autoClose,
long timestamp,
Interceptor sessionLocalInterceptor
) {
// why not overload the open session method and allow impl to be passed if desired?
return new SessionImpl(
connection,
this,
autoClose,
timestamp,
sessionLocalInterceptor == null ? interceptor : sessionLocalInterceptor,
settings.getDefaultEntityMode(),
settings.isFlushBeforeCompletionEnabled(),
settings.isAutoCloseSessionEnabled(),
settings.getConnectionReleaseMode()
);
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6153
days inactive
6155
days old
hibernate-issues@lists.jboss.org
5 comments
2 participants
participants (2)
-
Emmanuel Bernard (JIRA) -
Will Hoover (JIRA)