]
Steve Ebersole commented on HHH-1480:
-------------------------------------
so basically i added this with a hook into the dialect that ask the dialect for its cross
join separator. The default now returns " cross join ". As we find databases
which do not support from-clause joins or do not support "A cross join B"
specifically we can change their dialects.
JOIN precendence rules per SQL-99
---------------------------------
Key: HHH-1480
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HHH-1480
Project: Hibernate Core
Issue Type: New Feature
Components: query-hql
Affects Versions: 3.1.2
Reporter: trebor iksrazal
Assignee: Steve Ebersole
Fix For: 3.2.x, 3.3.x, 3.5
In SQL-92 joins performed in the where clause (comma operator in from clause) and joins
performed in the from clause (join keyword) had the same precedence. SQL-99 clarified
this such that the from clause joins had higher precedence.
Hibernate currently treats these as having the same precedence.
A good explanation comes from the MySQL docs (
http://dev.mysql.com/doc/refman/5.0/en/join.html ) :
#
Previously, the comma operator (,) and JOIN both had the same precedence, so the join
expression t1, t2 JOIN t3 was interpreted as ((t1, t2) JOIN t3). Now JOIN has higher
precedence, so the expression is interpreted as (t1, (t2 JOIN t3)). This change affects
statements that use an ON clause, because that clause can refer only to columns in the
operands of the join, and the change in precedence changes interpretation of what those
operands are.
Example:
CREATE TABLE t1 (i1 INT, j1 INT);
CREATE TABLE t2 (i2 INT, j2 INT);
CREATE TABLE t3 (i3 INT, j3 INT);
INSERT INTO t1 VALUES(1,1);
INSERT INTO t2 VALUES(1,1);
INSERT INTO t3 VALUES(1,1);
SELECT * FROM t1, t2 JOIN t3 ON (t1.i1 = t3.i3);
Previously, the SELECT was legal due to the implicit grouping of t1,t2 as (t1,t2). Now
the JOIN takes precedence, so the operands for the ON clause are t2 and t3. Because t1.i1
is not a column in either of the operands, the result is an Unknown column 't1.i1'
in 'on clause' error. To allow the join to be processed, group the first two
tables explicitly with parentheses so that the operands for the ON clause are (t1,t2) and
t3:
SELECT * FROM (t1, t2) JOIN t3 ON (t1.i1 = t3.i3);
Alternatively, avoid the use of the comma operator and use JOIN instead:
SELECT * FROM t1 JOIN t2 JOIN t3 ON (t1.i1 = t3.i3);
This change also applies to statements that mix the comma operator with INNER JOIN, CROSS
JOIN, LEFT JOIN, and RIGHT JOIN, all of which now have higher precedence than the comma
operator.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: