URL Validator not effective --------------------------- Key: HV-406 URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-406 Project: Hibernate Validator Issue Type: Bug Affects Versions: 4.1.0.Final Reporter: Marc Schipperheyn Assignee: Hardy Ferentschik Priority: Minor The supplied URL Validator basically doesn't work. Or at least not as expected. It creates a URL against the URL class and if it fails this, it returns false. There are multiple problems with this: * A URL like http://bljdlfghjdlgjlfd is perfectly valid according to the URL class (intranet domains can be anything) * It's not the most efficient way to test this (generating an error etc) In order to retain backward compatibility I would suggest adding an "internet" attribute, which would force the validator to really check for minimally one dot, maximum 3 characters in the domain extension, etc. Because that is what you would normally want from a validator like this. Also, I would not use the URL class, but use a regular expression. A more elegant way to check this. The URL class approach could be retained for when the "internet" attribute is false -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira