[ http://opensource.atlassian.com/projects/hibernate/browse/HSHARDS-51?page... ] Max Ross commented on HSHARDS-51: --------------------------------- I'm struggling to figure out what I meant with this bug. I don't see a class called ShardResolutionStrategyImpl, and I don't see why implementations of ShardResolutionStrategy would need equals() and hashCode() in order to implement a cache-aware version since there would still only be one ShardResolutionStrategy - no need to hash or compare multiple instances. My guess is that I was actually referring to ShardResolutionStrategyDataImpl, to which I added hashCode() and equals() methods on Feb. 13. One _would_ need hashCode() and equals() to implement a cache-aware ShardResolutionStrategy. I'm guessing I just got mixed up. Let me know if that makes sense to you, and if so I'll mark this bug fixed. Thanks! Max -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HSHARDS-51?page... ] Max Ross commented on HSHARDS-51: --------------------------------- I'm ok with how equals() is currently implemented, but thanks for bringing it up. There are certainly cases where it makes sense to treat 2 objects as equal even though they are not instances of the same class, but I don't think this is one of them. A persistent entity is uniquely identified by its name and its id, so I'm not sure why someone would need to extend this class. Maybe we should just make the class final? We're still in beta so I'm okay with this, and if anyone hollers at least we'll learn about their use case. What do you think? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HSHARDS-51?page... ] Max Ross commented on HSHARDS-51: --------------------------------- I'll close the bug, but go ahead and make the class final and send me the CL. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira